2019-12-17 16:40:10 +01:00
|
|
|
#!/usr/bin/env python3
|
2014-10-09 16:02:46 -07:00
|
|
|
#
|
2018-12-13 11:43:32 -08:00
|
|
|
# Copyright 2014-2017 Cumulus Networks, Inc. All rights reserved.
|
2014-10-09 16:02:46 -07:00
|
|
|
# Author: Roopa Prabhu, roopa@cumulusnetworks.com
|
|
|
|
#
|
|
|
|
|
2018-07-10 00:18:39 +02:00
|
|
|
import socket
|
|
|
|
|
2014-10-09 16:02:46 -07:00
|
|
|
try:
|
2019-12-17 01:04:54 +01:00
|
|
|
from ifupdown2.lib.addon import Addon
|
|
|
|
from ifupdown2.nlmanager.nlmanager import Link
|
|
|
|
|
2018-12-13 11:43:32 -08:00
|
|
|
from ifupdown2.ifupdown.iface import *
|
|
|
|
from ifupdown2.ifupdown.utils import utils
|
|
|
|
|
|
|
|
from ifupdown2.ifupdownaddons.dhclient import dhclient
|
|
|
|
from ifupdown2.ifupdownaddons.modulebase import moduleBase
|
|
|
|
|
2020-01-07 16:58:56 +01:00
|
|
|
import ifupdown2.nlmanager.ipnetwork as ipnetwork
|
|
|
|
|
2018-12-13 11:43:32 -08:00
|
|
|
import ifupdown2.ifupdown.statemanager as statemanager
|
|
|
|
import ifupdown2.ifupdown.policymanager as policymanager
|
|
|
|
import ifupdown2.ifupdown.ifupdownflags as ifupdownflags
|
|
|
|
import ifupdown2.ifupdown.ifupdownconfig as ifupdownconfig
|
2019-12-17 17:25:32 +01:00
|
|
|
except (ImportError, ModuleNotFoundError):
|
2019-12-17 01:04:54 +01:00
|
|
|
from lib.addon import Addon
|
|
|
|
from nlmanager.nlmanager import Link
|
|
|
|
|
2014-10-09 16:02:46 -07:00
|
|
|
from ifupdown.iface import *
|
2016-09-14 16:00:25 -07:00
|
|
|
from ifupdown.utils import utils
|
2018-12-13 11:43:32 -08:00
|
|
|
|
2014-10-09 16:02:46 -07:00
|
|
|
from ifupdownaddons.dhclient import dhclient
|
2018-12-13 11:43:32 -08:00
|
|
|
from ifupdownaddons.modulebase import moduleBase
|
|
|
|
|
2020-01-07 16:58:56 +01:00
|
|
|
import nlmanager.ipnetwork as ipnetwork
|
|
|
|
|
2018-12-13 11:43:32 -08:00
|
|
|
import ifupdown.statemanager as statemanager
|
2016-04-15 10:16:53 +02:00
|
|
|
import ifupdown.policymanager as policymanager
|
2016-04-14 14:45:47 -07:00
|
|
|
import ifupdown.ifupdownflags as ifupdownflags
|
2018-12-13 11:43:32 -08:00
|
|
|
import ifupdown.ifupdownconfig as ifupdownconfig
|
|
|
|
|
2014-10-09 16:02:46 -07:00
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
class address(Addon, moduleBase):
|
2014-10-09 16:02:46 -07:00
|
|
|
""" ifupdown2 addon module to configure address, mtu, hwaddress, alias
|
|
|
|
(description) on an interface """
|
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
_modinfo = {
|
|
|
|
'mhelp': 'address configuration module for interfaces',
|
|
|
|
'attrs': {
|
|
|
|
'address': {
|
|
|
|
'help': 'The address of the interface. The format of the '
|
|
|
|
'address depends on the protocol. It is a dotted '
|
|
|
|
'quad for IP and a sequence of hexadecimal halfwords '
|
|
|
|
'separated by colons for IPv6. The ADDRESS may be '
|
|
|
|
'followed by a slash and a decimal number which '
|
|
|
|
'encodes the network prefix length.',
|
|
|
|
'validvals': ['<ipv4/prefixlen>', '<ipv6/prefixlen>'],
|
|
|
|
'multiline': True,
|
|
|
|
'example': [
|
|
|
|
'address 10.0.12.3/24',
|
|
|
|
'address 2000:1000:1000:1000:3::5/128'
|
|
|
|
]
|
|
|
|
},
|
|
|
|
'netmask': {
|
|
|
|
'help': 'Address netmask',
|
|
|
|
'example': ['netmask 255.255.255.0'],
|
|
|
|
'compat': True
|
|
|
|
},
|
|
|
|
'broadcast': {
|
|
|
|
'help': 'The broadcast address on the interface.',
|
|
|
|
'validvals': ['<ipv4>'],
|
|
|
|
'example': ['broadcast 10.0.1.255']
|
|
|
|
},
|
|
|
|
'scope': {
|
|
|
|
'help': 'The scope of the area where this address is valid. '
|
|
|
|
'The available scopes are listed in file /etc/iproute2/rt_scopes. '
|
|
|
|
'Predefined scope values are: '
|
|
|
|
'global - the address is globally valid. '
|
|
|
|
'site - (IPv6 only, deprecated) the address is site local, i.e. it is valid inside this site. '
|
|
|
|
'link - the address is link local, i.e. it is valid only on this device. '
|
|
|
|
'host - the address is valid only inside this host.',
|
|
|
|
'validvals': ['universe', 'site', 'link', 'host', 'nowhere'],
|
|
|
|
'example': ['scope host']
|
|
|
|
},
|
|
|
|
'preferred-lifetime': {
|
|
|
|
'help': 'The preferred lifetime of this address; see section '
|
|
|
|
'5.5.4 of RFC 4862. When it expires, the address is '
|
|
|
|
'no longer used for new outgoing connections. '
|
|
|
|
'Defaults to forever.',
|
|
|
|
'validrange': ['0', '65535'],
|
|
|
|
'example': [
|
|
|
|
'preferred-lifetime forever',
|
|
|
|
'preferred-lifetime 10'
|
|
|
|
]
|
|
|
|
},
|
|
|
|
'pointopoint': {
|
|
|
|
'help': 'Set the remote IP address for a point-to-point link',
|
|
|
|
'validvals': ['<ipv4/prefixlen>', '<ipv6/prefixlen>'],
|
|
|
|
'example': [
|
|
|
|
'pointopoint 10.10.10.42/32'
|
|
|
|
]
|
|
|
|
},
|
|
|
|
'gateway': {
|
|
|
|
'help': 'Default gateway',
|
|
|
|
'validvals': ['<ipv4>', '<ipv6>'],
|
|
|
|
'multiline': True,
|
|
|
|
'example': ['gateway 255.255.255.0']
|
|
|
|
},
|
|
|
|
'mtu': {
|
|
|
|
'help': 'Interface MTU (maximum transmission unit)',
|
|
|
|
'validrange': ['552', '9216'],
|
|
|
|
'example': ['mtu 1600'],
|
|
|
|
'default': '1500'
|
|
|
|
},
|
|
|
|
'hwaddress': {
|
|
|
|
'help': 'Hardware address (mac)',
|
|
|
|
'validvals': ['<mac>'],
|
|
|
|
'example': ['hwaddress 44:38:39:00:27:b8']
|
|
|
|
},
|
|
|
|
'alias': {
|
|
|
|
'help': 'description/alias: give the device a symbolic name for easy reference.',
|
|
|
|
'example': ['alias testnetwork']
|
|
|
|
},
|
|
|
|
'address-purge': {
|
|
|
|
'help': 'Purge existing addresses. By default any existing '
|
|
|
|
'ip addresses on an interface are purged to match '
|
|
|
|
'persistant addresses in the interfaces file. Set '
|
|
|
|
'this attribute to \'no\' if you want to preserve '
|
|
|
|
'existing addresses',
|
|
|
|
'validvals': ['yes', 'no'],
|
|
|
|
'default': 'yes',
|
|
|
|
'example': ['address-purge yes/no']
|
|
|
|
},
|
|
|
|
'clagd-vxlan-anycast-ip': {
|
|
|
|
'help': 'Anycast local IP address for dual connected VxLANs',
|
|
|
|
'validvals': ['<ipv4>'],
|
|
|
|
'example': ['clagd-vxlan-anycast-ip 36.0.0.11']
|
|
|
|
},
|
|
|
|
'ip-forward': {
|
|
|
|
'help': 'ip forwarding flag',
|
|
|
|
'validvals': ['on', 'off', 'yes', 'no', '0', '1'],
|
|
|
|
'default': 'off',
|
|
|
|
'example': ['ip-forward off']
|
|
|
|
},
|
|
|
|
'ip6-forward': {
|
|
|
|
'help': 'ipv6 forwarding flag',
|
|
|
|
'validvals': ['on', 'off', 'yes', 'no', '0', '1'],
|
|
|
|
'default': 'off',
|
|
|
|
'example': ['ip6-forward off']
|
|
|
|
},
|
|
|
|
'mpls-enable': {
|
|
|
|
'help': 'mpls enable flag',
|
|
|
|
'validvals': ['yes', 'no'],
|
|
|
|
'default': 'no',
|
|
|
|
'example': ['mpls-enable yes']
|
|
|
|
},
|
|
|
|
'ipv6-addrgen': {
|
|
|
|
'help': 'enable disable ipv6 link addrgenmode',
|
|
|
|
'validvals': ['on', 'off'],
|
|
|
|
'default': 'on',
|
|
|
|
'example': [
|
|
|
|
'ipv6-addrgen on',
|
|
|
|
'ipv6-addrgen off'
|
|
|
|
]
|
|
|
|
},
|
|
|
|
'arp-accept': {
|
|
|
|
'help': 'Allow gratuitous arp to update arp table',
|
|
|
|
'validvals': ['on', 'off', 'yes', 'no', '0', '1'],
|
|
|
|
'default': 'off',
|
|
|
|
'example': ['arp-accept on']
|
|
|
|
},
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
DEFAULT_MTU_STRING = "1500"
|
2014-10-09 16:02:46 -07:00
|
|
|
|
|
|
|
def __init__(self, *args, **kargs):
|
2019-12-17 01:04:54 +01:00
|
|
|
Addon.__init__(self)
|
2014-10-09 16:02:46 -07:00
|
|
|
moduleBase.__init__(self, *args, **kargs)
|
2014-11-03 17:55:51 -08:00
|
|
|
self._bridge_fdb_query_cache = {}
|
2018-12-13 11:43:32 -08:00
|
|
|
self.ipforward = policymanager.policymanager_api.get_attr_default(module_name=self.__class__.__name__, attr='ip-forward')
|
|
|
|
self.ip6forward = policymanager.policymanager_api.get_attr_default(module_name=self.__class__.__name__, attr='ip6-forward')
|
|
|
|
self.ifaces_defaults = policymanager.policymanager_api.get_iface_defaults(module_name=self.__class__.__name__)
|
|
|
|
self.enable_l3_iface_forwarding_checks = utils.get_boolean_from_string(
|
|
|
|
policymanager.policymanager_api.get_module_globals(
|
|
|
|
self.__class__.__name__,
|
|
|
|
'enable_l3_iface_forwarding_checks'
|
|
|
|
)
|
|
|
|
)
|
2016-11-07 10:48:24 -08:00
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
self.default_mtu = self.__policy_get_default_mtu()
|
2020-02-24 14:26:31 +01:00
|
|
|
self.default_mgmt_intf_mtu = self.__policy_get_mgmt_intf_mtu()
|
|
|
|
if not self.default_mgmt_intf_mtu:
|
|
|
|
self.default_mgmt_intf_mtu = self.default_mtu
|
|
|
|
self.default_mgmt_intf_mtu_int = self.default_mtu_int
|
|
|
|
self.max_mtu = self.__policy_get_max_mtu()
|
2016-11-07 10:48:24 -08:00
|
|
|
|
2020-01-07 16:58:56 +01:00
|
|
|
self.default_loopback_addresses = (ipnetwork.IPNetwork('127.0.0.1/8'), ipnetwork.IPNetwork('::1/128'))
|
2018-12-13 11:43:32 -08:00
|
|
|
|
2018-10-19 17:42:24 +02:00
|
|
|
self.l3_intf_arp_accept = utils.get_boolean_from_string(
|
|
|
|
policymanager.policymanager_api.get_module_globals(
|
|
|
|
module_name=self.__class__.__name__,
|
|
|
|
attr='l3_intf_arp_accept'
|
|
|
|
),
|
|
|
|
default=False
|
|
|
|
)
|
|
|
|
|
2018-10-30 11:31:11 +01:00
|
|
|
self.l3_intf_default_gateway_set_onlink = utils.get_boolean_from_string(
|
|
|
|
policymanager.policymanager_api.get_module_globals(
|
|
|
|
module_name=self.__class__.__name__,
|
|
|
|
attr='l3_intf_default_gateway_set_onlink'
|
|
|
|
),
|
|
|
|
default=True
|
|
|
|
)
|
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
def __policy_get_default_mtu(self):
|
|
|
|
default_mtu = policymanager.policymanager_api.get_attr_default(
|
|
|
|
module_name=self.__class__.__name__,
|
|
|
|
attr="mtu"
|
|
|
|
)
|
|
|
|
|
|
|
|
if not default_mtu:
|
|
|
|
default_mtu = self.DEFAULT_MTU_STRING
|
|
|
|
|
|
|
|
try:
|
|
|
|
self.default_mtu_int = int(default_mtu)
|
|
|
|
except ValueError as e:
|
|
|
|
self.logger.error("address: invalid default mtu \"%s\" set via policy: %s" % (default_mtu, str(e)))
|
|
|
|
default_mtu = self.DEFAULT_MTU_STRING
|
|
|
|
self.default_mtu_int = int(self.DEFAULT_MTU_STRING)
|
|
|
|
|
|
|
|
self.logger.info("address: using default mtu %s" % default_mtu)
|
|
|
|
|
|
|
|
return default_mtu
|
|
|
|
|
|
|
|
def __policy_get_max_mtu(self):
|
|
|
|
max_mtu = policymanager.policymanager_api.get_module_globals(module_name=self.__class__.__name__, attr="max_mtu")
|
|
|
|
if max_mtu:
|
|
|
|
try:
|
|
|
|
max_mtu_int = int(max_mtu)
|
|
|
|
self.logger.info("address: using max mtu %s" % self.max_mtu)
|
|
|
|
return max_mtu_int
|
|
|
|
except ValueError as e:
|
|
|
|
self.logger.warning("address: policy max_mtu: %s" % str(e))
|
|
|
|
else:
|
|
|
|
self.logger.info("address: max_mtu undefined")
|
|
|
|
return 0
|
|
|
|
|
2020-02-24 14:26:31 +01:00
|
|
|
def __policy_get_mgmt_intf_mtu(self):
|
|
|
|
default_mgmt_mtu = policymanager.policymanager_api.get_module_globals(
|
|
|
|
module_name=self.__class__.__name__,
|
|
|
|
attr="mgmt_intf_mtu")
|
|
|
|
self.default_mgmt_mtu_int = None
|
|
|
|
|
|
|
|
if not default_mgmt_mtu:
|
|
|
|
return None
|
|
|
|
|
|
|
|
try:
|
|
|
|
self.default_mgmt_mtu_int = int(default_mgmt_mtu)
|
|
|
|
except ValueError as e:
|
|
|
|
self.logger.error("address: invalid default mgmt mtu \"%s\" set via policy: %s" % (default_mgmt_mtu, str(e)))
|
|
|
|
default_mgmt_mtu = self.DEFAULT_MTU_STRING
|
|
|
|
self.default_mgmt_mtu_int = int(self.DEFAULT_MTU_STRING)
|
|
|
|
|
|
|
|
self.logger.info("address: using default mgmt interface mtu %s" % default_mgmt_mtu)
|
|
|
|
|
|
|
|
return default_mgmt_mtu
|
|
|
|
|
2016-12-01 11:48:16 -08:00
|
|
|
def syntax_check(self, ifaceobj, ifaceobj_getfunc=None):
|
2016-11-22 17:06:16 +01:00
|
|
|
return (self.syntax_check_multiple_gateway(ifaceobj)
|
2016-12-01 11:48:16 -08:00
|
|
|
and self.syntax_check_addr_allowed_on(ifaceobj, True)
|
2018-12-13 11:43:32 -08:00
|
|
|
and self.syntax_check_mtu(ifaceobj, ifaceobj_getfunc)
|
|
|
|
and self.syntax_check_sysctls(ifaceobj)
|
|
|
|
and self.syntax_check_enable_l3_iface_forwardings(ifaceobj, ifaceobj_getfunc, syntax_check=True))
|
|
|
|
|
|
|
|
def syntax_check_enable_l3_iface_forwardings(self, ifaceobj, ifaceobj_getfunc, syntax_check=False):
|
|
|
|
if (self.enable_l3_iface_forwarding_checks
|
|
|
|
and (ifaceobj.link_kind & ifaceLinkKind.VLAN
|
|
|
|
or ifaceobj.link_kind & ifaceLinkKind.BRIDGE)
|
|
|
|
and not ifaceobj.link_privflags & ifaceLinkPrivFlags.BRIDGE_PORT):
|
|
|
|
|
|
|
|
ifname = ifaceobj.name
|
|
|
|
vlan_addr = None
|
|
|
|
vlan_ipforward_off = None
|
|
|
|
|
|
|
|
for obj in ifaceobj_getfunc(ifname) or [ifaceobj]:
|
|
|
|
if not vlan_addr:
|
|
|
|
vlan_addr = obj.get_attr_value('address')
|
|
|
|
|
|
|
|
if not vlan_ipforward_off:
|
|
|
|
ip_forward_value = obj.get_attr_value_first('ip-forward')
|
|
|
|
|
|
|
|
if ip_forward_value and not utils.get_boolean_from_string(ip_forward_value):
|
|
|
|
vlan_ipforward_off = True
|
|
|
|
|
|
|
|
if vlan_addr and vlan_ipforward_off:
|
|
|
|
if syntax_check:
|
|
|
|
raise Exception(
|
|
|
|
'configuring ip-forward off and ip address(es) (%s) is not compatible'
|
|
|
|
% (', '.join(vlan_addr))
|
|
|
|
)
|
|
|
|
else:
|
|
|
|
raise Exception(
|
|
|
|
'%s: configuring ip-forward off and ip address(es) (%s) is not compatible'
|
|
|
|
% (ifname, ', '.join(vlan_addr))
|
|
|
|
)
|
|
|
|
|
|
|
|
return True
|
|
|
|
|
|
|
|
def syntax_check_sysctls(self, ifaceobj):
|
|
|
|
result = True
|
|
|
|
bridge_port = (ifaceobj.link_privflags & ifaceLinkPrivFlags.BRIDGE_PORT)
|
|
|
|
ipforward = ifaceobj.get_attr_value_first('ip-forward')
|
|
|
|
if bridge_port and ipforward:
|
|
|
|
result = False
|
|
|
|
self.log_error('%s: \'ip-forward\' is not supported for '
|
|
|
|
'bridge port' %ifaceobj.name)
|
|
|
|
ip6forward = ifaceobj.get_attr_value_first('ip6-forward')
|
|
|
|
if bridge_port and ip6forward:
|
|
|
|
result = False
|
|
|
|
self.log_error('%s: \'ip6-forward\' is not supported for '
|
|
|
|
'bridge port' %ifaceobj.name)
|
|
|
|
return result
|
2016-12-01 11:48:16 -08:00
|
|
|
|
|
|
|
def syntax_check_mtu(self, ifaceobj, ifaceobj_getfunc):
|
2019-12-17 01:04:54 +01:00
|
|
|
mtu_str = ifaceobj.get_attr_value_first('mtu')
|
|
|
|
if mtu_str:
|
|
|
|
try:
|
|
|
|
mtu_int = int(mtu_str)
|
|
|
|
except ValueError as e:
|
|
|
|
self.logger.warning("%s: invalid mtu %s: %s" % (ifaceobj.name, mtu_str, str(e)))
|
|
|
|
return False
|
|
|
|
return self._check_mtu_config(ifaceobj, mtu_str, mtu_int, ifaceobj_getfunc, syntaxcheck=True)
|
2016-12-01 11:48:16 -08:00
|
|
|
return True
|
2016-11-22 17:06:16 +01:00
|
|
|
|
|
|
|
def syntax_check_addr_allowed_on(self, ifaceobj, syntax_check=False):
|
|
|
|
if ifaceobj.get_attr_value('address'):
|
|
|
|
return utils.is_addr_ip_allowed_on(ifaceobj, syntax_check=syntax_check)
|
|
|
|
return True
|
|
|
|
|
2020-01-07 16:58:56 +01:00
|
|
|
def _syntax_check_multiple_gateway(self, family, found, addr, version):
|
|
|
|
if ipnetwork.IPNetwork(addr).version == version:
|
2016-11-21 16:43:57 +01:00
|
|
|
if found:
|
|
|
|
raise Exception('%s: multiple gateways for %s family'
|
|
|
|
% (addr, family))
|
|
|
|
return True
|
|
|
|
return False
|
|
|
|
|
2016-11-22 17:06:16 +01:00
|
|
|
def syntax_check_multiple_gateway(self, ifaceobj):
|
2016-11-21 16:43:57 +01:00
|
|
|
result = True
|
|
|
|
inet = False
|
|
|
|
inet6 = False
|
|
|
|
gateways = ifaceobj.get_attr_value('gateway')
|
|
|
|
for addr in gateways if gateways else []:
|
|
|
|
try:
|
2020-01-07 16:58:56 +01:00
|
|
|
if self._syntax_check_multiple_gateway('inet', inet, addr, 4):
|
2016-11-21 16:43:57 +01:00
|
|
|
inet = True
|
2020-01-07 16:58:56 +01:00
|
|
|
if self._syntax_check_multiple_gateway('inet6', inet6, addr, 6):
|
2016-11-21 16:43:57 +01:00
|
|
|
inet6 = True
|
|
|
|
except Exception as e:
|
|
|
|
self.logger.warning('%s: address: %s' % (ifaceobj.name, str(e)))
|
|
|
|
result = False
|
|
|
|
return result
|
|
|
|
|
2014-11-17 16:23:42 -08:00
|
|
|
def _address_valid(self, addrs):
|
|
|
|
if not addrs:
|
|
|
|
return False
|
2019-12-17 16:55:49 +01:00
|
|
|
if any([True if a[:7] != '0.0.0.0'
|
|
|
|
else False for a in addrs]):
|
2014-11-17 16:23:42 -08:00
|
|
|
return True
|
|
|
|
return False
|
|
|
|
|
2016-03-15 15:41:04 +01:00
|
|
|
def _get_hwaddress(self, ifaceobj):
|
2018-12-13 11:43:32 -08:00
|
|
|
return utils.strip_hwaddress(ifaceobj.get_attr_value_first('hwaddress'))
|
2016-03-15 15:41:04 +01:00
|
|
|
|
|
|
|
def _process_bridge(self, ifaceobj, up):
|
|
|
|
hwaddress = self._get_hwaddress(ifaceobj)
|
2014-11-17 16:23:42 -08:00
|
|
|
addrs = ifaceobj.get_attr_value_first('address')
|
2019-09-03 09:43:38 +02:00
|
|
|
arp_accept = ifaceobj.get_attr_value_first('arp-accept')
|
|
|
|
arp_accept = utils.boolean_support_binary(arp_accept)
|
2014-11-17 16:23:42 -08:00
|
|
|
is_vlan_dev_on_vlan_aware_bridge = False
|
2019-12-17 01:04:54 +01:00
|
|
|
is_bridge = self.cache.get_link_kind(ifaceobj.name) == 'bridge'
|
2014-11-17 16:23:42 -08:00
|
|
|
if not is_bridge:
|
2018-12-13 11:43:32 -08:00
|
|
|
if ifaceobj.link_kind & ifaceLinkKind.VLAN:
|
|
|
|
bridgename = ifaceobj.lowerifaces[0]
|
|
|
|
vlan = self._get_vlan_id(ifaceobj)
|
2019-12-17 01:04:54 +01:00
|
|
|
is_vlan_dev_on_vlan_aware_bridge = self.cache.bridge_is_vlan_aware(bridgename)
|
|
|
|
if ((is_bridge and not self.cache.bridge_is_vlan_aware(ifaceobj.name))
|
2014-12-17 15:09:52 -08:00
|
|
|
or is_vlan_dev_on_vlan_aware_bridge):
|
2018-10-19 17:42:24 +02:00
|
|
|
if self._address_valid(addrs):
|
|
|
|
if self.l3_intf_arp_accept:
|
|
|
|
if up:
|
|
|
|
self.write_file('/proc/sys/net/ipv4/conf/%s' % ifaceobj.name +
|
|
|
|
'/arp_accept', '1')
|
|
|
|
else:
|
|
|
|
self.write_file('/proc/sys/net/ipv4/conf/%s' % ifaceobj.name +
|
|
|
|
'/arp_accept', '0')
|
|
|
|
else:
|
2019-09-03 09:43:38 +02:00
|
|
|
self.write_file('/proc/sys/net/ipv4/conf/%s/arp_accept' % ifaceobj.name, arp_accept)
|
2014-11-17 16:23:42 -08:00
|
|
|
if hwaddress and is_vlan_dev_on_vlan_aware_bridge:
|
2019-04-03 02:11:29 +08:00
|
|
|
if up:
|
|
|
|
# check statemanager to delete the old entry if necessary
|
|
|
|
try:
|
|
|
|
for old_obj in statemanager.statemanager_api.get_ifaceobjs(ifaceobj.name) or []:
|
|
|
|
old_hwaddress = old_obj.get_attr_value_first("hwaddress")
|
2019-12-17 01:04:54 +01:00
|
|
|
if old_hwaddress and utils.mac_str_to_int(old_hwaddress) != utils.mac_str_to_int(hwaddress):
|
|
|
|
self.iproute2.bridge_fdb_del(bridgename, old_hwaddress, vlan)
|
2019-04-03 02:11:29 +08:00
|
|
|
break
|
2020-06-24 01:12:24 +02:00
|
|
|
except Exception:
|
2019-04-03 02:11:29 +08:00
|
|
|
pass
|
2019-12-17 01:04:54 +01:00
|
|
|
self.iproute2.bridge_fdb_add(bridgename, hwaddress, vlan)
|
2019-04-03 02:11:29 +08:00
|
|
|
else:
|
2019-12-17 01:04:54 +01:00
|
|
|
self.iproute2.bridge_fdb_del(bridgename, hwaddress, vlan)
|
2014-10-28 23:04:40 -07:00
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
def __get_ip_addr_with_attributes(self, ifaceobj_list, ifname):
|
2020-01-07 16:58:56 +01:00
|
|
|
user_config_ip_addrs_list = []
|
2015-11-16 21:00:40 -08:00
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
try:
|
|
|
|
for ifaceobj in ifaceobj_list:
|
2015-11-16 21:00:40 -08:00
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
user_addrs = ifaceobj.get_attr_value("address")
|
2015-11-16 21:00:40 -08:00
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
if not user_addrs:
|
|
|
|
continue
|
|
|
|
|
|
|
|
if not self.syntax_check_addr_allowed_on(ifaceobj, syntax_check=False):
|
|
|
|
return False, None
|
|
|
|
|
|
|
|
for index, addr in enumerate(user_addrs):
|
|
|
|
addr_attributes = {}
|
|
|
|
addr_obj = None
|
|
|
|
|
|
|
|
# convert the ip from string to IPNetwork object
|
|
|
|
if "/" in addr:
|
2020-01-07 16:58:56 +01:00
|
|
|
addr_obj = ipnetwork.IPNetwork(addr)
|
2017-08-23 23:11:57 +02:00
|
|
|
else:
|
2019-12-17 01:04:54 +01:00
|
|
|
netmask = ifaceobj.get_attr_value_n("netmask", index)
|
|
|
|
|
|
|
|
if netmask:
|
2020-01-07 16:58:56 +01:00
|
|
|
addr_obj = ipnetwork.IPNetwork(addr, netmask)
|
2019-12-17 01:04:54 +01:00
|
|
|
else:
|
2020-01-07 16:58:56 +01:00
|
|
|
addr_obj = ipnetwork.IPNetwork(addr)
|
2019-12-17 01:04:54 +01:00
|
|
|
|
|
|
|
for attr_name in ("broadcast", "scope", "preferred-lifetime"):
|
|
|
|
attr_value = ifaceobj.get_attr_value_n(attr_name, index)
|
|
|
|
if attr_value:
|
|
|
|
addr_attributes[attr_name] = attr_value
|
|
|
|
|
|
|
|
pointopoint = ifaceobj.get_attr_value_n("pointopoint", index)
|
|
|
|
try:
|
|
|
|
if pointopoint:
|
2020-01-07 16:58:56 +01:00
|
|
|
addr_attributes["pointopoint"] = ipnetwork.IPNetwork(pointopoint)
|
2019-12-17 01:04:54 +01:00
|
|
|
except Exception as e:
|
|
|
|
self.logger.warning("%s: pointopoint %s: %s" % (ifaceobj.name, pointopoint, str(e)))
|
|
|
|
|
|
|
|
user_config_ip_addrs_list.append((addr_obj, addr_attributes))
|
|
|
|
except Exception as e:
|
|
|
|
self.logger.warning("%s: convert string ip address into IPNetwork object: %s" % (ifname, str(e)))
|
|
|
|
return False, None
|
|
|
|
|
|
|
|
return True, user_config_ip_addrs_list
|
|
|
|
|
|
|
|
def __add_ip_addresses_with_attributes(self, ifaceobj, ifname, user_config_ip_addrs):
|
2020-09-28 17:59:27 +02:00
|
|
|
ipv6_is_disabled = None
|
2019-12-17 01:04:54 +01:00
|
|
|
try:
|
|
|
|
for ip, attributes in user_config_ip_addrs:
|
2020-09-28 17:59:27 +02:00
|
|
|
|
|
|
|
if ip.version == 6 and ipv6_is_disabled is None:
|
|
|
|
# check (only once) if ipv6 is disabled on this device
|
|
|
|
proc_path = "/proc/sys/net/ipv6/conf/%s/disable_ipv6" % ifname
|
|
|
|
ipv6_is_disabled = utils.get_boolean_from_string(self.read_file_oneline(proc_path))
|
|
|
|
|
|
|
|
if ipv6_is_disabled:
|
|
|
|
# enable ipv6
|
|
|
|
self.write_file(proc_path, "0")
|
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
if attributes:
|
|
|
|
self.netlink.addr_add(
|
|
|
|
ifname, ip,
|
|
|
|
scope=attributes.get("scope"),
|
|
|
|
peer=attributes.get("pointopoint"),
|
|
|
|
broadcast=attributes.get("broadcast"),
|
|
|
|
preferred_lifetime=attributes.get("preferred-lifetime")
|
|
|
|
)
|
2016-05-09 18:48:52 -07:00
|
|
|
else:
|
2019-12-17 01:04:54 +01:00
|
|
|
self.netlink.addr_add(ifname, ip)
|
|
|
|
except Exception as e:
|
|
|
|
self.log_error(str(e), ifaceobj)
|
2016-05-09 18:48:52 -07:00
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
@staticmethod
|
|
|
|
def __add_loopback_anycast_ip_to_running_ip_addr_list(ifaceobjlist):
|
|
|
|
"""
|
|
|
|
if anycast address is configured on 'lo' and is in running
|
|
|
|
config add it to newaddrs so that ifreload doesn't wipe it out
|
|
|
|
:param ifaceobjlist:
|
|
|
|
:param running_ip_addrs:
|
|
|
|
"""
|
|
|
|
anycast_ip_addr = None
|
2015-11-16 21:00:40 -08:00
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
for ifaceobj in ifaceobjlist:
|
|
|
|
anycast_addr = ifaceobj.get_attr_value_first("clagd-vxlan-anycast-ip")
|
|
|
|
if anycast_addr:
|
2020-01-07 16:58:56 +01:00
|
|
|
anycast_ip_addr = ipnetwork.IPNetwork(anycast_addr)
|
2019-12-17 01:04:54 +01:00
|
|
|
|
2020-01-07 16:58:56 +01:00
|
|
|
return anycast_ip_addr
|
2019-12-17 01:04:54 +01:00
|
|
|
|
|
|
|
def process_addresses(self, ifaceobj, ifaceobj_getfunc=None, force_reapply=False):
|
|
|
|
squash_addr_config = ifupdownconfig.config.get("addr_config_squash", "0") == "1"
|
|
|
|
|
|
|
|
if squash_addr_config and not ifaceobj.flags & ifaceobj.YOUNGEST_SIBLING:
|
2015-11-16 21:00:40 -08:00
|
|
|
return
|
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
ifname = ifaceobj.name
|
|
|
|
purge_addresses = utils.get_boolean_from_string(ifaceobj.get_attr_value_first("address-purge"), default=True)
|
|
|
|
|
|
|
|
if not squash_addr_config and ifaceobj.flags & iface.HAS_SIBLINGS:
|
|
|
|
# if youngest sibling and squash addr is not set
|
|
|
|
# print a warning that addresses will not be purged
|
|
|
|
if ifaceobj.flags & iface.YOUNGEST_SIBLING:
|
|
|
|
self.logger.warning("%s: interface has multiple iface stanzas, skip purging existing addresses" % ifname)
|
|
|
|
purge_addresses = False
|
2015-11-16 21:00:40 -08:00
|
|
|
|
|
|
|
if squash_addr_config and ifaceobj.flags & iface.HAS_SIBLINGS:
|
2019-12-17 01:04:54 +01:00
|
|
|
ifaceobj_list = ifaceobj_getfunc(ifname)
|
2015-11-16 21:00:40 -08:00
|
|
|
else:
|
2019-12-17 01:04:54 +01:00
|
|
|
ifaceobj_list = [ifaceobj]
|
2018-12-13 11:43:32 -08:00
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
addr_supported, user_config_ip_addrs_list = self.__get_ip_addr_with_attributes(ifaceobj_list, ifname)
|
2018-12-13 11:43:32 -08:00
|
|
|
|
2015-11-16 21:00:40 -08:00
|
|
|
if not addr_supported:
|
|
|
|
return
|
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
if not ifupdownflags.flags.PERFMODE and purge_addresses:
|
|
|
|
# if perfmode is not set and purge addresses is set to True
|
2015-11-16 21:00:40 -08:00
|
|
|
# lets purge addresses not in the config
|
2019-12-17 01:04:54 +01:00
|
|
|
anycast_ip = None
|
|
|
|
|
2020-01-07 16:58:56 +01:00
|
|
|
running_ip_addrs = self.cache.get_managed_ip_addresses(ifname, ifaceobj_list)
|
2015-11-16 21:00:40 -08:00
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
if ifaceobj.link_privflags & ifaceLinkPrivFlags.LOOPBACK:
|
|
|
|
anycast_ip = self.__add_loopback_anycast_ip_to_running_ip_addr_list(ifaceobj_list)
|
2015-11-16 21:00:40 -08:00
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
user_ip4, user_ip6, ordered_user_configured_ips = self.order_user_configured_addrs(user_config_ip_addrs_list)
|
2018-12-13 11:43:32 -08:00
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
if ordered_user_configured_ips == running_ip_addrs or self.compare_running_ips_and_user_config(user_ip4, user_ip6, running_ip_addrs):
|
2016-05-09 18:48:52 -07:00
|
|
|
if force_reapply:
|
2019-12-17 01:04:54 +01:00
|
|
|
self.__add_ip_addresses_with_attributes(ifaceobj, ifname, user_config_ip_addrs_list)
|
2014-10-09 16:02:46 -07:00
|
|
|
return
|
|
|
|
try:
|
2019-12-17 01:04:54 +01:00
|
|
|
# if primary address is not same, there is no need to keep any, reset all addresses.
|
2020-01-07 16:58:56 +01:00
|
|
|
if ordered_user_configured_ips and running_ip_addrs and ordered_user_configured_ips[0] != running_ip_addrs[0]:
|
2019-12-17 01:04:54 +01:00
|
|
|
self.logger.info("%s: primary ip changed (from %s to %s) we need to purge all ip addresses and re-add them"
|
2020-01-07 16:58:56 +01:00
|
|
|
% (ifname, ordered_user_configured_ips[0], running_ip_addrs[0]))
|
2018-12-13 11:43:32 -08:00
|
|
|
skip_addrs = []
|
2014-10-09 16:02:46 -07:00
|
|
|
else:
|
2019-12-17 01:04:54 +01:00
|
|
|
skip_addrs = ordered_user_configured_ips
|
|
|
|
|
|
|
|
if anycast_ip:
|
|
|
|
skip_addrs.append(anycast_ip)
|
|
|
|
|
2020-01-07 16:58:56 +01:00
|
|
|
for addr in running_ip_addrs:
|
2018-12-13 11:43:32 -08:00
|
|
|
if addr in skip_addrs:
|
|
|
|
continue
|
2020-01-07 16:58:56 +01:00
|
|
|
self.netlink.addr_del(ifname, addr)
|
2019-12-17 16:55:49 +01:00
|
|
|
except Exception as e:
|
2014-10-09 16:02:46 -07:00
|
|
|
self.log_warn(str(e))
|
2019-12-17 01:04:54 +01:00
|
|
|
if not user_config_ip_addrs_list:
|
2014-10-09 16:02:46 -07:00
|
|
|
return
|
2019-12-17 01:04:54 +01:00
|
|
|
self.__add_ip_addresses_with_attributes(ifaceobj, ifname, user_config_ip_addrs_list)
|
|
|
|
|
2018-12-13 11:43:32 -08:00
|
|
|
def compare_running_ips_and_user_config(self, user_ip4, user_ip6, running_addrs):
|
|
|
|
"""
|
|
|
|
We need to compare the user config ips and the running ips.
|
|
|
|
ip4 ordering matters (primary etc) but ip6 order doesn't matter
|
|
|
|
|
|
|
|
this function replaces the strict comparison previously in place
|
|
|
|
if newaddrs == running_addrs ?
|
|
|
|
|
|
|
|
We will compare if the ip4 ordering is correct, then check if all
|
|
|
|
ip6 are present in the list (without checking the ordering)
|
|
|
|
"""
|
|
|
|
if (user_ip4 or user_ip6) and not running_addrs:
|
|
|
|
return False
|
|
|
|
elif running_addrs and not user_ip4 and not user_ip6:
|
|
|
|
return False
|
|
|
|
elif not running_addrs and not user_ip4 and not user_ip6:
|
|
|
|
return True
|
|
|
|
|
|
|
|
len_ip4 = len(user_ip4)
|
|
|
|
len_running_addrs = len(running_addrs)
|
|
|
|
|
|
|
|
if len_ip4 > len_running_addrs:
|
|
|
|
return False
|
|
|
|
|
|
|
|
i = 0
|
|
|
|
while i < len_ip4:
|
|
|
|
if user_ip4[i] != running_addrs[i]:
|
|
|
|
return False
|
|
|
|
i += 1
|
|
|
|
|
|
|
|
if len_ip4 > 0:
|
|
|
|
running_ip6 = running_addrs[len_ip4:]
|
|
|
|
else:
|
|
|
|
running_ip6 = running_addrs
|
|
|
|
|
|
|
|
i = 0
|
|
|
|
len_ip6 = len(user_ip6)
|
|
|
|
|
|
|
|
for ip6 in running_ip6:
|
|
|
|
if ip6 not in user_ip6:
|
|
|
|
return False
|
|
|
|
i += 1
|
|
|
|
|
|
|
|
return i == len_ip6
|
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
@staticmethod
|
|
|
|
def order_user_configured_addrs(user_config_addrs):
|
2018-12-13 11:43:32 -08:00
|
|
|
ip4 = []
|
|
|
|
ip6 = []
|
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
for a, _ in user_config_addrs:
|
|
|
|
if a.version == 6:
|
2020-01-07 16:58:56 +01:00
|
|
|
ip6.append(a)
|
2018-12-13 11:43:32 -08:00
|
|
|
else:
|
2020-01-07 16:58:56 +01:00
|
|
|
ip4.append(a)
|
2018-12-13 11:43:32 -08:00
|
|
|
|
|
|
|
return ip4, ip6, ip4 + ip6
|
|
|
|
|
|
|
|
def _delete_gateway(self, ifaceobj, gateways, vrf, metric):
|
|
|
|
for del_gw in gateways:
|
2016-07-20 15:23:13 -07:00
|
|
|
try:
|
2019-12-17 01:04:54 +01:00
|
|
|
self.iproute2.route_del_gateway(ifaceobj.name, del_gw, vrf, metric)
|
2017-01-13 06:51:28 +03:00
|
|
|
except Exception as e:
|
|
|
|
self.logger.debug('%s: %s' % (ifaceobj.name, str(e)))
|
2018-12-13 11:43:32 -08:00
|
|
|
|
|
|
|
def _add_delete_gateway(self, ifaceobj, gateways=[], prev_gw=[]):
|
|
|
|
vrf = ifaceobj.get_attr_value_first('vrf')
|
|
|
|
metric = ifaceobj.get_attr_value_first('metric')
|
|
|
|
self._delete_gateway(ifaceobj, list(set(prev_gw) - set(gateways)),
|
|
|
|
vrf, metric)
|
2017-01-17 17:55:35 -08:00
|
|
|
for add_gw in gateways:
|
2016-07-20 15:23:13 -07:00
|
|
|
try:
|
2019-12-17 01:04:54 +01:00
|
|
|
self.iproute2.route_add_gateway(ifaceobj.name, add_gw, vrf, metric, onlink=self.l3_intf_default_gateway_set_onlink)
|
2017-01-13 06:51:28 +03:00
|
|
|
except Exception as e:
|
|
|
|
self.log_error('%s: %s' % (ifaceobj.name, str(e)))
|
2016-07-20 15:23:13 -07:00
|
|
|
|
|
|
|
def _get_prev_gateway(self, ifaceobj, gateways):
|
|
|
|
ipv = []
|
|
|
|
saved_ifaceobjs = statemanager.statemanager_api.get_ifaceobjs(ifaceobj.name)
|
|
|
|
if not saved_ifaceobjs:
|
|
|
|
return ipv
|
|
|
|
prev_gateways = saved_ifaceobjs[0].get_attr_value('gateway')
|
|
|
|
if not prev_gateways:
|
|
|
|
return ipv
|
|
|
|
return prev_gateways
|
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
def _check_mtu_config(self, ifaceobj, mtu_str, mtu_int, ifaceobj_getfunc, syntaxcheck=False):
|
addons: address: propagate physical mtu to upper vlan devices
Ticket: CM-13221
Reviewed By: julien, nikhil
Testing Done: tested mtu propagation for vlan devices
This is a followup to commit
29de36f36053 ("addons: address: various fixes for mtu handling").
This fixes a pending issue with mtu readjustments on vlan
interfaces on top of physical interfaces.
eg: with the below config:
$ifquery -a
auto swp1.100
iface swp1.100
auto swp1
iface swp1
mtu 9000
/* at boot-up swp1 and swp1.100 mtu is set to 9000 */
$ifdown swp1 /* resets swp1 mtu to 1500. swp1.100 mtu is reset to 1500
implicitly by the kernel */
$ifup swp1 /* swp1 mtu is set to 1500. But swp1.100 mtu stays at 1500
*/
This problem is unique to physical interfaces and vlan devices on
physical interfaces. This is because, when logical interface is ifdown,
kernel deletes all its sub-interfaces. And on the way up (ifup),
ifupdown2 re-creates all these sub-interfaces for you....that
sequence re-adjusts the mtu. For physical
interfaces, since the sub-interfaces are not deleted,
ifupdown2 does not do anything...and mtu of the subinterface is left to
what it was. And this ends up being what was there initially when the
lower interface went down. And ifdown of the lower physical interface,
resets the physical mtu to default which is 1500. The sub-interface mtu
returns to 1500 while the lower physical interface remains down.
(another detail here: kernel vlan driver re-adjusts mtu of the vlan
sub-interface on its own when the lower device mtu becomes lower. But
does not re-adjust its mtu when the lower device mtu increases. This is
expected and correct behavior). We will have to work around it in
ifupdown2 to suit our needs.
two solutions:
a) when physical interface is brought up, ifupdown2 can go and
pro-actively adjust the upper sub-interface mtu
OR
b) when physical interface is brought down, do not reset the mtu on the
device to default
(b) is the easiest and costs less if we dont expect the mtu of a
physical device to go to default on ifdown.
(a) is doable too, but is additional cost to go over all upper
interfaces.
This patch fixes this problem with solution (a). But, makes sure
this does not add additional cost to the default ifreload -a path.
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
2016-11-28 13:24:31 -08:00
|
|
|
retval = True
|
|
|
|
if (ifaceobj.link_kind & ifaceLinkKind.BRIDGE):
|
|
|
|
if syntaxcheck:
|
2019-12-09 22:31:46 +01:00
|
|
|
self.logger.warning('%s: bridge inherits mtu from its ports. There is no need to assign mtu on a bridge' %ifaceobj.name)
|
addons: address: propagate physical mtu to upper vlan devices
Ticket: CM-13221
Reviewed By: julien, nikhil
Testing Done: tested mtu propagation for vlan devices
This is a followup to commit
29de36f36053 ("addons: address: various fixes for mtu handling").
This fixes a pending issue with mtu readjustments on vlan
interfaces on top of physical interfaces.
eg: with the below config:
$ifquery -a
auto swp1.100
iface swp1.100
auto swp1
iface swp1
mtu 9000
/* at boot-up swp1 and swp1.100 mtu is set to 9000 */
$ifdown swp1 /* resets swp1 mtu to 1500. swp1.100 mtu is reset to 1500
implicitly by the kernel */
$ifup swp1 /* swp1 mtu is set to 1500. But swp1.100 mtu stays at 1500
*/
This problem is unique to physical interfaces and vlan devices on
physical interfaces. This is because, when logical interface is ifdown,
kernel deletes all its sub-interfaces. And on the way up (ifup),
ifupdown2 re-creates all these sub-interfaces for you....that
sequence re-adjusts the mtu. For physical
interfaces, since the sub-interfaces are not deleted,
ifupdown2 does not do anything...and mtu of the subinterface is left to
what it was. And this ends up being what was there initially when the
lower interface went down. And ifdown of the lower physical interface,
resets the physical mtu to default which is 1500. The sub-interface mtu
returns to 1500 while the lower physical interface remains down.
(another detail here: kernel vlan driver re-adjusts mtu of the vlan
sub-interface on its own when the lower device mtu becomes lower. But
does not re-adjust its mtu when the lower device mtu increases. This is
expected and correct behavior). We will have to work around it in
ifupdown2 to suit our needs.
two solutions:
a) when physical interface is brought up, ifupdown2 can go and
pro-actively adjust the upper sub-interface mtu
OR
b) when physical interface is brought down, do not reset the mtu on the
device to default
(b) is the easiest and costs less if we dont expect the mtu of a
physical device to go to default on ifdown.
(a) is doable too, but is additional cost to go over all upper
interfaces.
This patch fixes this problem with solution (a). But, makes sure
this does not add additional cost to the default ifreload -a path.
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
2016-11-28 13:24:31 -08:00
|
|
|
retval = False
|
|
|
|
else:
|
2016-11-07 10:48:24 -08:00
|
|
|
self.logger.info('%s: bridge inherits mtu from its ports. There is no need to assign mtu on a bridge' %ifaceobj.name)
|
addons: address: propagate physical mtu to upper vlan devices
Ticket: CM-13221
Reviewed By: julien, nikhil
Testing Done: tested mtu propagation for vlan devices
This is a followup to commit
29de36f36053 ("addons: address: various fixes for mtu handling").
This fixes a pending issue with mtu readjustments on vlan
interfaces on top of physical interfaces.
eg: with the below config:
$ifquery -a
auto swp1.100
iface swp1.100
auto swp1
iface swp1
mtu 9000
/* at boot-up swp1 and swp1.100 mtu is set to 9000 */
$ifdown swp1 /* resets swp1 mtu to 1500. swp1.100 mtu is reset to 1500
implicitly by the kernel */
$ifup swp1 /* swp1 mtu is set to 1500. But swp1.100 mtu stays at 1500
*/
This problem is unique to physical interfaces and vlan devices on
physical interfaces. This is because, when logical interface is ifdown,
kernel deletes all its sub-interfaces. And on the way up (ifup),
ifupdown2 re-creates all these sub-interfaces for you....that
sequence re-adjusts the mtu. For physical
interfaces, since the sub-interfaces are not deleted,
ifupdown2 does not do anything...and mtu of the subinterface is left to
what it was. And this ends up being what was there initially when the
lower interface went down. And ifdown of the lower physical interface,
resets the physical mtu to default which is 1500. The sub-interface mtu
returns to 1500 while the lower physical interface remains down.
(another detail here: kernel vlan driver re-adjusts mtu of the vlan
sub-interface on its own when the lower device mtu becomes lower. But
does not re-adjust its mtu when the lower device mtu increases. This is
expected and correct behavior). We will have to work around it in
ifupdown2 to suit our needs.
two solutions:
a) when physical interface is brought up, ifupdown2 can go and
pro-actively adjust the upper sub-interface mtu
OR
b) when physical interface is brought down, do not reset the mtu on the
device to default
(b) is the easiest and costs less if we dont expect the mtu of a
physical device to go to default on ifdown.
(a) is doable too, but is additional cost to go over all upper
interfaces.
This patch fixes this problem with solution (a). But, makes sure
this does not add additional cost to the default ifreload -a path.
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
2016-11-28 13:24:31 -08:00
|
|
|
elif ifaceobj_getfunc:
|
|
|
|
if ((ifaceobj.link_privflags & ifaceLinkPrivFlags.BOND_SLAVE) and
|
|
|
|
ifaceobj.upperifaces):
|
2016-11-07 10:48:24 -08:00
|
|
|
masterobj = ifaceobj_getfunc(ifaceobj.upperifaces[0])
|
|
|
|
if masterobj:
|
|
|
|
master_mtu = masterobj[0].get_attr_value_first('mtu')
|
2019-12-17 01:04:54 +01:00
|
|
|
if master_mtu and master_mtu != mtu_str:
|
|
|
|
log_msg = ("%s: bond slave mtu %s is different from bond master %s mtu %s. "
|
|
|
|
"There is no need to configure mtu on a bond slave." %
|
|
|
|
(ifaceobj.name, mtu_str, masterobj[0].name, master_mtu))
|
addons: address: propagate physical mtu to upper vlan devices
Ticket: CM-13221
Reviewed By: julien, nikhil
Testing Done: tested mtu propagation for vlan devices
This is a followup to commit
29de36f36053 ("addons: address: various fixes for mtu handling").
This fixes a pending issue with mtu readjustments on vlan
interfaces on top of physical interfaces.
eg: with the below config:
$ifquery -a
auto swp1.100
iface swp1.100
auto swp1
iface swp1
mtu 9000
/* at boot-up swp1 and swp1.100 mtu is set to 9000 */
$ifdown swp1 /* resets swp1 mtu to 1500. swp1.100 mtu is reset to 1500
implicitly by the kernel */
$ifup swp1 /* swp1 mtu is set to 1500. But swp1.100 mtu stays at 1500
*/
This problem is unique to physical interfaces and vlan devices on
physical interfaces. This is because, when logical interface is ifdown,
kernel deletes all its sub-interfaces. And on the way up (ifup),
ifupdown2 re-creates all these sub-interfaces for you....that
sequence re-adjusts the mtu. For physical
interfaces, since the sub-interfaces are not deleted,
ifupdown2 does not do anything...and mtu of the subinterface is left to
what it was. And this ends up being what was there initially when the
lower interface went down. And ifdown of the lower physical interface,
resets the physical mtu to default which is 1500. The sub-interface mtu
returns to 1500 while the lower physical interface remains down.
(another detail here: kernel vlan driver re-adjusts mtu of the vlan
sub-interface on its own when the lower device mtu becomes lower. But
does not re-adjust its mtu when the lower device mtu increases. This is
expected and correct behavior). We will have to work around it in
ifupdown2 to suit our needs.
two solutions:
a) when physical interface is brought up, ifupdown2 can go and
pro-actively adjust the upper sub-interface mtu
OR
b) when physical interface is brought down, do not reset the mtu on the
device to default
(b) is the easiest and costs less if we dont expect the mtu of a
physical device to go to default on ifdown.
(a) is doable too, but is additional cost to go over all upper
interfaces.
This patch fixes this problem with solution (a). But, makes sure
this does not add additional cost to the default ifreload -a path.
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
2016-11-28 13:24:31 -08:00
|
|
|
if syntaxcheck:
|
2019-12-09 22:31:46 +01:00
|
|
|
self.logger.warning(log_msg)
|
addons: address: propagate physical mtu to upper vlan devices
Ticket: CM-13221
Reviewed By: julien, nikhil
Testing Done: tested mtu propagation for vlan devices
This is a followup to commit
29de36f36053 ("addons: address: various fixes for mtu handling").
This fixes a pending issue with mtu readjustments on vlan
interfaces on top of physical interfaces.
eg: with the below config:
$ifquery -a
auto swp1.100
iface swp1.100
auto swp1
iface swp1
mtu 9000
/* at boot-up swp1 and swp1.100 mtu is set to 9000 */
$ifdown swp1 /* resets swp1 mtu to 1500. swp1.100 mtu is reset to 1500
implicitly by the kernel */
$ifup swp1 /* swp1 mtu is set to 1500. But swp1.100 mtu stays at 1500
*/
This problem is unique to physical interfaces and vlan devices on
physical interfaces. This is because, when logical interface is ifdown,
kernel deletes all its sub-interfaces. And on the way up (ifup),
ifupdown2 re-creates all these sub-interfaces for you....that
sequence re-adjusts the mtu. For physical
interfaces, since the sub-interfaces are not deleted,
ifupdown2 does not do anything...and mtu of the subinterface is left to
what it was. And this ends up being what was there initially when the
lower interface went down. And ifdown of the lower physical interface,
resets the physical mtu to default which is 1500. The sub-interface mtu
returns to 1500 while the lower physical interface remains down.
(another detail here: kernel vlan driver re-adjusts mtu of the vlan
sub-interface on its own when the lower device mtu becomes lower. But
does not re-adjust its mtu when the lower device mtu increases. This is
expected and correct behavior). We will have to work around it in
ifupdown2 to suit our needs.
two solutions:
a) when physical interface is brought up, ifupdown2 can go and
pro-actively adjust the upper sub-interface mtu
OR
b) when physical interface is brought down, do not reset the mtu on the
device to default
(b) is the easiest and costs less if we dont expect the mtu of a
physical device to go to default on ifdown.
(a) is doable too, but is additional cost to go over all upper
interfaces.
This patch fixes this problem with solution (a). But, makes sure
this does not add additional cost to the default ifreload -a path.
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
2016-11-28 13:24:31 -08:00
|
|
|
retval = False
|
|
|
|
else:
|
2019-12-17 01:04:54 +01:00
|
|
|
self.logger.info(log_msg)
|
addons: address: propagate physical mtu to upper vlan devices
Ticket: CM-13221
Reviewed By: julien, nikhil
Testing Done: tested mtu propagation for vlan devices
This is a followup to commit
29de36f36053 ("addons: address: various fixes for mtu handling").
This fixes a pending issue with mtu readjustments on vlan
interfaces on top of physical interfaces.
eg: with the below config:
$ifquery -a
auto swp1.100
iface swp1.100
auto swp1
iface swp1
mtu 9000
/* at boot-up swp1 and swp1.100 mtu is set to 9000 */
$ifdown swp1 /* resets swp1 mtu to 1500. swp1.100 mtu is reset to 1500
implicitly by the kernel */
$ifup swp1 /* swp1 mtu is set to 1500. But swp1.100 mtu stays at 1500
*/
This problem is unique to physical interfaces and vlan devices on
physical interfaces. This is because, when logical interface is ifdown,
kernel deletes all its sub-interfaces. And on the way up (ifup),
ifupdown2 re-creates all these sub-interfaces for you....that
sequence re-adjusts the mtu. For physical
interfaces, since the sub-interfaces are not deleted,
ifupdown2 does not do anything...and mtu of the subinterface is left to
what it was. And this ends up being what was there initially when the
lower interface went down. And ifdown of the lower physical interface,
resets the physical mtu to default which is 1500. The sub-interface mtu
returns to 1500 while the lower physical interface remains down.
(another detail here: kernel vlan driver re-adjusts mtu of the vlan
sub-interface on its own when the lower device mtu becomes lower. But
does not re-adjust its mtu when the lower device mtu increases. This is
expected and correct behavior). We will have to work around it in
ifupdown2 to suit our needs.
two solutions:
a) when physical interface is brought up, ifupdown2 can go and
pro-actively adjust the upper sub-interface mtu
OR
b) when physical interface is brought down, do not reset the mtu on the
device to default
(b) is the easiest and costs less if we dont expect the mtu of a
physical device to go to default on ifdown.
(a) is doable too, but is additional cost to go over all upper
interfaces.
This patch fixes this problem with solution (a). But, makes sure
this does not add additional cost to the default ifreload -a path.
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
2016-11-28 13:24:31 -08:00
|
|
|
elif ((ifaceobj.link_kind & ifaceLinkKind.VLAN) and
|
|
|
|
ifaceobj.lowerifaces):
|
|
|
|
lowerobj = ifaceobj_getfunc(ifaceobj.lowerifaces[0])
|
|
|
|
if lowerobj:
|
|
|
|
if syntaxcheck:
|
2019-12-17 01:04:54 +01:00
|
|
|
lowerdev_mtu = int(lowerobj[0].get_attr_value_first('mtu') or 0)
|
addons: address: propagate physical mtu to upper vlan devices
Ticket: CM-13221
Reviewed By: julien, nikhil
Testing Done: tested mtu propagation for vlan devices
This is a followup to commit
29de36f36053 ("addons: address: various fixes for mtu handling").
This fixes a pending issue with mtu readjustments on vlan
interfaces on top of physical interfaces.
eg: with the below config:
$ifquery -a
auto swp1.100
iface swp1.100
auto swp1
iface swp1
mtu 9000
/* at boot-up swp1 and swp1.100 mtu is set to 9000 */
$ifdown swp1 /* resets swp1 mtu to 1500. swp1.100 mtu is reset to 1500
implicitly by the kernel */
$ifup swp1 /* swp1 mtu is set to 1500. But swp1.100 mtu stays at 1500
*/
This problem is unique to physical interfaces and vlan devices on
physical interfaces. This is because, when logical interface is ifdown,
kernel deletes all its sub-interfaces. And on the way up (ifup),
ifupdown2 re-creates all these sub-interfaces for you....that
sequence re-adjusts the mtu. For physical
interfaces, since the sub-interfaces are not deleted,
ifupdown2 does not do anything...and mtu of the subinterface is left to
what it was. And this ends up being what was there initially when the
lower interface went down. And ifdown of the lower physical interface,
resets the physical mtu to default which is 1500. The sub-interface mtu
returns to 1500 while the lower physical interface remains down.
(another detail here: kernel vlan driver re-adjusts mtu of the vlan
sub-interface on its own when the lower device mtu becomes lower. But
does not re-adjust its mtu when the lower device mtu increases. This is
expected and correct behavior). We will have to work around it in
ifupdown2 to suit our needs.
two solutions:
a) when physical interface is brought up, ifupdown2 can go and
pro-actively adjust the upper sub-interface mtu
OR
b) when physical interface is brought down, do not reset the mtu on the
device to default
(b) is the easiest and costs less if we dont expect the mtu of a
physical device to go to default on ifdown.
(a) is doable too, but is additional cost to go over all upper
interfaces.
This patch fixes this problem with solution (a). But, makes sure
this does not add additional cost to the default ifreload -a path.
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
2016-11-28 13:24:31 -08:00
|
|
|
else:
|
2019-12-17 01:04:54 +01:00
|
|
|
lowerdev_mtu = self.cache.get_link_mtu(lowerobj[0].name) # return type: int
|
|
|
|
if lowerdev_mtu and mtu_int > lowerdev_mtu:
|
2019-12-09 22:31:46 +01:00
|
|
|
self.logger.warning('%s: vlan dev mtu %s is greater than lower realdev %s mtu %s'
|
2019-12-17 01:04:54 +01:00
|
|
|
%(ifaceobj.name, mtu_str, lowerobj[0].name, lowerdev_mtu))
|
addons: address: propagate physical mtu to upper vlan devices
Ticket: CM-13221
Reviewed By: julien, nikhil
Testing Done: tested mtu propagation for vlan devices
This is a followup to commit
29de36f36053 ("addons: address: various fixes for mtu handling").
This fixes a pending issue with mtu readjustments on vlan
interfaces on top of physical interfaces.
eg: with the below config:
$ifquery -a
auto swp1.100
iface swp1.100
auto swp1
iface swp1
mtu 9000
/* at boot-up swp1 and swp1.100 mtu is set to 9000 */
$ifdown swp1 /* resets swp1 mtu to 1500. swp1.100 mtu is reset to 1500
implicitly by the kernel */
$ifup swp1 /* swp1 mtu is set to 1500. But swp1.100 mtu stays at 1500
*/
This problem is unique to physical interfaces and vlan devices on
physical interfaces. This is because, when logical interface is ifdown,
kernel deletes all its sub-interfaces. And on the way up (ifup),
ifupdown2 re-creates all these sub-interfaces for you....that
sequence re-adjusts the mtu. For physical
interfaces, since the sub-interfaces are not deleted,
ifupdown2 does not do anything...and mtu of the subinterface is left to
what it was. And this ends up being what was there initially when the
lower interface went down. And ifdown of the lower physical interface,
resets the physical mtu to default which is 1500. The sub-interface mtu
returns to 1500 while the lower physical interface remains down.
(another detail here: kernel vlan driver re-adjusts mtu of the vlan
sub-interface on its own when the lower device mtu becomes lower. But
does not re-adjust its mtu when the lower device mtu increases. This is
expected and correct behavior). We will have to work around it in
ifupdown2 to suit our needs.
two solutions:
a) when physical interface is brought up, ifupdown2 can go and
pro-actively adjust the upper sub-interface mtu
OR
b) when physical interface is brought down, do not reset the mtu on the
device to default
(b) is the easiest and costs less if we dont expect the mtu of a
physical device to go to default on ifdown.
(a) is doable too, but is additional cost to go over all upper
interfaces.
This patch fixes this problem with solution (a). But, makes sure
this does not add additional cost to the default ifreload -a path.
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
2016-11-28 13:24:31 -08:00
|
|
|
retval = False
|
|
|
|
elif (not lowerobj[0].link_kind and
|
|
|
|
not (lowerobj[0].link_privflags & ifaceLinkPrivFlags.LOOPBACK) and
|
2019-12-17 01:04:54 +01:00
|
|
|
not lowerdev_mtu and self.default_mtu and (mtu_int > self.default_mtu_int)):
|
addons: address: propagate physical mtu to upper vlan devices
Ticket: CM-13221
Reviewed By: julien, nikhil
Testing Done: tested mtu propagation for vlan devices
This is a followup to commit
29de36f36053 ("addons: address: various fixes for mtu handling").
This fixes a pending issue with mtu readjustments on vlan
interfaces on top of physical interfaces.
eg: with the below config:
$ifquery -a
auto swp1.100
iface swp1.100
auto swp1
iface swp1
mtu 9000
/* at boot-up swp1 and swp1.100 mtu is set to 9000 */
$ifdown swp1 /* resets swp1 mtu to 1500. swp1.100 mtu is reset to 1500
implicitly by the kernel */
$ifup swp1 /* swp1 mtu is set to 1500. But swp1.100 mtu stays at 1500
*/
This problem is unique to physical interfaces and vlan devices on
physical interfaces. This is because, when logical interface is ifdown,
kernel deletes all its sub-interfaces. And on the way up (ifup),
ifupdown2 re-creates all these sub-interfaces for you....that
sequence re-adjusts the mtu. For physical
interfaces, since the sub-interfaces are not deleted,
ifupdown2 does not do anything...and mtu of the subinterface is left to
what it was. And this ends up being what was there initially when the
lower interface went down. And ifdown of the lower physical interface,
resets the physical mtu to default which is 1500. The sub-interface mtu
returns to 1500 while the lower physical interface remains down.
(another detail here: kernel vlan driver re-adjusts mtu of the vlan
sub-interface on its own when the lower device mtu becomes lower. But
does not re-adjust its mtu when the lower device mtu increases. This is
expected and correct behavior). We will have to work around it in
ifupdown2 to suit our needs.
two solutions:
a) when physical interface is brought up, ifupdown2 can go and
pro-actively adjust the upper sub-interface mtu
OR
b) when physical interface is brought down, do not reset the mtu on the
device to default
(b) is the easiest and costs less if we dont expect the mtu of a
physical device to go to default on ifdown.
(a) is doable too, but is additional cost to go over all upper
interfaces.
This patch fixes this problem with solution (a). But, makes sure
this does not add additional cost to the default ifreload -a path.
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
2016-11-28 13:24:31 -08:00
|
|
|
# only check default mtu on lower device which is a physical interface
|
2019-12-09 22:31:46 +01:00
|
|
|
self.logger.warning('%s: vlan dev mtu %s is greater than lower realdev %s mtu %s'
|
2019-12-17 01:04:54 +01:00
|
|
|
%(ifaceobj.name, mtu_str, lowerobj[0].name, self.default_mtu))
|
addons: address: propagate physical mtu to upper vlan devices
Ticket: CM-13221
Reviewed By: julien, nikhil
Testing Done: tested mtu propagation for vlan devices
This is a followup to commit
29de36f36053 ("addons: address: various fixes for mtu handling").
This fixes a pending issue with mtu readjustments on vlan
interfaces on top of physical interfaces.
eg: with the below config:
$ifquery -a
auto swp1.100
iface swp1.100
auto swp1
iface swp1
mtu 9000
/* at boot-up swp1 and swp1.100 mtu is set to 9000 */
$ifdown swp1 /* resets swp1 mtu to 1500. swp1.100 mtu is reset to 1500
implicitly by the kernel */
$ifup swp1 /* swp1 mtu is set to 1500. But swp1.100 mtu stays at 1500
*/
This problem is unique to physical interfaces and vlan devices on
physical interfaces. This is because, when logical interface is ifdown,
kernel deletes all its sub-interfaces. And on the way up (ifup),
ifupdown2 re-creates all these sub-interfaces for you....that
sequence re-adjusts the mtu. For physical
interfaces, since the sub-interfaces are not deleted,
ifupdown2 does not do anything...and mtu of the subinterface is left to
what it was. And this ends up being what was there initially when the
lower interface went down. And ifdown of the lower physical interface,
resets the physical mtu to default which is 1500. The sub-interface mtu
returns to 1500 while the lower physical interface remains down.
(another detail here: kernel vlan driver re-adjusts mtu of the vlan
sub-interface on its own when the lower device mtu becomes lower. But
does not re-adjust its mtu when the lower device mtu increases. This is
expected and correct behavior). We will have to work around it in
ifupdown2 to suit our needs.
two solutions:
a) when physical interface is brought up, ifupdown2 can go and
pro-actively adjust the upper sub-interface mtu
OR
b) when physical interface is brought down, do not reset the mtu on the
device to default
(b) is the easiest and costs less if we dont expect the mtu of a
physical device to go to default on ifdown.
(a) is doable too, but is additional cost to go over all upper
interfaces.
This patch fixes this problem with solution (a). But, makes sure
this does not add additional cost to the default ifreload -a path.
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
2016-11-28 13:24:31 -08:00
|
|
|
retval = False
|
2019-12-17 01:04:54 +01:00
|
|
|
if self.max_mtu and mtu_int > self.max_mtu:
|
2019-12-09 22:31:46 +01:00
|
|
|
self.logger.warning('%s: specified mtu %s is greater than max mtu %s'
|
2019-12-17 01:04:54 +01:00
|
|
|
%(ifaceobj.name, mtu_str, self.max_mtu))
|
addons: address: propagate physical mtu to upper vlan devices
Ticket: CM-13221
Reviewed By: julien, nikhil
Testing Done: tested mtu propagation for vlan devices
This is a followup to commit
29de36f36053 ("addons: address: various fixes for mtu handling").
This fixes a pending issue with mtu readjustments on vlan
interfaces on top of physical interfaces.
eg: with the below config:
$ifquery -a
auto swp1.100
iface swp1.100
auto swp1
iface swp1
mtu 9000
/* at boot-up swp1 and swp1.100 mtu is set to 9000 */
$ifdown swp1 /* resets swp1 mtu to 1500. swp1.100 mtu is reset to 1500
implicitly by the kernel */
$ifup swp1 /* swp1 mtu is set to 1500. But swp1.100 mtu stays at 1500
*/
This problem is unique to physical interfaces and vlan devices on
physical interfaces. This is because, when logical interface is ifdown,
kernel deletes all its sub-interfaces. And on the way up (ifup),
ifupdown2 re-creates all these sub-interfaces for you....that
sequence re-adjusts the mtu. For physical
interfaces, since the sub-interfaces are not deleted,
ifupdown2 does not do anything...and mtu of the subinterface is left to
what it was. And this ends up being what was there initially when the
lower interface went down. And ifdown of the lower physical interface,
resets the physical mtu to default which is 1500. The sub-interface mtu
returns to 1500 while the lower physical interface remains down.
(another detail here: kernel vlan driver re-adjusts mtu of the vlan
sub-interface on its own when the lower device mtu becomes lower. But
does not re-adjust its mtu when the lower device mtu increases. This is
expected and correct behavior). We will have to work around it in
ifupdown2 to suit our needs.
two solutions:
a) when physical interface is brought up, ifupdown2 can go and
pro-actively adjust the upper sub-interface mtu
OR
b) when physical interface is brought down, do not reset the mtu on the
device to default
(b) is the easiest and costs less if we dont expect the mtu of a
physical device to go to default on ifdown.
(a) is doable too, but is additional cost to go over all upper
interfaces.
This patch fixes this problem with solution (a). But, makes sure
this does not add additional cost to the default ifreload -a path.
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
2016-11-28 13:24:31 -08:00
|
|
|
retval = False
|
|
|
|
return retval
|
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
def _propagate_mtu_to_upper_devs(self, ifaceobj, mtu_str, mtu_int, ifaceobj_getfunc):
|
addons: address: propagate physical mtu to upper vlan devices
Ticket: CM-13221
Reviewed By: julien, nikhil
Testing Done: tested mtu propagation for vlan devices
This is a followup to commit
29de36f36053 ("addons: address: various fixes for mtu handling").
This fixes a pending issue with mtu readjustments on vlan
interfaces on top of physical interfaces.
eg: with the below config:
$ifquery -a
auto swp1.100
iface swp1.100
auto swp1
iface swp1
mtu 9000
/* at boot-up swp1 and swp1.100 mtu is set to 9000 */
$ifdown swp1 /* resets swp1 mtu to 1500. swp1.100 mtu is reset to 1500
implicitly by the kernel */
$ifup swp1 /* swp1 mtu is set to 1500. But swp1.100 mtu stays at 1500
*/
This problem is unique to physical interfaces and vlan devices on
physical interfaces. This is because, when logical interface is ifdown,
kernel deletes all its sub-interfaces. And on the way up (ifup),
ifupdown2 re-creates all these sub-interfaces for you....that
sequence re-adjusts the mtu. For physical
interfaces, since the sub-interfaces are not deleted,
ifupdown2 does not do anything...and mtu of the subinterface is left to
what it was. And this ends up being what was there initially when the
lower interface went down. And ifdown of the lower physical interface,
resets the physical mtu to default which is 1500. The sub-interface mtu
returns to 1500 while the lower physical interface remains down.
(another detail here: kernel vlan driver re-adjusts mtu of the vlan
sub-interface on its own when the lower device mtu becomes lower. But
does not re-adjust its mtu when the lower device mtu increases. This is
expected and correct behavior). We will have to work around it in
ifupdown2 to suit our needs.
two solutions:
a) when physical interface is brought up, ifupdown2 can go and
pro-actively adjust the upper sub-interface mtu
OR
b) when physical interface is brought down, do not reset the mtu on the
device to default
(b) is the easiest and costs less if we dont expect the mtu of a
physical device to go to default on ifdown.
(a) is doable too, but is additional cost to go over all upper
interfaces.
This patch fixes this problem with solution (a). But, makes sure
this does not add additional cost to the default ifreload -a path.
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
2016-11-28 13:24:31 -08:00
|
|
|
if (not ifaceobj.upperifaces or
|
|
|
|
(ifaceobj.link_privflags & ifaceLinkPrivFlags.BOND_SLAVE) or
|
|
|
|
(ifaceobj.link_privflags & ifaceLinkPrivFlags.VRF_SLAVE) or
|
|
|
|
(ifaceobj.link_privflags & ifaceLinkPrivFlags.BRIDGE_PORT)):
|
|
|
|
return
|
|
|
|
for u in ifaceobj.upperifaces:
|
|
|
|
upperobjs = ifaceobj_getfunc(u)
|
|
|
|
if (not upperobjs or
|
|
|
|
not (upperobjs[0].link_kind & ifaceLinkKind.VLAN)):
|
|
|
|
continue
|
|
|
|
# only adjust mtu for vlan devices on ifaceobj
|
|
|
|
umtu = upperobjs[0].get_attr_value_first('mtu')
|
|
|
|
if not umtu:
|
2019-12-17 01:04:54 +01:00
|
|
|
running_mtu = self.cache.get_link_mtu(upperobjs[0].name)
|
|
|
|
if not running_mtu or running_mtu != mtu_int:
|
|
|
|
self.sysfs.link_set_mtu(u, mtu_str=mtu_str, mtu_int=mtu_int)
|
addons: address: propagate physical mtu to upper vlan devices
Ticket: CM-13221
Reviewed By: julien, nikhil
Testing Done: tested mtu propagation for vlan devices
This is a followup to commit
29de36f36053 ("addons: address: various fixes for mtu handling").
This fixes a pending issue with mtu readjustments on vlan
interfaces on top of physical interfaces.
eg: with the below config:
$ifquery -a
auto swp1.100
iface swp1.100
auto swp1
iface swp1
mtu 9000
/* at boot-up swp1 and swp1.100 mtu is set to 9000 */
$ifdown swp1 /* resets swp1 mtu to 1500. swp1.100 mtu is reset to 1500
implicitly by the kernel */
$ifup swp1 /* swp1 mtu is set to 1500. But swp1.100 mtu stays at 1500
*/
This problem is unique to physical interfaces and vlan devices on
physical interfaces. This is because, when logical interface is ifdown,
kernel deletes all its sub-interfaces. And on the way up (ifup),
ifupdown2 re-creates all these sub-interfaces for you....that
sequence re-adjusts the mtu. For physical
interfaces, since the sub-interfaces are not deleted,
ifupdown2 does not do anything...and mtu of the subinterface is left to
what it was. And this ends up being what was there initially when the
lower interface went down. And ifdown of the lower physical interface,
resets the physical mtu to default which is 1500. The sub-interface mtu
returns to 1500 while the lower physical interface remains down.
(another detail here: kernel vlan driver re-adjusts mtu of the vlan
sub-interface on its own when the lower device mtu becomes lower. But
does not re-adjust its mtu when the lower device mtu increases. This is
expected and correct behavior). We will have to work around it in
ifupdown2 to suit our needs.
two solutions:
a) when physical interface is brought up, ifupdown2 can go and
pro-actively adjust the upper sub-interface mtu
OR
b) when physical interface is brought down, do not reset the mtu on the
device to default
(b) is the easiest and costs less if we dont expect the mtu of a
physical device to go to default on ifdown.
(a) is doable too, but is additional cost to go over all upper
interfaces.
This patch fixes this problem with solution (a). But, makes sure
this does not add additional cost to the default ifreload -a path.
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
2016-11-28 13:24:31 -08:00
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
def _process_mtu_config_mtu_valid(self, ifaceobj, ifaceobj_getfunc, mtu_str, mtu_int):
|
|
|
|
if not self._check_mtu_config(ifaceobj, mtu_str, mtu_int, ifaceobj_getfunc):
|
|
|
|
return
|
|
|
|
|
|
|
|
if mtu_int != self.cache.get_link_mtu(ifaceobj.name):
|
|
|
|
self.sysfs.link_set_mtu(ifaceobj.name, mtu_str=mtu_str, mtu_int=mtu_int)
|
|
|
|
|
|
|
|
if (not ifupdownflags.flags.ALL and
|
addons: address: propagate physical mtu to upper vlan devices
Ticket: CM-13221
Reviewed By: julien, nikhil
Testing Done: tested mtu propagation for vlan devices
This is a followup to commit
29de36f36053 ("addons: address: various fixes for mtu handling").
This fixes a pending issue with mtu readjustments on vlan
interfaces on top of physical interfaces.
eg: with the below config:
$ifquery -a
auto swp1.100
iface swp1.100
auto swp1
iface swp1
mtu 9000
/* at boot-up swp1 and swp1.100 mtu is set to 9000 */
$ifdown swp1 /* resets swp1 mtu to 1500. swp1.100 mtu is reset to 1500
implicitly by the kernel */
$ifup swp1 /* swp1 mtu is set to 1500. But swp1.100 mtu stays at 1500
*/
This problem is unique to physical interfaces and vlan devices on
physical interfaces. This is because, when logical interface is ifdown,
kernel deletes all its sub-interfaces. And on the way up (ifup),
ifupdown2 re-creates all these sub-interfaces for you....that
sequence re-adjusts the mtu. For physical
interfaces, since the sub-interfaces are not deleted,
ifupdown2 does not do anything...and mtu of the subinterface is left to
what it was. And this ends up being what was there initially when the
lower interface went down. And ifdown of the lower physical interface,
resets the physical mtu to default which is 1500. The sub-interface mtu
returns to 1500 while the lower physical interface remains down.
(another detail here: kernel vlan driver re-adjusts mtu of the vlan
sub-interface on its own when the lower device mtu becomes lower. But
does not re-adjust its mtu when the lower device mtu increases. This is
expected and correct behavior). We will have to work around it in
ifupdown2 to suit our needs.
two solutions:
a) when physical interface is brought up, ifupdown2 can go and
pro-actively adjust the upper sub-interface mtu
OR
b) when physical interface is brought down, do not reset the mtu on the
device to default
(b) is the easiest and costs less if we dont expect the mtu of a
physical device to go to default on ifdown.
(a) is doable too, but is additional cost to go over all upper
interfaces.
This patch fixes this problem with solution (a). But, makes sure
this does not add additional cost to the default ifreload -a path.
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
2016-11-28 13:24:31 -08:00
|
|
|
not ifaceobj.link_kind and
|
2018-12-13 11:43:32 -08:00
|
|
|
ifupdownconfig.config.get('adjust_logical_dev_mtu', '1') != '0'):
|
2019-12-17 01:04:54 +01:00
|
|
|
# This is additional cost to us, so do it only when
|
|
|
|
# ifupdown2 is called on a particular interface and
|
|
|
|
# it is a physical interface
|
|
|
|
self._propagate_mtu_to_upper_devs(ifaceobj, mtu_str, mtu_int, ifaceobj_getfunc)
|
|
|
|
return
|
|
|
|
|
|
|
|
def _process_mtu_config_mtu_none(self, ifaceobj):
|
2020-02-24 14:26:31 +01:00
|
|
|
|
|
|
|
if (ifaceobj.link_privflags & ifaceLinkPrivFlags.MGMT_INTF):
|
|
|
|
return
|
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
cached_link_mtu = self.cache.get_link_mtu(ifaceobj.name)
|
2016-11-07 10:48:24 -08:00
|
|
|
|
|
|
|
if ifaceobj.link_kind:
|
2019-05-03 01:19:01 +08:00
|
|
|
# bonds, vxlan and custom devices (like dummy) need an explicit set of mtu.
|
2016-11-07 10:48:24 -08:00
|
|
|
# bridges don't need mtu set
|
2019-12-17 01:04:54 +01:00
|
|
|
if ifaceobj.link_kind & ifaceLinkKind.BOND \
|
|
|
|
or ifaceobj.link_kind & ifaceLinkKind.VXLAN \
|
2020-04-21 18:39:05 +02:00
|
|
|
or ifaceobj.link_kind & ifaceLinkKind.BRIDGE \
|
2019-12-17 01:04:54 +01:00
|
|
|
or ifaceobj.link_kind & ifaceLinkKind.OTHER:
|
|
|
|
if cached_link_mtu != self.default_mtu_int:
|
|
|
|
self.sysfs.link_set_mtu(ifaceobj.name, mtu_str=self.default_mtu, mtu_int=self.default_mtu_int)
|
2016-11-07 10:48:24 -08:00
|
|
|
return
|
2019-12-17 01:04:54 +01:00
|
|
|
|
2018-12-13 11:43:32 -08:00
|
|
|
if (ifupdownconfig.config.get('adjust_logical_dev_mtu', '1') != '0'
|
2016-11-07 10:48:24 -08:00
|
|
|
and ifaceobj.lowerifaces):
|
|
|
|
# set vlan interface mtu to lower device mtu
|
|
|
|
if (ifaceobj.link_kind & ifaceLinkKind.VLAN):
|
2018-12-13 11:43:32 -08:00
|
|
|
lower_iface = ifaceobj.lowerifaces[0]
|
2019-12-17 01:04:54 +01:00
|
|
|
lower_iface_mtu_int = self.cache.get_link_mtu(lower_iface)
|
2018-12-13 11:43:32 -08:00
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
if lower_iface_mtu_int != cached_link_mtu:
|
|
|
|
self.sysfs.link_set_mtu(ifaceobj.name, mtu_str=str(lower_iface_mtu_int), mtu_int=lower_iface_mtu_int)
|
2016-11-07 10:48:24 -08:00
|
|
|
|
|
|
|
elif (not (ifaceobj.name == 'lo') and not ifaceobj.link_kind and
|
|
|
|
not (ifaceobj.link_privflags & ifaceLinkPrivFlags.BOND_SLAVE) and
|
|
|
|
self.default_mtu):
|
|
|
|
# logical devices like bridges and vlan devices rely on mtu
|
|
|
|
# from their lower devices. ie mtu travels from
|
|
|
|
# lower devices to upper devices. For bonds mtu travels from
|
|
|
|
# upper to lower devices. running mtu depends on upper and
|
|
|
|
# lower device mtu. With all this implicit mtu
|
|
|
|
# config by the kernel in play, we try to be cautious here
|
|
|
|
# on which devices we want to reset mtu to default.
|
|
|
|
# essentially only physical interfaces which are not bond slaves
|
2019-12-17 01:04:54 +01:00
|
|
|
if cached_link_mtu != self.default_mtu_int:
|
|
|
|
self.sysfs.link_set_mtu(ifaceobj.name, mtu_str=self.default_mtu, mtu_int=self.default_mtu_int)
|
2016-11-07 10:48:24 -08:00
|
|
|
|
2018-12-13 11:43:32 -08:00
|
|
|
def _set_bridge_forwarding(self, ifaceobj):
|
|
|
|
""" set ip forwarding to 0 if bridge interface does not have a
|
|
|
|
ip nor svi """
|
2018-10-29 14:20:19 +01:00
|
|
|
ifname = ifaceobj.name
|
2019-12-17 01:04:54 +01:00
|
|
|
|
|
|
|
netconf_ipv4_forwarding = self.cache.get_netconf_forwarding(socket.AF_INET, ifname)
|
|
|
|
netconf_ipv6_forwarding = self.cache.get_netconf_forwarding(socket.AF_INET6, ifname)
|
|
|
|
|
2020-11-16 16:22:31 +01:00
|
|
|
if not ifaceobj.upperifaces and not ifaceobj.get_attr_value('address') and (ifaceobj.addr_method and "dhcp" not in ifaceobj.addr_method):
|
2019-12-17 01:04:54 +01:00
|
|
|
if netconf_ipv4_forwarding:
|
2018-10-29 14:20:19 +01:00
|
|
|
self.sysctl_write_forwarding_value_to_proc(ifname, "ipv4", 0)
|
2019-12-17 01:04:54 +01:00
|
|
|
if netconf_ipv6_forwarding:
|
2018-10-29 14:20:19 +01:00
|
|
|
self.sysctl_write_forwarding_value_to_proc(ifname, "ipv6", 0)
|
2018-12-13 11:43:32 -08:00
|
|
|
else:
|
2019-12-17 01:04:54 +01:00
|
|
|
if not netconf_ipv4_forwarding:
|
2018-10-29 14:20:19 +01:00
|
|
|
self.sysctl_write_forwarding_value_to_proc(ifname, "ipv4", 1)
|
2019-12-17 01:04:54 +01:00
|
|
|
if not netconf_ipv6_forwarding:
|
2018-10-29 14:20:19 +01:00
|
|
|
self.sysctl_write_forwarding_value_to_proc(ifname, "ipv6", 1)
|
|
|
|
|
|
|
|
def sysctl_write_forwarding_value_to_proc(self, ifname, family, value):
|
|
|
|
self.write_file("/proc/sys/net/%s/conf/%s/forwarding" % (family, ifname), "%s\n" % value)
|
2018-12-13 11:43:32 -08:00
|
|
|
|
|
|
|
def _sysctl_config(self, ifaceobj):
|
|
|
|
setting_default_value = False
|
|
|
|
mpls_enable = ifaceobj.get_attr_value_first('mpls-enable');
|
|
|
|
if not mpls_enable:
|
|
|
|
setting_default_value = True
|
|
|
|
mpls_enable = self.get_mod_subattr('mpls-enable', 'default')
|
|
|
|
mpls_enable = utils.boolean_support_binary(mpls_enable)
|
|
|
|
# File read has been used for better performance
|
|
|
|
# instead of using sysctl command
|
|
|
|
if ifupdownflags.flags.PERFMODE:
|
|
|
|
running_mpls_enable = '0'
|
|
|
|
else:
|
2019-12-17 01:04:54 +01:00
|
|
|
running_mpls_enable = str(self.cache.get_netconf_mpls_input(ifaceobj.name))
|
2018-12-13 11:43:32 -08:00
|
|
|
|
|
|
|
if mpls_enable != running_mpls_enable:
|
|
|
|
try:
|
|
|
|
self.sysctl_set('net.mpls.conf.%s.input'
|
|
|
|
%('/'.join(ifaceobj.name.split("."))),
|
|
|
|
mpls_enable)
|
|
|
|
except Exception as e:
|
|
|
|
if not setting_default_value:
|
|
|
|
ifaceobj.status = ifaceStatus.ERROR
|
|
|
|
self.logger.error('%s: %s' %(ifaceobj.name, str(e)))
|
|
|
|
|
|
|
|
if (ifaceobj.link_kind & ifaceLinkKind.BRIDGE):
|
|
|
|
self._set_bridge_forwarding(ifaceobj)
|
|
|
|
return
|
|
|
|
if not self.syntax_check_sysctls(ifaceobj):
|
|
|
|
return
|
|
|
|
ipforward = ifaceobj.get_attr_value_first('ip-forward')
|
|
|
|
ip6forward = ifaceobj.get_attr_value_first('ip6-forward')
|
|
|
|
if ifupdownflags.flags.PERFMODE:
|
|
|
|
if ipforward:
|
|
|
|
self.sysctl_set('net.ipv4.conf.%s.forwarding'
|
|
|
|
%('/'.join(ifaceobj.name.split("."))),
|
|
|
|
utils.boolean_support_binary(ipforward))
|
|
|
|
if ip6forward:
|
|
|
|
self.sysctl_set('net.ipv6.conf.%s.forwarding'
|
|
|
|
%('/'.join(ifaceobj.name.split("."))),
|
|
|
|
utils.boolean_support_binary(ip6forward))
|
|
|
|
return
|
|
|
|
bridge_port = ifaceobj.link_privflags & ifaceLinkPrivFlags.BRIDGE_PORT
|
|
|
|
if bridge_port:
|
|
|
|
if ipforward:
|
|
|
|
self.log_error('%s: \'ip-forward\' is not supported for '
|
|
|
|
'bridge port' %ifaceobj.name)
|
|
|
|
if ip6forward:
|
|
|
|
self.log_error('%s: \'ip6-forward\' is not supported for '
|
|
|
|
'bridge port' %ifaceobj.name)
|
|
|
|
return
|
2019-05-15 07:15:00 +02:00
|
|
|
setting_default_value = False
|
|
|
|
if not ipforward:
|
|
|
|
setting_default_value = True
|
2020-02-24 15:39:43 +01:00
|
|
|
ipforward = self.ipforward
|
|
|
|
if ipforward:
|
|
|
|
ipforward = int(utils.get_boolean_from_string(ipforward))
|
|
|
|
running_ipforward = self.cache.get_netconf_forwarding(socket.AF_INET, ifaceobj.name)
|
|
|
|
if ipforward != running_ipforward:
|
|
|
|
try:
|
|
|
|
self.sysctl_set('net.ipv4.conf.%s.forwarding'
|
|
|
|
%('/'.join(ifaceobj.name.split("."))),
|
|
|
|
ipforward)
|
|
|
|
except Exception as e:
|
|
|
|
if not setting_default_value:
|
|
|
|
ifaceobj.status = ifaceStatus.ERROR
|
|
|
|
self.logger.error('%s: %s' %(ifaceobj.name, str(e)))
|
2019-05-15 07:15:00 +02:00
|
|
|
|
|
|
|
setting_default_value = False
|
2020-02-24 15:39:43 +01:00
|
|
|
|
2019-05-15 07:15:00 +02:00
|
|
|
if not ip6forward:
|
|
|
|
setting_default_value = True
|
2020-02-24 15:39:43 +01:00
|
|
|
ip6forward = self.ip6forward
|
|
|
|
|
|
|
|
if ip6forward:
|
|
|
|
ip6forward = int(utils.get_boolean_from_string(ip6forward))
|
|
|
|
running_ip6forward = self.cache.get_netconf_forwarding(socket.AF_INET6, ifaceobj.name)
|
|
|
|
if ip6forward != running_ip6forward:
|
|
|
|
try:
|
|
|
|
self.sysctl_set('net.ipv6.conf.%s.forwarding'
|
|
|
|
%('/'.join(ifaceobj.name.split("."))),
|
|
|
|
ip6forward)
|
|
|
|
except Exception as e:
|
|
|
|
# There is chance of ipv6 being removed because of,
|
|
|
|
# for example, setting mtu < 1280
|
|
|
|
# In such cases, log error only if user has configured
|
|
|
|
# ip6-forward
|
|
|
|
if not setting_default_value:
|
|
|
|
ifaceobj.status = ifaceStatus.ERROR
|
|
|
|
self.logger.error('%s: %s' %(ifaceobj.name, str(e)))
|
2018-12-13 11:43:32 -08:00
|
|
|
|
|
|
|
def process_mtu(self, ifaceobj, ifaceobj_getfunc):
|
2020-06-05 06:56:59 +02:00
|
|
|
|
|
|
|
if ifaceobj.link_privflags & ifaceLinkPrivFlags.OPENVSWITCH:
|
|
|
|
return
|
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
mtu_str = ifaceobj.get_attr_value_first('mtu')
|
|
|
|
mtu_from_policy = False
|
2018-12-13 11:43:32 -08:00
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
if not mtu_str:
|
2020-02-24 14:26:31 +01:00
|
|
|
if (ifaceobj.link_privflags & ifaceLinkPrivFlags.MGMT_INTF):
|
|
|
|
mtu_str = self.default_mgmt_intf_mtu
|
|
|
|
if not mtu_str:
|
|
|
|
mtu_str = self.ifaces_defaults.get(ifaceobj.name, {}).get('mtu')
|
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
mtu_from_policy = True
|
2018-12-13 11:43:32 -08:00
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
if mtu_str:
|
|
|
|
try:
|
|
|
|
mtu_int = int(mtu_str)
|
|
|
|
except Exception as e:
|
|
|
|
if mtu_from_policy:
|
|
|
|
self.logger.warning("%s: invalid MTU value from policy file (iface_defaults): %s" % (ifaceobj.name, str(e)))
|
|
|
|
else:
|
|
|
|
self.logger.warning("%s: invalid MTU value: %s" % (ifaceobj.name, str(e)))
|
|
|
|
return
|
2018-12-13 11:43:32 -08:00
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
self._process_mtu_config_mtu_valid(ifaceobj, ifaceobj_getfunc, mtu_str, mtu_int)
|
|
|
|
else:
|
|
|
|
self._process_mtu_config_mtu_none(ifaceobj)
|
2018-12-13 11:43:32 -08:00
|
|
|
|
2018-06-18 18:57:20 +02:00
|
|
|
def up_ipv6_addrgen(self, ifaceobj):
|
2018-07-10 00:18:39 +02:00
|
|
|
user_configured_ipv6_addrgen = ifaceobj.get_attr_value_first('ipv6-addrgen')
|
|
|
|
|
2018-10-11 03:12:43 +02:00
|
|
|
if not user_configured_ipv6_addrgen and ifupdownflags.flags.PERFMODE:
|
|
|
|
# no need to go further during perfmode (boot)
|
|
|
|
return
|
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
if not user_configured_ipv6_addrgen and ifaceobj.addr_method in ["dhcp", "ppp"]:
|
2018-10-23 12:15:17 +02:00
|
|
|
return
|
|
|
|
|
2018-07-10 00:18:39 +02:00
|
|
|
if not user_configured_ipv6_addrgen:
|
2018-07-23 10:38:29 +02:00
|
|
|
# if user didn't configure ipv6-addrgen, should we reset to default?
|
|
|
|
user_configured_ipv6_addrgen = self.get_attr_default_value('ipv6-addrgen')
|
2018-07-10 00:18:39 +02:00
|
|
|
|
|
|
|
ipv6_addrgen_nl = {
|
|
|
|
'on': 0,
|
|
|
|
'yes': 0,
|
|
|
|
'0': 0,
|
|
|
|
'off': 1,
|
|
|
|
'no': 1,
|
|
|
|
'1': 1
|
|
|
|
}.get(user_configured_ipv6_addrgen.lower(), None)
|
|
|
|
|
|
|
|
if ipv6_addrgen_nl is not None:
|
2019-12-17 01:04:54 +01:00
|
|
|
self.iproute2.batch_start()
|
|
|
|
self.iproute2.link_set_ipv6_addrgen(ifaceobj.name, ipv6_addrgen_nl, link_created=True)
|
|
|
|
self.iproute2.batch_commit()
|
2018-07-10 00:18:39 +02:00
|
|
|
# link_create=False will flush the addr cache of that intf
|
|
|
|
else:
|
|
|
|
self.logger.warning('%s: invalid value "%s" for attribute ipv6-addrgen' % (ifaceobj.name, user_configured_ipv6_addrgen))
|
2018-06-18 18:57:20 +02:00
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
def _pre_up(self, ifaceobj, ifaceobj_getfunc=None):
|
|
|
|
if not self.cache.link_exists(ifaceobj.name):
|
2014-10-09 16:02:46 -07:00
|
|
|
return
|
addons: address: purge ifalias when no alias keyword is provided
Ticket: CM-13044
Reviewed By: Roopa, Nikhil G, Daniel W,
Testing Done:
For some reason we can't simply write into a file when we want to purge the
ifalias, we have to exec a command. I wasn't able to make it work in any
other way.
add an alias to an interface, ifreload, ip link show interface
modify it, ifreload, ip link show interface
remove it, ifreload, ip link show interface
Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
2016-12-27 17:03:19 +01:00
|
|
|
|
2018-12-13 11:43:32 -08:00
|
|
|
if not self.syntax_check_enable_l3_iface_forwardings(ifaceobj, ifaceobj_getfunc):
|
|
|
|
return
|
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
#
|
|
|
|
# alias
|
|
|
|
#
|
|
|
|
self.sysfs.link_set_alias(ifaceobj.name, ifaceobj.get_attr_value_first("alias"))
|
addons: address: purge ifalias when no alias keyword is provided
Ticket: CM-13044
Reviewed By: Roopa, Nikhil G, Daniel W,
Testing Done:
For some reason we can't simply write into a file when we want to purge the
ifalias, we have to exec a command. I wasn't able to make it work in any
other way.
add an alias to an interface, ifreload, ip link show interface
modify it, ifreload, ip link show interface
remove it, ifreload, ip link show interface
Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
2016-12-27 17:03:19 +01:00
|
|
|
|
2018-12-13 11:43:32 -08:00
|
|
|
self._sysctl_config(ifaceobj)
|
|
|
|
|
2014-11-18 16:52:00 -08:00
|
|
|
addr_method = ifaceobj.addr_method
|
2016-05-09 18:48:52 -07:00
|
|
|
force_reapply = False
|
2014-10-09 16:02:46 -07:00
|
|
|
try:
|
|
|
|
# release any stale dhcp addresses if present
|
2019-12-17 01:04:54 +01:00
|
|
|
if (addr_method not in ["dhcp", "ppp"] and not ifupdownflags.flags.PERFMODE and
|
2014-10-09 16:02:46 -07:00
|
|
|
not (ifaceobj.flags & iface.HAS_SIBLINGS)):
|
|
|
|
# if not running in perf mode and ifaceobj does not have
|
|
|
|
# any sibling iface objects, kill any stale dhclient
|
|
|
|
# processes
|
2014-11-17 16:23:42 -08:00
|
|
|
dhclientcmd = dhclient()
|
2016-05-09 13:50:56 -07:00
|
|
|
if dhclientcmd.is_running(ifaceobj.name):
|
2014-10-09 16:02:46 -07:00
|
|
|
# release any dhcp leases
|
|
|
|
dhclientcmd.release(ifaceobj.name)
|
2019-12-17 01:04:54 +01:00
|
|
|
self.cache.force_address_flush_family(ifaceobj.name, socket.AF_INET)
|
2016-05-09 18:48:52 -07:00
|
|
|
force_reapply = True
|
2016-05-09 13:50:56 -07:00
|
|
|
elif dhclientcmd.is_running6(ifaceobj.name):
|
2014-10-09 16:02:46 -07:00
|
|
|
dhclientcmd.release6(ifaceobj.name)
|
2019-12-17 01:04:54 +01:00
|
|
|
self.cache.force_address_flush_family(ifaceobj.name, socket.AF_INET6)
|
2016-05-09 18:48:52 -07:00
|
|
|
force_reapply = True
|
2020-06-24 01:12:24 +02:00
|
|
|
except Exception:
|
2014-10-09 16:02:46 -07:00
|
|
|
pass
|
2014-11-03 17:55:51 -08:00
|
|
|
|
2020-03-26 01:04:30 +01:00
|
|
|
self.process_mtu(ifaceobj, ifaceobj_getfunc)
|
2018-06-18 18:57:20 +02:00
|
|
|
self.up_ipv6_addrgen(ifaceobj)
|
|
|
|
|
2018-06-25 16:22:22 +02:00
|
|
|
if addr_method not in ["dhcp", "ppp"]:
|
2019-12-17 01:04:54 +01:00
|
|
|
self.process_addresses(ifaceobj, ifaceobj_getfunc, force_reapply)
|
2019-07-17 01:21:03 +02:00
|
|
|
else:
|
|
|
|
# remove old addresses added by ifupdown2
|
|
|
|
# (if intf was moved from static config to dhcp)
|
|
|
|
for old_ifaceobj in statemanager.statemanager_api.get_ifaceobjs(ifaceobj.name) or []:
|
|
|
|
for addr in old_ifaceobj.get_attr_value("address") or []:
|
2020-01-21 09:34:57 +01:00
|
|
|
self.netlink.addr_del(ifaceobj.name, ipnetwork.IPNetwork(addr))
|
2018-12-13 11:43:32 -08:00
|
|
|
|
2016-04-15 15:56:24 -07:00
|
|
|
|
2016-08-10 15:08:38 +02:00
|
|
|
try:
|
2019-12-17 01:04:54 +01:00
|
|
|
self.process_hwaddress(ifaceobj)
|
2015-09-17 11:26:56 -07:00
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
# Handle special things on a bridge
|
|
|
|
self._process_bridge(ifaceobj, True)
|
2019-12-17 16:55:49 +01:00
|
|
|
except Exception as e:
|
2019-12-17 01:04:54 +01:00
|
|
|
self.log_error('%s: %s' % (ifaceobj.name, str(e)), ifaceobj)
|
2019-06-11 22:51:07 +08:00
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
def _up(self, ifaceobj, ifaceobj_getfunc=None):
|
2019-06-11 22:51:07 +08:00
|
|
|
gateways = ifaceobj.get_attr_value('gateway')
|
|
|
|
if not gateways:
|
|
|
|
gateways = []
|
|
|
|
prev_gw = self._get_prev_gateway(ifaceobj, gateways)
|
|
|
|
self._add_delete_gateway(ifaceobj, gateways, prev_gw)
|
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
def process_hwaddress(self, ifaceobj):
|
|
|
|
hwaddress = self._get_hwaddress(ifaceobj)
|
2019-06-11 22:51:07 +08:00
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
if not hwaddress:
|
|
|
|
if ifaceobj.link_kind & ifaceLinkKind.VLAN:
|
|
|
|
# When hwaddress is removed from vlan config
|
|
|
|
# we should go back to system or bridge mac
|
|
|
|
for lower in ifaceobj.lowerifaces:
|
|
|
|
if self.cache.get_link_kind(lower) == "bridge":
|
|
|
|
hwaddress = self.cache.get_link_address(lower)
|
|
|
|
break
|
|
|
|
if not hwaddress:
|
|
|
|
return
|
|
|
|
else:
|
|
|
|
return
|
2016-08-24 14:20:45 -07:00
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
if not ifupdownflags.flags.PERFMODE: # system is clean
|
|
|
|
running_hwaddress = self.cache.get_link_address(ifaceobj.name)
|
|
|
|
else:
|
|
|
|
running_hwaddress = None
|
|
|
|
|
|
|
|
if utils.mac_str_to_int(hwaddress) != utils.mac_str_to_int(running_hwaddress):
|
|
|
|
slave_down = False
|
|
|
|
if ifaceobj.link_kind & ifaceLinkKind.BOND:
|
|
|
|
# if bond, down all the slaves
|
|
|
|
if ifaceobj.lowerifaces:
|
|
|
|
for l in ifaceobj.lowerifaces:
|
|
|
|
self.netlink.link_down(l)
|
|
|
|
slave_down = True
|
|
|
|
try:
|
|
|
|
self.netlink.link_set_address(ifaceobj.name, hwaddress)
|
|
|
|
finally:
|
|
|
|
if slave_down:
|
|
|
|
for l in ifaceobj.lowerifaces:
|
|
|
|
self.netlink.link_up(l)
|
2014-10-09 16:02:46 -07:00
|
|
|
|
2015-11-16 21:00:40 -08:00
|
|
|
def _down(self, ifaceobj, ifaceobj_getfunc=None):
|
2014-10-09 16:02:46 -07:00
|
|
|
try:
|
2019-12-17 01:04:54 +01:00
|
|
|
if not self.cache.link_exists(ifaceobj.name):
|
2014-10-09 16:02:46 -07:00
|
|
|
return
|
2014-11-18 16:52:00 -08:00
|
|
|
addr_method = ifaceobj.addr_method
|
2018-06-25 16:22:22 +02:00
|
|
|
if addr_method not in ["dhcp", "ppp"]:
|
2016-03-03 12:13:23 -08:00
|
|
|
if ifaceobj.get_attr_value_first('address-purge')=='no':
|
|
|
|
addrlist = ifaceobj.get_attr_value('address')
|
2019-12-17 01:04:54 +01:00
|
|
|
for addr in addrlist or []:
|
|
|
|
self.netlink.addr_del(ifaceobj.name, addr)
|
2018-12-13 11:43:32 -08:00
|
|
|
elif not ifaceobj.link_kind:
|
|
|
|
# for logical interfaces we don't need to remove the ip addresses
|
|
|
|
# kernel will do it for us on 'ip link del'
|
2019-12-17 01:04:54 +01:00
|
|
|
if ifaceobj_getfunc:
|
|
|
|
ifaceobj_list = ifaceobj_getfunc(ifaceobj.name) or [ifaceobj]
|
|
|
|
else:
|
|
|
|
ifaceobj_list = [ifaceobj]
|
|
|
|
|
2020-01-07 16:58:56 +01:00
|
|
|
for addr in self.cache.get_managed_ip_addresses(ifaceobj.name, ifaceobj_list):
|
2019-12-17 01:04:54 +01:00
|
|
|
self.netlink.addr_del(ifaceobj.name, addr)
|
|
|
|
|
2018-12-13 11:43:32 -08:00
|
|
|
gateways = ifaceobj.get_attr_value('gateway')
|
|
|
|
if gateways:
|
|
|
|
self._delete_gateway(ifaceobj, gateways,
|
|
|
|
ifaceobj.get_attr_value_first('vrf'),
|
|
|
|
ifaceobj.get_attr_value_first('metric'))
|
2019-12-17 01:04:54 +01:00
|
|
|
|
|
|
|
#
|
|
|
|
# mtu --
|
|
|
|
# If device is not a logical intf and has its MTU configured by
|
|
|
|
# ifupdown2. If this MTU is different from our default mtu,
|
|
|
|
# if so we need to reset it back to default.
|
|
|
|
if not ifaceobj.link_kind and self.default_mtu and ifaceobj.get_attr_value_first('mtu') and self.cache.get_link_mtu(ifaceobj.name) != self.default_mtu_int:
|
|
|
|
self.sysfs.link_set_mtu(ifaceobj.name, mtu_str=self.default_mtu, mtu_int=self.default_mtu_int)
|
|
|
|
|
|
|
|
#
|
|
|
|
# alias
|
|
|
|
# only reset alias on non-logical device
|
|
|
|
if not ifaceobj.link_kind:
|
|
|
|
alias = ifaceobj.get_attr_value_first("alias")
|
|
|
|
if alias:
|
|
|
|
self.sysfs.link_set_alias(ifaceobj.name, None) # None to reset alias.
|
|
|
|
|
2014-11-17 16:23:42 -08:00
|
|
|
# XXX hwaddress reset cannot happen because we dont know last
|
|
|
|
# address.
|
|
|
|
|
|
|
|
# Handle special things on a bridge
|
|
|
|
self._process_bridge(ifaceobj, False)
|
2019-12-17 16:55:49 +01:00
|
|
|
except Exception as e:
|
2014-11-15 23:31:42 -08:00
|
|
|
self.logger.debug('%s : %s' %(ifaceobj.name, str(e)))
|
|
|
|
pass
|
2014-10-09 16:02:46 -07:00
|
|
|
|
2014-11-03 17:55:51 -08:00
|
|
|
def _get_bridge_fdbs(self, bridgename, vlan):
|
|
|
|
fdbs = self._bridge_fdb_query_cache.get(bridgename)
|
|
|
|
if not fdbs:
|
2019-12-17 01:04:54 +01:00
|
|
|
fdbs = self.iproute2.bridge_fdb_show_dev(bridgename)
|
2014-11-03 17:55:51 -08:00
|
|
|
if not fdbs:
|
|
|
|
return
|
|
|
|
self._bridge_fdb_query_cache[bridgename] = fdbs
|
|
|
|
return fdbs.get(vlan)
|
|
|
|
|
|
|
|
def _check_addresses_in_bridge(self, ifaceobj, hwaddress):
|
|
|
|
""" If the device is a bridge, make sure the addresses
|
|
|
|
are in the bridge """
|
2018-12-13 11:43:32 -08:00
|
|
|
if ifaceobj.link_kind & ifaceLinkKind.VLAN:
|
|
|
|
bridgename = ifaceobj.lowerifaces[0]
|
|
|
|
vlan = self._get_vlan_id(ifaceobj)
|
2019-12-17 01:04:54 +01:00
|
|
|
if self.cache.bridge_is_vlan_aware(bridgename):
|
|
|
|
fdb_addrs = [utils.mac_str_to_int(fdb_addr) for fdb_addr in self._get_bridge_fdbs(bridgename, str(vlan))]
|
2019-06-11 22:51:07 +08:00
|
|
|
if not fdb_addrs:
|
2019-12-17 01:04:54 +01:00
|
|
|
return False
|
|
|
|
hwaddress_int = utils.mac_str_to_int(hwaddress)
|
2019-06-11 22:51:07 +08:00
|
|
|
if hwaddress_int not in fdb_addrs:
|
|
|
|
return False
|
2014-11-03 17:55:51 -08:00
|
|
|
return True
|
|
|
|
|
2018-12-13 11:43:32 -08:00
|
|
|
def _query_sysctl(self, ifaceobj, ifaceobjcurr):
|
|
|
|
bridge_port = ifaceobj.link_privflags & ifaceLinkPrivFlags.BRIDGE_PORT
|
|
|
|
ipforward = ifaceobj.get_attr_value_first('ip-forward')
|
|
|
|
if ipforward:
|
|
|
|
if bridge_port:
|
|
|
|
ifaceobjcurr.status = ifaceStatus.ERROR
|
|
|
|
ifaceobjcurr.status_str = ('\'ip-forward\' not supported ' +
|
|
|
|
'for bridge port')
|
|
|
|
ifaceobjcurr.update_config_with_status('ip-forward', 1, None)
|
|
|
|
else:
|
2019-12-17 01:04:54 +01:00
|
|
|
running_ipforward = self.cache.get_netconf_forwarding(socket.AF_INET, ifaceobj.name)
|
2018-07-16 13:03:47 +02:00
|
|
|
config_ipforward = utils.get_boolean_from_string(ipforward)
|
|
|
|
ifaceobjcurr.update_config_with_status(
|
|
|
|
'ip-forward',
|
|
|
|
'on' if running_ipforward else 'off',
|
|
|
|
running_ipforward != config_ipforward
|
|
|
|
)
|
2018-12-13 11:43:32 -08:00
|
|
|
|
|
|
|
ip6forward = ifaceobj.get_attr_value_first('ip6-forward')
|
|
|
|
if ip6forward:
|
|
|
|
if bridge_port:
|
|
|
|
ifaceobjcurr.status = ifaceStatus.ERROR
|
|
|
|
ifaceobjcurr.status_str = ('\'ip6-forward\' not supported ' +
|
|
|
|
'for bridge port')
|
|
|
|
ifaceobjcurr.update_config_with_status('ip6-forward', 1, None)
|
|
|
|
else:
|
2019-12-17 01:04:54 +01:00
|
|
|
running_ip6forward = self.cache.get_netconf_forwarding(socket.AF_INET6, ifaceobj.name)
|
2018-07-16 13:03:47 +02:00
|
|
|
config_ip6forward = utils.get_boolean_from_string(ip6forward)
|
|
|
|
ifaceobjcurr.update_config_with_status(
|
|
|
|
'ip6-forward',
|
|
|
|
'on' if running_ip6forward else 'off',
|
|
|
|
running_ip6forward != config_ip6forward
|
|
|
|
)
|
2018-12-13 11:43:32 -08:00
|
|
|
mpls_enable = ifaceobj.get_attr_value_first('mpls-enable');
|
|
|
|
if mpls_enable:
|
2019-12-17 01:04:54 +01:00
|
|
|
running_mpls_enable = utils.get_yesno_from_onezero(str(self.cache.get_netconf_mpls_input(ifaceobj.name)))
|
2018-12-13 11:43:32 -08:00
|
|
|
ifaceobjcurr.update_config_with_status('mpls-enable',
|
|
|
|
running_mpls_enable,
|
|
|
|
mpls_enable != running_mpls_enable)
|
|
|
|
return
|
|
|
|
|
2018-07-10 00:18:39 +02:00
|
|
|
def query_check_ipv6_addrgen(self, ifaceobj, ifaceobjcurr):
|
|
|
|
ipv6_addrgen = ifaceobj.get_attr_value_first('ipv6-addrgen')
|
|
|
|
|
|
|
|
if not ipv6_addrgen:
|
|
|
|
return
|
|
|
|
|
|
|
|
if ipv6_addrgen in utils._string_values:
|
|
|
|
ifaceobjcurr.update_config_with_status(
|
|
|
|
'ipv6-addrgen',
|
|
|
|
ipv6_addrgen,
|
2019-12-17 01:04:54 +01:00
|
|
|
utils.get_boolean_from_string(ipv6_addrgen) == self.cache.get_link_ipv6_addrgen_mode(ifaceobj.name)
|
2018-07-10 00:18:39 +02:00
|
|
|
)
|
|
|
|
else:
|
|
|
|
ifaceobjcurr.update_config_with_status('ipv6-addrgen', ipv6_addrgen, 1)
|
|
|
|
|
2015-11-16 21:00:40 -08:00
|
|
|
def _query_check(self, ifaceobj, ifaceobjcurr, ifaceobj_getfunc=None):
|
2019-12-17 01:04:54 +01:00
|
|
|
"""
|
|
|
|
TODO: Check broadcast address, scope, etc
|
|
|
|
"""
|
2014-10-09 16:02:46 -07:00
|
|
|
runningaddrsdict = None
|
2019-12-17 01:04:54 +01:00
|
|
|
if not self.cache.link_exists(ifaceobj.name):
|
2014-10-09 16:02:46 -07:00
|
|
|
self.logger.debug('iface %s not found' %ifaceobj.name)
|
|
|
|
return
|
2018-07-10 00:18:39 +02:00
|
|
|
|
|
|
|
self.query_check_ipv6_addrgen(ifaceobj, ifaceobjcurr)
|
|
|
|
|
2014-11-19 17:25:26 -08:00
|
|
|
addr_method = ifaceobj.addr_method
|
2014-10-09 16:02:46 -07:00
|
|
|
self.query_n_update_ifaceobjcurr_attr(ifaceobj, ifaceobjcurr,
|
2019-12-17 01:04:54 +01:00
|
|
|
'mtu', self.cache.get_link_mtu_str)
|
2016-03-15 15:41:04 +01:00
|
|
|
hwaddress = self._get_hwaddress(ifaceobj)
|
2014-11-03 17:55:51 -08:00
|
|
|
if hwaddress:
|
2019-12-17 01:04:54 +01:00
|
|
|
rhwaddress = self.cache.get_link_address(ifaceobj.name)
|
|
|
|
if not rhwaddress or utils.mac_str_to_int(rhwaddress) != utils.mac_str_to_int(hwaddress):
|
2014-11-03 17:55:51 -08:00
|
|
|
ifaceobjcurr.update_config_with_status('hwaddress', rhwaddress,
|
|
|
|
1)
|
|
|
|
elif not self._check_addresses_in_bridge(ifaceobj, hwaddress):
|
|
|
|
# XXX: hw address is not in bridge
|
|
|
|
ifaceobjcurr.update_config_with_status('hwaddress', rhwaddress,
|
|
|
|
1)
|
|
|
|
ifaceobjcurr.status_str = 'bridge fdb error'
|
|
|
|
else:
|
|
|
|
ifaceobjcurr.update_config_with_status('hwaddress', rhwaddress,
|
|
|
|
0)
|
2014-10-09 16:02:46 -07:00
|
|
|
self.query_n_update_ifaceobjcurr_attr(ifaceobj, ifaceobjcurr,
|
2019-12-17 01:04:54 +01:00
|
|
|
'alias', self.cache.get_link_alias)
|
2020-01-07 16:58:56 +01:00
|
|
|
|
2018-12-13 11:43:32 -08:00
|
|
|
self._query_sysctl(ifaceobj, ifaceobjcurr)
|
2020-01-07 16:58:56 +01:00
|
|
|
self._query_check_address(ifaceobj, ifaceobjcurr, ifaceobj_getfunc)
|
|
|
|
|
|
|
|
def _query_check_address(self, ifaceobj, ifaceobjcurr, ifaceobj_getfunc):
|
|
|
|
""" ifquery-check: attribute: "address" """
|
|
|
|
if ifaceobj.addr_method in ["dhcp", "ppp"]:
|
|
|
|
return
|
2019-12-17 01:04:54 +01:00
|
|
|
|
|
|
|
if ifaceobj_getfunc:
|
|
|
|
ifaceobj_list = ifaceobj_getfunc(ifaceobj.name)
|
|
|
|
else:
|
|
|
|
ifaceobj_list = [ifaceobj]
|
|
|
|
|
2020-01-07 16:58:56 +01:00
|
|
|
intf_running_addrs = self.cache.get_managed_ip_addresses(ifaceobj.name, ifaceobj_list)
|
|
|
|
user_config_addrs = self.cache.get_user_configured_addresses([ifaceobj])
|
2019-12-17 01:04:54 +01:00
|
|
|
|
|
|
|
try:
|
2020-01-07 16:58:56 +01:00
|
|
|
clagd_vxlan_anycast_ip = ipnetwork.IPNetwork(ifaceobj.get_attr_value_first("clagd-vxlan-anycast-ip"))
|
2019-12-17 01:04:54 +01:00
|
|
|
|
|
|
|
if clagd_vxlan_anycast_ip in intf_running_addrs:
|
|
|
|
user_config_addrs.append(clagd_vxlan_anycast_ip)
|
2020-06-24 01:12:24 +02:00
|
|
|
except Exception:
|
2019-12-17 01:04:54 +01:00
|
|
|
pass
|
2014-10-09 16:02:46 -07:00
|
|
|
|
|
|
|
# Set ifaceobjcurr method and family
|
|
|
|
ifaceobjcurr.addr_method = ifaceobj.addr_method
|
|
|
|
ifaceobjcurr.addr_family = ifaceobj.addr_family
|
2019-12-17 01:04:54 +01:00
|
|
|
|
|
|
|
if not intf_running_addrs and not user_config_addrs:
|
|
|
|
# The device doesn't have any ips configured and the
|
|
|
|
# the user didn't specify any ip in the configuration file
|
2014-10-09 16:02:46 -07:00
|
|
|
return
|
2019-12-17 01:04:54 +01:00
|
|
|
|
|
|
|
for address in user_config_addrs:
|
|
|
|
ifaceobjcurr.update_config_with_status('address', str(address), address not in intf_running_addrs)
|
|
|
|
try:
|
|
|
|
intf_running_addrs.remove(address)
|
2020-06-24 01:12:24 +02:00
|
|
|
except Exception:
|
2019-12-17 01:04:54 +01:00
|
|
|
pass
|
|
|
|
|
2020-01-07 16:58:56 +01:00
|
|
|
# if any ip address is left in 'intf_running_addrs' it means that they
|
|
|
|
# used to be configured by ifupdown2 but not anymore. The entry was
|
|
|
|
# removed from the configuration file but the IP is still configured on
|
|
|
|
# the device, so we need to mark them as FAIL (we will only mark them
|
|
|
|
# as failure on the first sibling).
|
2019-12-17 01:04:54 +01:00
|
|
|
if ifaceobj.flags & iface.HAS_SIBLINGS:
|
|
|
|
if not ifaceobj.flags & iface.YOUNGEST_SIBLING:
|
|
|
|
return
|
|
|
|
|
2020-01-07 16:58:56 +01:00
|
|
|
all_stanza_user_config_ip = self.cache.get_user_configured_addresses(ifaceobj_list)
|
2019-12-17 01:04:54 +01:00
|
|
|
|
|
|
|
for address in intf_running_addrs:
|
|
|
|
if address not in all_stanza_user_config_ip:
|
|
|
|
ifaceobjcurr.update_config_with_status('address', str(address), 1)
|
|
|
|
|
2018-07-10 00:18:39 +02:00
|
|
|
def query_running_ipv6_addrgen(self, ifaceobjrunning):
|
2019-12-17 01:04:54 +01:00
|
|
|
ipv6_addrgen = self.cache.get_link_ipv6_addrgen_mode(ifaceobjrunning.name)
|
2018-07-10 00:18:39 +02:00
|
|
|
|
|
|
|
if ipv6_addrgen:
|
|
|
|
ifaceobjrunning.update_config('ipv6-addrgen', 'off')
|
|
|
|
|
2015-11-16 21:00:40 -08:00
|
|
|
def _query_running(self, ifaceobjrunning, ifaceobj_getfunc=None):
|
2019-12-17 01:04:54 +01:00
|
|
|
if not self.cache.link_exists(ifaceobjrunning.name):
|
2014-10-09 16:02:46 -07:00
|
|
|
self.logger.debug('iface %s not found' %ifaceobjrunning.name)
|
|
|
|
return
|
2018-07-10 00:18:39 +02:00
|
|
|
|
|
|
|
self.query_running_ipv6_addrgen(ifaceobjrunning)
|
|
|
|
|
2014-10-09 16:02:46 -07:00
|
|
|
dhclientcmd = dhclient()
|
|
|
|
if (dhclientcmd.is_running(ifaceobjrunning.name) or
|
|
|
|
dhclientcmd.is_running6(ifaceobjrunning.name)):
|
|
|
|
# If dhcp is configured on the interface, we skip it
|
2016-04-15 10:16:53 +02:00
|
|
|
return
|
2019-12-17 01:04:54 +01:00
|
|
|
|
2020-01-07 16:58:56 +01:00
|
|
|
intf_running_addrs = self.cache.get_ip_addresses(ifaceobjrunning.name) or []
|
2019-12-17 01:04:54 +01:00
|
|
|
|
|
|
|
if self.cache.link_is_loopback(ifaceobjrunning.name):
|
|
|
|
for default_addr in self.default_loopback_addresses:
|
|
|
|
try:
|
|
|
|
intf_running_addrs.remove(default_addr)
|
2020-06-24 01:12:24 +02:00
|
|
|
except Exception:
|
2019-12-17 01:04:54 +01:00
|
|
|
pass
|
2016-11-15 18:33:07 +01:00
|
|
|
ifaceobjrunning.addr_family.append('inet')
|
2014-10-09 16:02:46 -07:00
|
|
|
ifaceobjrunning.addr_method = 'loopback'
|
2019-12-17 01:04:54 +01:00
|
|
|
|
|
|
|
for addr in intf_running_addrs:
|
2020-04-30 23:59:35 +02:00
|
|
|
ifaceobjrunning.update_config('address', str(addr))
|
2019-12-17 01:04:54 +01:00
|
|
|
|
|
|
|
mtu = self.cache.get_link_mtu_str(ifaceobjrunning.name)
|
2014-10-09 16:02:46 -07:00
|
|
|
if (mtu and
|
|
|
|
(ifaceobjrunning.name == 'lo' and mtu != '16436') or
|
|
|
|
(ifaceobjrunning.name != 'lo' and
|
|
|
|
mtu != self.get_mod_subattr('mtu', 'default'))):
|
|
|
|
ifaceobjrunning.update_config('mtu', mtu)
|
2019-12-17 01:04:54 +01:00
|
|
|
|
|
|
|
alias = self.cache.get_link_alias(ifaceobjrunning.name)
|
2016-04-15 10:16:53 +02:00
|
|
|
if alias:
|
2014-10-09 16:02:46 -07:00
|
|
|
ifaceobjrunning.update_config('alias', alias)
|
|
|
|
|
2019-12-17 01:04:54 +01:00
|
|
|
_run_ops = {
|
|
|
|
'pre-up': _pre_up,
|
|
|
|
'up': _up,
|
|
|
|
'down': _down,
|
|
|
|
'query-checkcurr': _query_check,
|
|
|
|
'query-running': _query_running
|
|
|
|
}
|
2014-10-09 16:02:46 -07:00
|
|
|
|
|
|
|
def get_ops(self):
|
|
|
|
""" returns list of ops supported by this module """
|
2019-12-17 16:55:49 +01:00
|
|
|
return list(self._run_ops.keys())
|
2014-10-09 16:02:46 -07:00
|
|
|
|
2016-04-20 03:02:26 -07:00
|
|
|
def run(self, ifaceobj, operation, query_ifaceobj=None, ifaceobj_getfunc=None):
|
2014-10-09 16:02:46 -07:00
|
|
|
""" run address configuration on the interface object passed as argument
|
|
|
|
|
|
|
|
Args:
|
|
|
|
**ifaceobj** (object): iface object
|
|
|
|
|
|
|
|
**operation** (str): any of 'up', 'down', 'query-checkcurr',
|
|
|
|
'query-running'
|
|
|
|
Kwargs:
|
|
|
|
query_ifaceobj (object): query check ifaceobject. This is only
|
|
|
|
valid when op is 'query-checkcurr'. It is an object same as
|
|
|
|
ifaceobj, but contains running attribute values and its config
|
|
|
|
status. The modules can use it to return queried running state
|
|
|
|
of interfaces. status is success if the running state is same
|
|
|
|
as user required state in ifaceobj. error otherwise.
|
|
|
|
"""
|
2014-11-03 17:55:51 -08:00
|
|
|
if ifaceobj.type == ifaceType.BRIDGE_VLAN:
|
|
|
|
return
|
2014-10-09 16:02:46 -07:00
|
|
|
op_handler = self._run_ops.get(operation)
|
|
|
|
if not op_handler:
|
|
|
|
return
|
|
|
|
if operation == 'query-checkcurr':
|
2015-11-16 21:00:40 -08:00
|
|
|
op_handler(self, ifaceobj, query_ifaceobj,
|
|
|
|
ifaceobj_getfunc=ifaceobj_getfunc)
|
2014-10-09 16:02:46 -07:00
|
|
|
else:
|
2015-11-16 21:00:40 -08:00
|
|
|
op_handler(self, ifaceobj,
|
|
|
|
ifaceobj_getfunc=ifaceobj_getfunc)
|