2014-10-09 16:02:46 -07:00
|
|
|
#!/usr/bin/python
|
|
|
|
#
|
|
|
|
# Copyright 2014 Cumulus Networks, Inc. All rights reserved.
|
|
|
|
# Author: Roopa Prabhu, roopa@cumulusnetworks.com
|
|
|
|
#
|
|
|
|
|
|
|
|
try:
|
2016-12-01 06:34:02 +01:00
|
|
|
import re
|
2014-10-09 16:02:46 -07:00
|
|
|
from ipaddr import IPNetwork
|
|
|
|
from sets import Set
|
|
|
|
from ifupdown.iface import *
|
ifupdown2: Add nowait attribute for dhcp addon
Ticket: None
Reviewed By: CCR-4058
Testing Done: ifup'd interface with both nowait=0 and nowait=1 and not specified
at all.
The Mellanox platform, as well as some others probably, has two management
interfaces: eth0 and eth1. The customer may plug a cable into either one of
these interfaces, and very rarely both of them. If only one cable is plugged in
and we don't know which one, then /etc/network/interfaces must be configured
by default to automatically bring up both interfaces using DHCP. But when an
interface does not have link, it stalls the boot process for 60 seconds while
dhclient times out.
This patch changes the default dhclient behavior to not wait for DHCP to
complete, by using the "-nw" option when calling dhclient. This means that
dhclient will immediately return and DHCP will complete in the background.
A module attribute has been added for the DHCP addon called "nowait", which
defaults to 1. If this attribute is set to 0, then dhclient will revert to its
previous behavior and delay up to a minute while DHCP completes. This attribute
can be specified in a policy file, e.g. /etc/network/ifupdown2/policy.d/dhcp.json,
with contents such as:
{
"dhcp" :
{
"nowait" : 0
}
}
2016-02-01 16:42:14 -08:00
|
|
|
import ifupdown.policymanager as policymanager
|
2014-10-09 16:02:46 -07:00
|
|
|
from ifupdownaddons.modulebase import moduleBase
|
|
|
|
from ifupdownaddons.dhclient import dhclient
|
|
|
|
from ifupdownaddons.iproute2 import iproute2
|
2016-04-14 14:45:47 -07:00
|
|
|
import ifupdown.ifupdownflags as ifupdownflags
|
2016-07-15 14:21:23 -07:00
|
|
|
from ifupdown.utils import utils
|
|
|
|
import time
|
|
|
|
from ifupdown.netlink import netlink
|
2014-10-09 16:02:46 -07:00
|
|
|
except ImportError, e:
|
|
|
|
raise ImportError (str(e) + "- required module not found")
|
|
|
|
|
|
|
|
class dhcp(moduleBase):
|
|
|
|
""" ifupdown2 addon module to configure dhcp on interface """
|
|
|
|
|
|
|
|
def __init__(self, *args, **kargs):
|
|
|
|
moduleBase.__init__(self, *args, **kargs)
|
|
|
|
self.dhclientcmd = dhclient(**kargs)
|
|
|
|
self.ipcmd = None
|
|
|
|
|
2016-11-22 17:06:16 +01:00
|
|
|
def syntax_check(self, ifaceobj, ifaceobj_getfunc):
|
|
|
|
return self.is_dhcp_allowed_on(ifaceobj, syntax_check=True)
|
|
|
|
|
|
|
|
def is_dhcp_allowed_on(self, ifaceobj, syntax_check):
|
|
|
|
if ifaceobj.addr_method and 'dhcp' in ifaceobj.addr_method:
|
|
|
|
return utils.is_addr_ip_allowed_on(ifaceobj, syntax_check=True)
|
|
|
|
return True
|
|
|
|
|
2014-10-09 16:02:46 -07:00
|
|
|
def _up(self, ifaceobj):
|
2015-06-30 13:47:08 -04:00
|
|
|
# if dhclient is already running do not stop and start it
|
2016-12-02 00:39:35 +01:00
|
|
|
dhclient4_running = self.dhclientcmd.is_running(ifaceobj.name)
|
|
|
|
dhclient6_running = self.dhclientcmd.is_running6(ifaceobj.name)
|
2016-12-02 07:15:09 +01:00
|
|
|
|
|
|
|
# today if we have an interface with both inet and inet6, if we
|
|
|
|
# remove the inet or inet6 or both then execute ifreload, we need
|
|
|
|
# to release/kill the appropriate dhclient(4/6) if they are running
|
|
|
|
self._down_stale_dhcp_config(ifaceobj, 'inet', dhclient4_running)
|
|
|
|
self._down_stale_dhcp_config(ifaceobj, 'inet6', dhclient6_running)
|
|
|
|
|
2014-10-09 16:02:46 -07:00
|
|
|
try:
|
2016-04-05 16:11:41 -07:00
|
|
|
dhclient_cmd_prefix = None
|
2016-02-03 16:38:18 -08:00
|
|
|
dhcp_wait = policymanager.policymanager_api.get_attr_default(
|
|
|
|
module_name=self.__class__.__name__, attr='dhcp-wait')
|
|
|
|
wait = not str(dhcp_wait).lower() == "no"
|
2016-04-05 16:11:41 -07:00
|
|
|
vrf = ifaceobj.get_attr_value_first('vrf')
|
2016-04-17 23:45:59 -07:00
|
|
|
if (vrf and self.vrf_exec_cmd_prefix and
|
|
|
|
self.ipcmd.link_exists(vrf)):
|
2016-04-05 16:11:41 -07:00
|
|
|
dhclient_cmd_prefix = '%s %s' %(self.vrf_exec_cmd_prefix, vrf)
|
|
|
|
|
2016-11-15 18:33:07 +01:00
|
|
|
if 'inet' in ifaceobj.addr_family:
|
2016-12-02 00:39:35 +01:00
|
|
|
if dhclient4_running:
|
|
|
|
self.logger.info('dhclient4 already running on %s. '
|
|
|
|
'Not restarting.' % ifaceobj.name)
|
|
|
|
else:
|
|
|
|
# First release any existing dhclient processes
|
2014-10-09 16:02:46 -07:00
|
|
|
try:
|
2016-12-02 00:39:35 +01:00
|
|
|
if not ifupdownflags.flags.PERFMODE:
|
|
|
|
self.dhclientcmd.stop(ifaceobj.name)
|
2014-10-09 16:02:46 -07:00
|
|
|
except:
|
|
|
|
pass
|
2016-12-02 00:39:35 +01:00
|
|
|
self.dhclientcmd.start(ifaceobj.name, wait=wait,
|
|
|
|
cmd_prefix=dhclient_cmd_prefix)
|
|
|
|
if 'inet6' in ifaceobj.addr_family:
|
|
|
|
if dhclient6_running:
|
|
|
|
self.logger.info('dhclient6 already running on %s. '
|
|
|
|
'Not restarting.' % ifaceobj.name)
|
|
|
|
else:
|
|
|
|
accept_ra = ifaceobj.get_attr_value_first('accept_ra')
|
|
|
|
if accept_ra:
|
|
|
|
# XXX: Validate value
|
|
|
|
self.sysctl_set('net.ipv6.conf.%s' %ifaceobj.name +
|
|
|
|
'.accept_ra', accept_ra)
|
|
|
|
autoconf = ifaceobj.get_attr_value_first('autoconf')
|
|
|
|
if autoconf:
|
|
|
|
# XXX: Validate value
|
|
|
|
self.sysctl_set('net.ipv6.conf.%s' %ifaceobj.name +
|
|
|
|
'.autoconf', autoconf)
|
|
|
|
try:
|
|
|
|
self.dhclientcmd.stop6(ifaceobj.name)
|
|
|
|
except:
|
|
|
|
pass
|
|
|
|
#add delay before starting IPv6 dhclient to
|
|
|
|
#make sure the configured interface/link is up.
|
2016-12-01 06:34:02 +01:00
|
|
|
time.sleep(2)
|
2016-12-02 00:39:35 +01:00
|
|
|
timeout = 10
|
|
|
|
while timeout:
|
|
|
|
timeout -= 2
|
|
|
|
addr_output = utils.exec_command('ip -6 addr show %s'
|
|
|
|
% ifaceobj.name)
|
|
|
|
r = re.search('inet6 .* scope link', addr_output)
|
|
|
|
if r:
|
|
|
|
self.dhclientcmd.start6(ifaceobj.name,
|
|
|
|
wait=wait,
|
|
|
|
cmd_prefix=dhclient_cmd_prefix)
|
|
|
|
return
|
|
|
|
time.sleep(2)
|
2016-12-01 06:34:02 +01:00
|
|
|
|
2014-10-09 16:02:46 -07:00
|
|
|
except Exception, e:
|
2016-05-15 13:28:10 -07:00
|
|
|
self.log_error(str(e), ifaceobj)
|
2014-10-09 16:02:46 -07:00
|
|
|
|
2016-12-02 07:15:09 +01:00
|
|
|
def _down_stale_dhcp_config(self, ifaceobj, family, dhclientX_running):
|
|
|
|
addr_family = ifaceobj.addr_family
|
|
|
|
try:
|
|
|
|
if not family in ifaceobj.addr_family and dhclientX_running:
|
|
|
|
ifaceobj.addr_family = [family]
|
|
|
|
self._dhcp_down(ifaceobj)
|
|
|
|
except:
|
|
|
|
pass
|
|
|
|
finally:
|
|
|
|
ifaceobj.addr_family = addr_family
|
|
|
|
|
|
|
|
def _dhcp_down(self, ifaceobj):
|
2016-04-05 16:11:41 -07:00
|
|
|
dhclient_cmd_prefix = None
|
|
|
|
vrf = ifaceobj.get_attr_value_first('vrf')
|
2016-04-17 23:45:59 -07:00
|
|
|
if (vrf and self.vrf_exec_cmd_prefix and
|
|
|
|
self.ipcmd.link_exists(vrf)):
|
2016-04-05 16:11:41 -07:00
|
|
|
dhclient_cmd_prefix = '%s %s' %(self.vrf_exec_cmd_prefix, vrf)
|
2016-11-15 18:33:07 +01:00
|
|
|
if 'inet6' in ifaceobj.addr_family:
|
2016-07-15 14:21:23 -07:00
|
|
|
self.dhclientcmd.release6(ifaceobj.name, dhclient_cmd_prefix)
|
2016-11-15 18:33:07 +01:00
|
|
|
if 'inet' in ifaceobj.addr_family:
|
2016-07-15 14:21:23 -07:00
|
|
|
self.dhclientcmd.release(ifaceobj.name, dhclient_cmd_prefix)
|
2016-12-02 07:15:09 +01:00
|
|
|
|
|
|
|
def _down(self, ifaceobj):
|
|
|
|
self._dhcp_down(ifaceobj)
|
2014-10-09 16:02:46 -07:00
|
|
|
self.ipcmd.link_down(ifaceobj.name)
|
|
|
|
|
|
|
|
def _query_check(self, ifaceobj, ifaceobjcurr):
|
2016-11-15 18:33:07 +01:00
|
|
|
status = ifaceStatus.SUCCESS
|
|
|
|
dhcp_running = False
|
|
|
|
|
|
|
|
dhcp_v4 = self.dhclientcmd.is_running(ifaceobjcurr.name)
|
|
|
|
dhcp_v6 = self.dhclientcmd.is_running6(ifaceobjcurr.name)
|
|
|
|
|
|
|
|
if dhcp_v4:
|
|
|
|
dhcp_running = True
|
|
|
|
if 'inet' not in ifaceobj.addr_family and not dhcp_v6:
|
|
|
|
status = ifaceStatus.ERROR
|
2014-10-09 16:02:46 -07:00
|
|
|
ifaceobjcurr.addr_method = 'dhcp'
|
2016-11-15 18:33:07 +01:00
|
|
|
if dhcp_v6:
|
|
|
|
dhcp_running = True
|
|
|
|
if 'inet6' not in ifaceobj.addr_family and not dhcp_v4:
|
|
|
|
status = ifaceStatus.ERROR
|
2014-10-09 16:02:46 -07:00
|
|
|
ifaceobjcurr.addr_method = 'dhcp'
|
2016-11-15 18:33:07 +01:00
|
|
|
ifaceobjcurr.addr_family = ifaceobj.addr_family
|
|
|
|
if not dhcp_running:
|
|
|
|
ifaceobjcurr.addr_family = []
|
|
|
|
status = ifaceStatus.ERROR
|
|
|
|
ifaceobjcurr.status = status
|
2014-10-09 16:02:46 -07:00
|
|
|
|
|
|
|
def _query_running(self, ifaceobjrunning):
|
|
|
|
if not self.ipcmd.link_exists(ifaceobjrunning.name):
|
|
|
|
return
|
|
|
|
if self.dhclientcmd.is_running(ifaceobjrunning.name):
|
2016-11-15 18:33:07 +01:00
|
|
|
ifaceobjrunning.addr_family.append('inet')
|
2014-10-09 16:02:46 -07:00
|
|
|
ifaceobjrunning.addr_method = 'dhcp'
|
2016-11-15 18:33:07 +01:00
|
|
|
if self.dhclientcmd.is_running6(ifaceobjrunning.name):
|
|
|
|
ifaceobjrunning.addr_family.append('inet6')
|
2014-10-09 16:02:46 -07:00
|
|
|
ifaceobjrunning.addr_method = 'dhcp6'
|
|
|
|
|
|
|
|
_run_ops = {'up' : _up,
|
|
|
|
'down' : _down,
|
2016-07-15 14:21:23 -07:00
|
|
|
'pre-down' : _down,
|
2014-10-09 16:02:46 -07:00
|
|
|
'query-checkcurr' : _query_check,
|
|
|
|
'query-running' : _query_running }
|
|
|
|
|
|
|
|
def get_ops(self):
|
|
|
|
""" returns list of ops supported by this module """
|
|
|
|
return self._run_ops.keys()
|
|
|
|
|
|
|
|
def _init_command_handlers(self):
|
|
|
|
if not self.ipcmd:
|
2016-04-14 14:45:47 -07:00
|
|
|
self.ipcmd = iproute2()
|
2014-10-09 16:02:46 -07:00
|
|
|
|
2014-10-24 10:11:07 -07:00
|
|
|
def run(self, ifaceobj, operation, query_ifaceobj=None, **extra_args):
|
2014-10-09 16:02:46 -07:00
|
|
|
""" run dhcp configuration on the interface object passed as argument
|
|
|
|
|
|
|
|
Args:
|
|
|
|
**ifaceobj** (object): iface object
|
|
|
|
|
|
|
|
**operation** (str): any of 'up', 'down', 'query-checkcurr',
|
|
|
|
'query-running'
|
|
|
|
|
|
|
|
Kwargs:
|
|
|
|
**query_ifaceobj** (object): query check ifaceobject. This is only
|
|
|
|
valid when op is 'query-checkcurr'. It is an object same as
|
|
|
|
ifaceobj, but contains running attribute values and its config
|
|
|
|
status. The modules can use it to return queried running state
|
|
|
|
of interfaces. status is success if the running state is same
|
|
|
|
as user required state in ifaceobj. error otherwise.
|
|
|
|
"""
|
|
|
|
op_handler = self._run_ops.get(operation)
|
|
|
|
if not op_handler:
|
|
|
|
return
|
|
|
|
try:
|
|
|
|
if (operation != 'query-running' and
|
|
|
|
(ifaceobj.addr_method != 'dhcp' and
|
|
|
|
ifaceobj.addr_method != 'dhcp6')):
|
|
|
|
return
|
|
|
|
except:
|
|
|
|
return
|
2016-11-22 17:06:16 +01:00
|
|
|
if not self.is_dhcp_allowed_on(ifaceobj, syntax_check=False):
|
|
|
|
return
|
2014-10-09 16:02:46 -07:00
|
|
|
self._init_command_handlers()
|
|
|
|
if operation == 'query-checkcurr':
|
|
|
|
op_handler(self, ifaceobj, query_ifaceobj)
|
|
|
|
else:
|
|
|
|
op_handler(self, ifaceobj)
|