mirror/CumulusNetworks-ifupdown2
1
0
Fork 0
mirror of https://github.com/CumulusNetworks/ifupdown2.git synced 2024-05-06 15:54:50 +00:00
Code
CumulusNetworks-ifupdown2/debian/python-ifupdown2.postrm

28 lines
819 B
Plaintext
Raw Normal View History

Fix bash completion for sudo users (mostly cosmetic) + man page and example fixes Ticket: CM-2911 Reviewed By: CCR-1637 Testing Done: tested ifupdown2 sanity and bash completion The python argcomplete module that i use for ifupdown2 has a limitation that it does not work with sudo when used in the global mode. But there is a workaround for it online (long story short...instead of enabling the global argparse complete ...the author recommends registering argparse complete bash completion individually for your script). This patch does just that. This patch also moves the udev overrides to their respective packages. Two of them are owned by ifupdown2. Conflicts: rootconf/default/home/cumulus/sysroot-complete
2014-06-06 23:00:24 -07:00
#!/bin/bash
python-ifupdown initial checkin Ticket: CM-1438 Reviewed By: TBD Testing Done: - Will checkin build files after some more testing and performance numbers. It will go into the testing repo for 2.0 - All TODO items are part of the checked in TODO file
2013-11-04 06:06:11 -08:00
set -e
more fixes + cleanup + support for --exclude argument Ticket: CM-1438 Reviewed By: Testing Done:
2013-11-13 16:07:15 -08:00
rm -f /sbin/ifup /sbin/ifdown /sbin/ifquery
python-ifupdown initial checkin Ticket: CM-1438 Reviewed By: TBD Testing Done: - Will checkin build files after some more testing and performance numbers. It will go into the testing repo for 2.0 - All TODO items are part of the checked in TODO file
2013-11-04 06:06:11 -08:00
case "$1" in
purge)
# Note: We don't remove /etc/network/interfaces
Fix bash completion for sudo users (mostly cosmetic) + man page and example fixes Ticket: CM-2911 Reviewed By: CCR-1637 Testing Done: tested ifupdown2 sanity and bash completion The python argcomplete module that i use for ifupdown2 has a limitation that it does not work with sudo when used in the global mode. But there is a workaround for it online (long story short...instead of enabling the global argparse complete ...the author recommends registering argparse complete bash completion individually for your script). This patch does just that. This patch also moves the udev overrides to their respective packages. Two of them are owned by ifupdown2. Conflicts: rootconf/default/home/cumulus/sysroot-complete
2014-06-06 23:00:24 -07:00
rm -f /var/tmp/network/ifstatenew
python-ifupdown initial checkin Ticket: CM-1438 Reviewed By: TBD Testing Done: - Will checkin build files after some more testing and performance numbers. It will go into the testing repo for 2.0 - All TODO items are part of the checked in TODO file
2013-11-04 06:06:11 -08:00
if [ -L /etc/network/run ] ; then
rm -f /etc/network/run
elif [ -d /etc/network/run ] ; then
rmdir --ignore-fail-on-non-empty /etc/network/run
fi
;;
esac
ifupdown2: fixup maintainer scripts to not crash on files not existing Ticket: CM-5735 Reviewed By: no one Testing Done: lots of repo upgrade testing by John B. This partially reverts commit 8959e8e4ec93487228733b17ef2b220ed47c1260 ("Fix bash completion for sudo users (mostly cosmetic)") in the sections where the Debian maintainer scripts were modified. In addition fixed up the Debian maintainer scripts to prevent a potential upgrade failure, discussion follows: The Cause For the upgrade Failure ================================= Commit 8959e8e4ec93487228733b17ef2b220ed47c1260 introduced changes to ifupdown2's package maintainer scripts to override some files provided by the bridge-utils and udev packages as they conflict with ifupdown2. The change to ifupdown2's postrm script is currently causing the script to exit with a failure code if the following files do not exist on the box: /etc/udev/rules.d/80-networking.rules /etc/udev/rules.d/60-bridge-network-interface.rules The reason for this is in how the script is written. Since the postrm script is configured to exit on the first command failure, the "set -e" on line 3, the commands on lines 20 and 22 will fail if the files being looked for do not exist, causing the script to exit with a non-zero exit code. Causing apt to fail the upgrade. .postrm script excerpt ---------- 20 udevlink=$(readlink /etc/udev/rules.d/80-networking.rules 2>/dev/null) 21 [ -n "$udevlink" -a "$udevlink" == "/dev/null" ] && rm -f /etc/udev/rules.d/80-networking.rules 22 udevlink=$(readlink /etc/udev/rules.d/60-bridge-network-interface.rules 2>/dev/null) 23 [ -n "$udevlink" -a "$udevlink" == "/dev/null" ] && rm -f /etc/udev/rules.d/60-bridge-network-interface.rules ---------- Solution -------- The solution requires having the newer version of the ifupdown2 package provide a preinst script that gets run before the older package's postrm script is run[1,2]. This gives us the opportunity to quietly fix the problem. We also fix the postrm script in newer versions of the package so it cannot bomb out in this way. Finally, removed what appears to be a poor merge from commit 5f5d84e3261bf70dd3541666a3d3a7f817727ce6. Fixes: 8959e8e4ec93487228733b17ef2b220ed47c1260 (cherry picked from commit 0eab79eb5aed4cdf0674e3f0ddad3631dd457bdc)
2015-04-20 13:41:05 -07:00
udevlink=$(readlink /etc/udev/rules.d/80-networking.rules 2>/dev/null || true)
Fix bash completion for sudo users (mostly cosmetic) + man page and example fixes Ticket: CM-2911 Reviewed By: CCR-1637 Testing Done: tested ifupdown2 sanity and bash completion The python argcomplete module that i use for ifupdown2 has a limitation that it does not work with sudo when used in the global mode. But there is a workaround for it online (long story short...instead of enabling the global argparse complete ...the author recommends registering argparse complete bash completion individually for your script). This patch does just that. This patch also moves the udev overrides to their respective packages. Two of them are owned by ifupdown2. Conflicts: rootconf/default/home/cumulus/sysroot-complete
2014-06-06 23:00:24 -07:00
[ -n "$udevlink" -a "$udevlink" == "/dev/null" ] && rm -f /etc/udev/rules.d/80-networking.rules
ifupdown2: fixup maintainer scripts to not crash on files not existing Ticket: CM-5735 Reviewed By: no one Testing Done: lots of repo upgrade testing by John B. This partially reverts commit 8959e8e4ec93487228733b17ef2b220ed47c1260 ("Fix bash completion for sudo users (mostly cosmetic)") in the sections where the Debian maintainer scripts were modified. In addition fixed up the Debian maintainer scripts to prevent a potential upgrade failure, discussion follows: The Cause For the upgrade Failure ================================= Commit 8959e8e4ec93487228733b17ef2b220ed47c1260 introduced changes to ifupdown2's package maintainer scripts to override some files provided by the bridge-utils and udev packages as they conflict with ifupdown2. The change to ifupdown2's postrm script is currently causing the script to exit with a failure code if the following files do not exist on the box: /etc/udev/rules.d/80-networking.rules /etc/udev/rules.d/60-bridge-network-interface.rules The reason for this is in how the script is written. Since the postrm script is configured to exit on the first command failure, the "set -e" on line 3, the commands on lines 20 and 22 will fail if the files being looked for do not exist, causing the script to exit with a non-zero exit code. Causing apt to fail the upgrade. .postrm script excerpt ---------- 20 udevlink=$(readlink /etc/udev/rules.d/80-networking.rules 2>/dev/null) 21 [ -n "$udevlink" -a "$udevlink" == "/dev/null" ] && rm -f /etc/udev/rules.d/80-networking.rules 22 udevlink=$(readlink /etc/udev/rules.d/60-bridge-network-interface.rules 2>/dev/null) 23 [ -n "$udevlink" -a "$udevlink" == "/dev/null" ] && rm -f /etc/udev/rules.d/60-bridge-network-interface.rules ---------- Solution -------- The solution requires having the newer version of the ifupdown2 package provide a preinst script that gets run before the older package's postrm script is run[1,2]. This gives us the opportunity to quietly fix the problem. We also fix the postrm script in newer versions of the package so it cannot bomb out in this way. Finally, removed what appears to be a poor merge from commit 5f5d84e3261bf70dd3541666a3d3a7f817727ce6. Fixes: 8959e8e4ec93487228733b17ef2b220ed47c1260 (cherry picked from commit 0eab79eb5aed4cdf0674e3f0ddad3631dd457bdc)
2015-04-20 13:41:05 -07:00
udevlink=$(readlink /etc/udev/rules.d/60-bridge-network-interface.rules 2>/dev/null || true)
Fix bash completion for sudo users (mostly cosmetic) + man page and example fixes Ticket: CM-2911 Reviewed By: CCR-1637 Testing Done: tested ifupdown2 sanity and bash completion The python argcomplete module that i use for ifupdown2 has a limitation that it does not work with sudo when used in the global mode. But there is a workaround for it online (long story short...instead of enabling the global argparse complete ...the author recommends registering argparse complete bash completion individually for your script). This patch does just that. This patch also moves the udev overrides to their respective packages. Two of them are owned by ifupdown2. Conflicts: rootconf/default/home/cumulus/sysroot-complete
2014-06-06 23:00:24 -07:00
[ -n "$udevlink" -a "$udevlink" == "/dev/null" ] && rm -f /etc/udev/rules.d/60-bridge-network-interface.rules
python-ifupdown initial checkin Ticket: CM-1438 Reviewed By: TBD Testing Done: - Will checkin build files after some more testing and performance numbers. It will go into the testing repo for 2.0 - All TODO items are part of the checked in TODO file
2013-11-04 06:06:11 -08:00
if [ "$1" = "purge" ] ; then
update-rc.d networking remove >/dev/null
fi
Copy Permalink