From 01a655366bbca01ed7cd3a7bd7ffb4c1cd314f84 Mon Sep 17 00:00:00 2001 From: Julien Fortin Date: Wed, 7 Apr 2021 01:04:15 +0200 Subject: [PATCH] addons: address: raise exception when detecting an invalid ip address Signed-off-by: Julien Fortin --- ifupdown2/addons/address.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ifupdown2/addons/address.py b/ifupdown2/addons/address.py index a567e2d..7c05c8e 100644 --- a/ifupdown2/addons/address.py +++ b/ifupdown2/addons/address.py @@ -416,7 +416,7 @@ class address(AddonWithIpBlackList, moduleBase): user_config_ip_addrs_list = [] try: - for ifaceobj in ifaceobj_list: + for ifaceobj in ifaceobj_list or []: user_addrs = ifaceobj.get_attr_value("address") @@ -455,7 +455,7 @@ class address(AddonWithIpBlackList, moduleBase): user_config_ip_addrs_list.append((addr_obj, addr_attributes)) except Exception as e: - self.logger.warning("%s: convert string ip address into IPNetwork object: %s" % (ifname, str(e))) + self.log_error("%s: convert string ip address into IPNetwork object: %s" % (ifname, str(e)), ifaceobj) return False, None return True, user_config_ip_addrs_list