From 068a72903756320323ee22d55d7777d4a660dd7a Mon Sep 17 00:00:00 2001
From: Roopa Prabhu <roopa@cumulusnetworks.com>
Date: Tue, 3 Jun 2014 11:11:47 -0700
Subject: [PATCH] Add close_fds=True in ifupdownbase class

Ticket: CM-2899
Reviewed By:
Testing Done: Tested ifupdown sanity

Just closing all the places where we could leak fds.
---
 pkg/ifupdownbase.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/pkg/ifupdownbase.py b/pkg/ifupdownbase.py
index 9d46525..aa51bd2 100644
--- a/pkg/ifupdownbase.py
+++ b/pkg/ifupdownbase.py
@@ -29,7 +29,8 @@ class ifupdownBase(object):
             ch = subprocess.Popen(cmd.split(),
                     stdout=subprocess.PIPE,
                     shell=False, env=cmdenv,
-                    stderr=subprocess.STDOUT)
+                    stderr=subprocess.STDOUT,
+                    close_fds=True)
             cmdout = ch.communicate()[0]
             cmd_returncode = ch.wait()
         except OSError, e: