mirror/CumulusNetworks-ifupdown2
1
0
Fork 0
mirror of https://github.com/CumulusNetworks/ifupdown2.git synced 2024-05-06 15:54:50 +00:00
Code Activity

ifquery --running should not display link attributes unless they are different then defaults.

Browse Source 
Ticket: CM-9995
Reviewed By: julien
Testing Done: Tested on amd64 hardnode

Right now, ifquery -r shows link speed, duplex and autoneg current running values.
This patch changes the behavior to not show link attributes unless they
differ then the defaults for that interface.
This commit is contained in:
Sam Tannous
2016-03-22 15:53:05 -04:00
parent c61672da44
commit 16e30aab93
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
addons/ethtool.py
View File

@@ -221,9 +221,10 @@ class ethtool(moduleBase,utilsBase):
if not default_val: if not default_val:
continue continue
running_attr = self.get_running_attr(attr, ifaceobj) running_attr = self.get_running_attr(attr, ifaceobj)
# if we can change it (have a default) then show it # Only show the link attributes if they differ from defaults
# otherwise, customers will show the running and save it to startup # to see the defaults, we should implement another flag (--with-defaults)
# which will result in errors (ethtool does not work on bonds, etc.) if default_val == running_attr:
continue
if running_attr: if running_attr:
ifaceobj.update_config('link-%s'%attr, running_attr) ifaceobj.update_config('link-%s'%attr, running_attr)