From 33e106daff4d169198ae772a1a8c720bb7b7f8ce Mon Sep 17 00:00:00 2001 From: Roopa Prabhu Date: Fri, 13 Jun 2014 06:08:40 -0700 Subject: [PATCH] Fix upperiface check when ifdown is run with -a Ticket: CM-3007 Reviewed By: shm + patch was pasted in the bug for review Testing Done: ran precommit + maliks test + malik ran his test on his box When -a is specified ifupdown2 works on all interfaces and since the the upperiface check is a bit expensive i had a "skip" on that. And so far all the user commands i have seen only work on the $IFACE and not its dependents. So, never hit this case. --- pkg/scheduler.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/scheduler.py b/pkg/scheduler.py index 17c7d76..6fc19c5 100644 --- a/pkg/scheduler.py +++ b/pkg/scheduler.py @@ -150,12 +150,14 @@ class ifaceScheduler(): if (ifupdownobj.FORCE or not ifupdownobj.ADDONS_ENABLE or (not ifupdownobj.is_ifaceobj_noconfig(ifaceobj) and - ifupdownobj.config.get('warn_on_ifdown', '0') == '0')): + ifupdownobj.config.get('warn_on_ifdown', '0') == '0' and + not ifupdownobj.ALL)): return True ulist = ifaceobj.upperifaces if not ulist: return True + # Get the list of upper ifaces other than the parent tmpulist = ([u for u in ulist if u != parent] if parent else ulist)