From 782fa53938298a0f047ae4c11cb5a25f670caee2 Mon Sep 17 00:00:00 2001 From: Roopa Prabhu Date: Fri, 2 Jan 2015 18:20:15 -0800 Subject: [PATCH] Warn when bond-min-links is absent or set to '0' Ticket: CM-4327 Reviewed By: Testing Done: Tested bond config without the bond-min-links attribute --- addons/ifenslave.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/addons/ifenslave.py b/addons/ifenslave.py index 4210332..adf2666 100644 --- a/addons/ifenslave.py +++ b/addons/ifenslave.py @@ -158,6 +158,13 @@ class ifenslave(moduleBase): int(attrval) > int(validrange[1])): raise Exception(msg + ' Valid range is [%s,%s]' %(validrange[0], validrange[1])) + if attrname == 'bond-mode' and attrval == '802.3ad': + dattrname = 'bond-min-links' + min_links = ifaceobj.get_attr_value_first(dattrname) + if not min_links or min_links == '0': + self.logger.warn('%s: required attribute %s' + %(ifaceobj.name, dattrname) + + ' not present or set to \'0\'') elif attrname in ['bond-lacp-bypass-allow']: # For some attrs, set default values optiondict = self.get_mod_attr(attrname)