mirror/CumulusNetworks-ifupdown2
1
0
Fork 0
mirror of https://github.com/CumulusNetworks/ifupdown2.git synced 2024-05-06 15:54:50 +00:00
Code Activity

addons: dhcp: executing dhclient4 and dhclient6 ops independently

Browse Source 
Ticket: CM-13817
Reviewed By: CCR-5408
Testing Done: steups explained in the bug

Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
This commit is contained in:
Julien Fortin
2016-12-02 00:39:35 +01:00
parent 09096420d8
commit de4104b092
2 changed files with 45 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
addons/dhcp.py
View File

@@ -38,11 +38,8 @@ class dhcp(moduleBase):
def _up(self, ifaceobj): def _up(self, ifaceobj):
# if dhclient is already running do not stop and start it # if dhclient is already running do not stop and start it
if self.dhclientcmd.is_running(ifaceobj.name) or \ dhclient4_running = self.dhclientcmd.is_running(ifaceobj.name)
self.dhclientcmd.is_running6(ifaceobj.name): dhclient6_running = self.dhclientcmd.is_running6(ifaceobj.name)
self.logger.info('dhclient already running on %s. Not restarting.' % \
ifaceobj.name)
return
try: try:
dhclient_cmd_prefix = None dhclient_cmd_prefix = None
dhcp_wait = policymanager.policymanager_api.get_attr_default( dhcp_wait = policymanager.policymanager_api.get_attr_default(
@@ -54,6 +51,10 @@ class dhcp(moduleBase):
dhclient_cmd_prefix = '%s %s' %(self.vrf_exec_cmd_prefix, vrf) dhclient_cmd_prefix = '%s %s' %(self.vrf_exec_cmd_prefix, vrf)
if 'inet' in ifaceobj.addr_family: if 'inet' in ifaceobj.addr_family:
if dhclient4_running:
self.logger.info('dhclient4 already running on %s. '
'Not restarting.' % ifaceobj.name)
else:
# First release any existing dhclient processes # First release any existing dhclient processes
try: try:
if not ifupdownflags.flags.PERFMODE: if not ifupdownflags.flags.PERFMODE:
@@ -63,6 +64,10 @@ class dhcp(moduleBase):
self.dhclientcmd.start(ifaceobj.name, wait=wait, self.dhclientcmd.start(ifaceobj.name, wait=wait,
cmd_prefix=dhclient_cmd_prefix) cmd_prefix=dhclient_cmd_prefix)
if 'inet6' in ifaceobj.addr_family: if 'inet6' in ifaceobj.addr_family:
if dhclient6_running:
self.logger.info('dhclient6 already running on %s. '
'Not restarting.' % ifaceobj.name)
else:
accept_ra = ifaceobj.get_attr_value_first('accept_ra') accept_ra = ifaceobj.get_attr_value_first('accept_ra')
if accept_ra: if accept_ra:
# XXX: Validate value # XXX: Validate value
@@ -93,7 +98,6 @@ class dhcp(moduleBase):
return return
time.sleep(2) time.sleep(2)
except Exception, e: except Exception, e:
self.log_error(str(e), ifaceobj) self.log_error(str(e), ifaceobj)

1
ifupdownaddons/dhclient.py
View File

@@ -99,5 +99,6 @@ class dhclient(utilsBase):
def release6(self, ifacename, cmd_prefix=None): def release6(self, ifacename, cmd_prefix=None):
cmd = ['/sbin/dhclient', '-6', '-r', '-pf', cmd = ['/sbin/dhclient', '-6', '-r', '-pf',
'/run/dhclient6.%s.pid' %ifacename, '/run/dhclient6.%s.pid' %ifacename,
'-lf', '/var/lib/dhcp/dhclient6.%s.leases' % ifacename,
'%s' %ifacename] '%s' %ifacename]
self._run_dhclient_cmd(cmd, cmd_prefix) self._run_dhclient_cmd(cmd, cmd_prefix)