From f466af7a8cf5b0bcfddf913b7818e6de99269966 Mon Sep 17 00:00:00 2001 From: Julien Fortin Date: Mon, 25 Apr 2016 17:39:57 +0200 Subject: [PATCH] addons: addressvirtual: fixing: duplicate address-virtual lines cause switch to lockup Ticket: CM-10478 Reviewed By: Roopa Testing Done: Tested with the interface file provided in the ticket and a custom one. --- addons/addressvirtual.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/addons/addressvirtual.py b/addons/addressvirtual.py index de07bdb..f95d694 100644 --- a/addons/addressvirtual.py +++ b/addons/addressvirtual.py @@ -261,6 +261,11 @@ class addressvirtual(moduleBase): self._remove_address_config(ifaceobj, address_virtual_list) return + if ifaceobj.upperifaces: + self.log_error('%s: invalid placement of address-virtual lines (must be configured under an interface with no upper interfaces or parent interfaces)' + % (ifaceobj.name), ifaceobj) + return + if not self.ipcmd.link_exists(ifaceobj.name): return self._apply_address_config(ifaceobj, address_virtual_list)