From f494105031c7ca1abf8c53798598cf955cf71d8e Mon Sep 17 00:00:00 2001 From: Julien Fortin Date: Thu, 31 Aug 2023 16:53:42 +0200 Subject: [PATCH] addons: addressvirtual: stale mac address detection was missing vrr without ip The stale mac verification code was only working for the following syntax: address-virtual MAC IP and not address-virtual MAC Signed-off-by: Julien Fortin --- debian/changelog | 1 + ifupdown2/addons/addressvirtual.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/debian/changelog b/debian/changelog index 89d9037..367a73b 100644 --- a/debian/changelog +++ b/debian/changelog @@ -3,6 +3,7 @@ ifupdown2 (3.2.1) unstable; urgency=medium * New: Attribute: "disable-ipv6" to control ipv6 on an interface * New: Policy: "default_loopback_scope" control loopback ip scope * Fix: keep link down after mac change if 'link-down yes' is specified + * Fix: addressvirtual stale mac detection is missing vrr without ip -- Julien Fortin Thu, 04 May 2023 23:42:00 -0700 diff --git a/ifupdown2/addons/addressvirtual.py b/ifupdown2/addons/addressvirtual.py index de28555..4118a86 100644 --- a/ifupdown2/addons/addressvirtual.py +++ b/ifupdown2/addons/addressvirtual.py @@ -242,7 +242,7 @@ class addressvirtual(AddonWithIpBlackList, moduleBase): continue for av in oldifaceobj.get_attr_value('address-virtual'): macip = av.split() - if len(macip) < 2: + if len(macip) < 1: self.logger.debug("%s: incorrect old address-virtual attrs '%s'" %(oldifaceobj.name, av)) continue