mirror/CumulusNetworks-ifupdown2
1
0
Fork 0
mirror of https://github.com/CumulusNetworks/ifupdown2.git synced 2024-05-06 15:54:50 +00:00
Code Activity
588 Commits 14 Branches 46 Tags
2e4dc7247cdbf7aa5064f9c8ffec2706405f8042
Commit Graph

242 Commits

Author SHA1 Message Date
Roopa Prabhu
c9bba7539d Move LINK_MASTER/LINK_SLAVE to a new field link_type (purna hit some 
issues with having it in flags) + add check for bond slave being already up

Ticket: CM-4408
Reviewed By:
Testing Done: some bond sanity test
 2014-12-08 22:59:41 -08:00
Roopa Prabhu
7f045fd868 This patch moves bond slave link ownership to the bond module and makes 
sure that slaves can never be brought admin up on their own when they
are not in the bond

Ticket: CM-4408
Reviewed By: CCR-2323
Testing Done: Tested ifup/ifdown of bond slaves and bond interface

This patch introduces:
- introduces 2 interface flags, LINK_MASTER and LINK_SLAVE.
- The bond module will set LINK_MASTER on the bond iface object
indicating that the bond module owns the link.
- Which means that all lower devices /slaves of the bond get their
link when the bond (aka LINK_MASTER) is processed in the bond module
- The module that queries dependencies propagates the LINK_SLAVE flags
on the dependents of LINK_MASTER.
- The scheduler now acts on the LINK_SLAVE flag. If LINK_SLAVE is set,
it skips setting admin 'up' on that interface. It also makes sure the
interface is not already in the bond.
    ie if an interface is a LINK_SLAVE (bond slave in this case), admin
up will not be executed when the interface is not inside the bond.
 2014-12-08 17:15:57 -08:00
Roopa Prabhu
f59b5c656b Fix reserved vlan check + change switchd ifupdown reserved vlan script 
to return reserved vlan range from /etc/cumulus/switchd.conf

Ticket: CM-4367
Reviewed By: wkok
Testing Done: Tested using reserved vlans in old and new bridge
(cherry picked from commit 8626feb08703392b29e234b2f81f4df536ad7f7b)
 2014-12-03 14:06:57 -08:00
Roopa Prabhu
2708f9155f Fix reserved vlan check + change switchd ifupdown reserved vlan script 
to return reserved vlan range from /etc/cumulus/switchd.conf

Ticket: CM-4367
Reviewed By: wkok
Testing Done: Tested using reserved vlans in old and new bridge
 2014-12-03 14:03:34 -08:00
Roopa Prabhu
cf5dcafa07 continue passing the object to other modules if one of the modules fails 
Ticket: CM-4336
Reviewed By:
Testing Done: Tested with the missing port testcase from CM-4336
(cherry picked from commit 82a976ada6ba208bde089805d613413a5b016f8d)
 2014-12-01 15:15:19 -08:00
Roopa Prabhu
3e6ea735cc continue passing the object to other modules if one of the modules fails 
Ticket: CM-4336
Reviewed By:
Testing Done: Tested with the missing port testcase from CM-4336
 2014-12-01 14:54:12 -08:00
Roopa Prabhu
cd3059b82b Change case of check strings 
Ticket: CM-3346
Reviewed By: cosmetic
Testing Done: ifquery check sanity
(cherry picked from commit 556a078a7f551f1f895f0ddc71b6124d960ffb4e)
 2014-11-28 12:54:04 -08:00
Roopa Prabhu
a3b9ac1e99 Change case of check strings 
Ticket: CM-3346
Reviewed By: cosmetic
Testing Done: ifquery check sanity
 2014-11-28 12:48:01 -08:00
Roopa Prabhu
ad25e7bb98 Misc fixes. Add a --skip-upperifaces option to ifup (given the confusion 
over ifup handling of upperifaces by default) + some fixes in the
reserved vlan check

Ticket: CM-3346
Reviewed By:
Testing Done: Tested ifupdown sanity.
 2014-11-25 10:19:35 -08:00
Roopa Prabhu
11f3290e60 if 'bridge-vlan-aware yes' specified, explicitly set 1 in bridge sysfs 
vlan_filtering flags.

Ticket: CM-3346
Reviewed By:
Testing Done: Tested new bridge driver sanity
 2014-11-21 10:17:37 -08:00
Roopa Prabhu
16d854b461 Fix a few minor ifquery check failures 
Ticket: CM-3346
Reviewed By:
Testing Done: Tested ifupdown2 sanity and query check failures.
 2014-11-19 17:25:26 -08:00
Roopa Prabhu
4c39c7b84a Fix ordering of mstpctl attributes by moving to a OrderedDict 
Ticket: CM-3737
Reviewed By:
Testing Done: Tested with config given in the bug
 2014-11-19 14:42:14 -08:00
Roopa Prabhu
68d9fee038 Fix address module config (mtu, alias etc) when addr_method is dhcp 
Ticket: CA-269
Reviewed By:
Testing Done: Tested setting alias on an interface with addr_method dhcp
 2014-11-18 16:52:00 -08:00
Roopa Prabhu
75afe2a7f4 set arp accept to 1 for bridge devices with an ip and new bridge svi 
device (forward port of commit

Ticket: CM-4218
Reviewed By:
Testing Done: Tested with address on new bridge svi and old bridge
 2014-11-17 16:23:42 -08:00
Roopa Prabhu
bcf11b14f8 Change warn to debug for gateway del errors during down 
Ticket: CM-3346
Reviewed By:
Testing Done: trivial
 2014-11-15 23:31:42 -08:00
Roopa Prabhu
d8e3554dde minor fixes for ifquery and stp handling 
Ticket: CM-3346
Reviewed By:
Testing Done: Tested ifupdown2 sanity
 2014-11-15 15:42:52 -08:00
Roopa Prabhu
e8b4b06dc0 Add iface 'up' for method 'manual' in addon modules for logical devices 
Ticket: CM-4125
Reviewed By:
Testing Done: Tested inet manual for logical interfaces
 2014-11-12 10:51:07 -08:00
Roopa Prabhu
2da58137d8 Misc fixes + ifreload new option + cleanups + more ifquery support etc 
Ticket: CM-3346, CM-3784, CM-3841
Reviewed By:
Testing Done: various ifupdown2 tests
 2014-11-11 21:58:12 -08:00
Roopa Prabhu
830c91d7e6 First cut ifupdown2 module for vrrpd 
Ticket: CM-3454
Reviewed By:
Testing Done: basic testing with vrrpd

There is no check support yet and an open issue
with checking existing ifplugd processes
 2014-11-11 21:47:29 -08:00
Roopa Prabhu
a9d3664814 Dont warn on fdb del failures during down 
Ticket: CM-4178
Reviewed By:
Testing Done: Tested vrr interface up and down

Checking and deleting is expensive. so, ignore delete failures.
Currently logs them at debug level.
 2014-11-11 21:22:36 -08:00
Roopa Prabhu
394e68b526 Add address-purge attribute to disable purging of addresses on an 
interface.

Ticket: CM-3785
Reviewed By:
Testing Done: Tested disabling purging of existing addresses on an
interface with 'address-purge no'.

This helps in cases where some other daemon wants to manage ip addresses
on this interface
 2014-11-11 21:08:38 -08:00
Roopa Prabhu
aaef0a7928 limit macvlan device names to 15chars 
Ticket: CM-3346
Reviewed By:
Testing Done: sanity test address-virtual lines
 2014-11-08 06:29:26 -08:00
Roopa Prabhu
e759a20abf Fix defaults for mstpctl-portp2p 
Ticket: CM-4141
Reviewed By:
Testing Done: Tested ifquery running for mstpctl-portp2p
 2014-11-08 06:14:56 -08:00
Roopa Prabhu
7adb4b77ab Fix mstpctl attribute names in ifquery running output 
Ticket: CM-4141
Reviewed By:
Testing Done: Tested with test case in CM-4141 + sanity testing
 2014-11-06 16:10:21 -08:00
Roopa Prabhu
19f90a917a Fix mstpctl port attribute ifquery check 
Ticket: CM-3346
Reviewed By:
Testing Done: Tested ifquery check mstpctl attributes on bridge port
 2014-11-04 11:31:30 -08:00
Roopa Prabhu
3eee421aca Fix vxlan query running 
Ticket: CM-3346
Reviewed By:
Testing Done: vxlan query running
 2014-11-03 21:47:22 -08:00
Roopa Prabhu
da1eb143c2 Fix bridgevlan query check 
Ticket: CM-3346
Reviewed By:
Testing Done: tested bridge vlan query check
 2014-11-03 21:28:14 -08:00
Roopa Prabhu
8e113d6319 misc query and fdb/vlan add fixes 
Ticket: CM-3346
Reviewed By:
Testing Done: ifupdown2 sanity
 2014-11-03 17:55:51 -08:00
Roopa Prabhu
9e012f9e8a some more ifquery support (for vxlan devices etc) 
Ticket: CM-3784
Reviewed By:
Testing Done: Tested ifquery check/running and sanity
 2014-10-31 11:28:07 -07:00
Roopa Prabhu
07ff144260 Remove stale debug 
Ticket: CM-3346
Reviewed By:
Testing Done:
 2014-10-29 12:57:57 -07:00
Roopa Prabhu
98b5ee73fc misc fixes 
Ticket: CM-3346
Reviewed By:
Testing Done: ifupdown2 sanity with new bridge driver
 2014-10-29 12:51:21 -07:00
Roopa Prabhu
cb46a2082f misc bug fixes for svi address propagation, svi query etc 
Ticket: CM-3346
Reviewed By:
Testing Done: Tested new format with new bridge driver

- add/del vlan aware bridge svi mac addresses from bridge
- shorten macvlan interface names to <bridge>-<vid>-v<n>
- fix query check for address-virtual interfaces
- fix query check for vlan interfaces
 2014-10-28 23:04:40 -07:00
Roopa Prabhu
e160136944 Bug fixes and some query support 
Ticket: CM-3346
Reviewed By:
Testing Done: sanity testing and syntax testing for new bridge driver
 2014-10-28 16:10:00 -07:00
Roopa Prabhu
7baa2093ba Fix bridge port vid settings during ifup of a bridge port 
Ticket: CM-3346
Reviewed By:
Testing Done: ifupdown2 sanity test for the new bridge driver
 2014-10-24 20:43:50 -07:00
Roopa Prabhu
fe91c3484f remove code that makes a bridge port inherit stp/mstp/igmp attributes from bridge 
Ticket: CM-4035
Reviewed By:
Testing Done: Tested ifupdown2 sanity
 2014-10-24 14:21:54 -07:00
Roopa Prabhu
84ca006f82 First phase checkin for new format for vlan aware bridge 
Ticket: CM-3346
Reviewed By:
Testing Done: Sanity test + test new bridge format

There are a bunch of open issues with `vlan` interface handling.
Below is the format.

auto swp1
iface swp1
    bridge-access 300
    mstpctl-pathcost 0
    mstpctl-adminedge yes
    mstpctl-autoedge yes
    mstpctl-p2p yes
    mstpctl-bpduguard yes
    mstpctl-treeprio 64
    mstpctl-network yes
    mstpctl-bpdufilter yes

auto swp2
iface swp2
    bridge-vids 301
    bridge-pvid 302
    bridge-pathcost 10
    bridge-priority 10
    bridge-multicast-router 0
    bridge-multicast-fast-leave 1

auto br0
iface br0
    bridge-vlan-aware yes
    bridge-stp on
    bridge-ports swp1 swp2
    bridge-vids 2001

auto br0.2001
iface br0.2001
    address 10.0.14.2
    hwaddress 00:03:00:00:00:12
    address-virtual 00:00:5e:00:01:01 11.0.4.1/24

auto br0.2001
vlan br0.2001
    bridge-igmp-querier-src 172.16.101.1
 2014-10-24 10:11:07 -07:00
Roopa Prabhu
48ca05db88 Fix missing import due to merge 
Ticket:
Reviewed By:
Testing Done:
 2014-10-22 13:42:08 -07:00
Roopa Prabhu
e74d01e1b2 Add rtnetlink api's for link creates 
Ticket: CM-3346
Reviewed By:
Testing Done:
 2014-10-12 13:50:05 -07:00
Roopa Prabhu
667d62f587 Make query check a no-op for the vlan aware bridge until correctly fixed 
Ticket: CM-3346
Reviewed By:
Testing Done: sanity test
 2014-10-09 21:22:12 -07:00
Roopa Prabhu
d101ece27b Remove stale mstp adminadge attributes 
Ticket: CM-3346
Reviewed By: sashok
Testing Done: sanity test
 2014-10-09 19:26:10 -07:00
Roopa Prabhu
39804250c7 A few more fixes to the vlan aware bridge case 
Ticket: CM-3346
Reviewed By:
Testing Done: Tested with new and old bridge formats
 2014-10-09 19:10:20 -07:00
Roopa Prabhu
15ef32ea14 Move ifupdown2addons into ifupdown2 pacakge 
Ticket: CM-3864
Reviewed By:
Testing Done: Tested build and install

open item:
- cleanup stale ifupdown2-addons package files
 2014-10-09 16:02:46 -07:00