Ticket: CM-1438
Reviewed By:
Testing Done: Tested ifupdown2 sanity + multiple iface sections for an
interface
- This patch fixes a few shortcomings in the multiple iface sections
for same interface (partly because i was only covering
backward compatibility cases earlier)
- Since this is a very common configuration pattern, this patch cleans
it up
- also restructures some code
- main change is:
before:
for iface in ifaces:
for op in ops:
run op on iface
after:
for op in ops:
for iface in ifaces:
run op on iface
warnings on ifupdown)
Ticket: CM-1438
Reviewed By:
Testing Done: Tested ifupdown2 sanity
Some of the above mentioned configurable items can be specified in
ifupdown2.conf
Ticket:
Reviewed By: sergey
Testing Done:
dpkg-configure during build seems to be picking up python2.6 and
python2.6 was complaining about the syntax. Fixed with syntax
compatible with python2.6
attributes' for backward compatibility
Ticket: CM-1438
Reviewed By:
Testing Done: Tested ifupdown sanity and new functionality
support for:
- -i <interface file>
- template lookup path and move all template handling to a separate
module template.py
- new ifupdown2 config file /etc/network/ifupdown2/ifupdown2.conf
- bridge_waitport and bridge_maxwait
- moved addons.conf to /var/lib/ifupdownaddons/
Ticket: CM-2302
Reviewed By:
Testing Done: Tested ifupdown syntax checker + sanity
Also includes fixes to some of the sytax checker problems mentioned in
CM-2509
a logical interface comes up
Ticket: CM-2493
Reviewed By:
Testing Done: Tested ifup, ifdown in bond bridge setup
Also, implicitly pick up the upperifaces (even when user has not
specified --with-depends) for logical interfaces.
This is because when a logical interface goes down/deleted, kernel
impilicity deletes its upperifaces. so its better to implicitly bring
up upperifaces.
example
bridge name bridge id STP enabled interfaces
br0 8000.7072cf8c2fca yes bond1
bond2
br2000 8000.7072cf8c2fca yes bond1.2000
bond2.2000
br2001 8000.7072cf8c2fca yes bond1.2001
bond2.2001
bridge name bridge id STP enabled interfaces
br0 8000.000000000000 yes
br2000 8000.000000000000 yes
br2001 8000.000000000000 yes
bridge name bridge id STP enabled interfaces
br0 8000.7072cf8c2fca yes bond1
bond2
br2000 8000.7072cf8c2fca yes bond1.2000
bond2.2000
br2001 8000.7072cf8c2fca yes bond1.2001
bond2.2001
Ticket: CM-1438
Reviewed By: review pending
Testing Done: Tested ifup/ifdown
Before this patch, `ifup --with-depends <iface>` only brought up
lowerdevices. Because those were enough for iface to function.
And if ifaces above it (upperdevices) needed fixing, user could just
execute `ifup --with-depends <ifaceupper>`.
But in a recent, bond under a bridge bug in 2.0, got me thinking that
its probably better to up the upperdevices which might be impacted as
well. and this patch does just that.
The patch includes changes to make ifupdown generate dependency
information for all interfaces even if the user requested to operate
on a single interface. This is to get a full view of the interfaces file.
This might add some overhead. Should not change anything during boot.
Still looking at ways to optimize.
Ticket: CM-1438
Reviewed By:
Testing Done:
This also fixes a bug with address handling:
- If the user changed a primary address, flush all the addresses and
re-add them. Previously, if user added a new primary address, it would
ust get appended to the end of the address list as a secondary address.
Ticket: CM-1438
Reviewed By:
Testing Done: l3 lag test with help from purna
- THe down sequence in the new ifupdown was causing switchd some grief
(wilson is looking at it). readded the topological sort which i had
removed in favor of only walking the tree. With the fix,i dont see the
switchd problem anymore.
- And another down bug was causing the bond to go away prematurely (only
with the all depends option). Added a upperdevice list to track upperdev references
Ticket: CM-1438
Reviewed By:
Testing Done: unit tested with all kinds of interfaces
some high level changes
- moved ipv4/ipv6 address handling in a single module. dhcp
into a separate module.
- new link 'up' module
- igmp fixes
- many other fixes
added a --with-depends option)
Ticket: CM-1438
Reviewed By:
Testing Done:
still debating on the default behaviour for following dependents.
for now not following dependents might be better.
When all interfaces are selected, it always follows dependents
Ticket: CM-1438
Reviewed By:
Testing Done: tested with configs involving vlan devices and bridges
- fix dependency handling which i had broken recently with my last
checkin (nat reported this one)
- In inet pluggins, dont issue ip addr get unless required (saw cpu
spike up because of CM-1889)
- and some other minor changes lying in my tree
Ticket: CM-1438
Reviewed By:
Testing Done: Tested installing new ifupdown on the box
- fixed a few things in ifquery
- added new perfmode to skip some of the checks (useful during boot when there is
no previous state)
- updated doc dir with example
- Added README, TODO and KNOWN_ISSUES file
Ticket: CM-1438
Reviewed By: TBD
Testing Done:
- Will checkin build files after some more testing and performance
numbers. It will go into the testing repo for 2.0
- All TODO items are part of the checked in TODO file
