mirror of
https://github.com/CumulusNetworks/ifupdown2.git
synced 2024-05-06 15:54:50 +00:00
a193d8d1c0
Ticket: None
Reviewed By: CCR-4692
Testing Done: smoke + scale tests
If called with close_fds=True the subprocess module will try to close every fd
from 3 to MAXFD before executing the specified command. This is done in Python
not even with a C-implementation which truly affecting performances.
This patch aims to better handle the file descriptor used by ifupdown2. Either
by closing them after use or by setting the close-on-exec flag for the file
descriptor, which causes the file descriptor to be automatically
(and atomically) closed when any of the exec-family functions succeed.
With the actual patch all tests are passing, I can't think of any future issue
but if any a possible future modification might be to use the parameter
'preexec_fn', which allows us to set function which will be executed in the
child process before executing the command line. We can always manually close
any remaining open file descriptors with something like:
>>> os.listdir('/proc/self/fd/')
['0', '1', '2', ‘3’, etc..]
>>> for fd in os.listdir('/proc/self/fd/')
>>> if int(fd) > 2:
>>> os.close(fd)
This patch is also totally re-organising the use of subprocesses. By removing
all subprocess code redundancy.
56 lines
1.5 KiB
Python
56 lines
1.5 KiB
Python
#!/usr/bin/python
|
|
#
|
|
# Copyright 2015 Cumulus Networks, Inc. All rights reserved.
|
|
# Author: Roopa Prabhu, roopa@cumulusnetworks.com
|
|
#
|
|
|
|
import os
|
|
from utilsbase import *
|
|
from ifupdown.utils import utils
|
|
|
|
class systemUtils():
|
|
@classmethod
|
|
def is_service_running(cls, procname=None, pidfile=None):
|
|
utilsobj = utilsBase()
|
|
if pidfile:
|
|
if os.path.exists(pidfile):
|
|
pid = utilsobj.read_file_oneline(pidfile)
|
|
if not os.path.exists('/proc/%s' %pid):
|
|
return False
|
|
else:
|
|
return False
|
|
return True
|
|
|
|
if procname:
|
|
try:
|
|
utils.exec_command('/bin/pidof %s' % procname, stdout=False)
|
|
except:
|
|
return False
|
|
else:
|
|
return True
|
|
|
|
return False
|
|
|
|
@classmethod
|
|
def check_service_status(cls, servicename=None):
|
|
if not servicename:
|
|
return False
|
|
try:
|
|
utils.exec_commandl(['/usr/sbin/service', servicename, 'status'],
|
|
stdout=False)
|
|
except Exception:
|
|
# XXX: check for subprocess errors vs os error
|
|
return False
|
|
return True
|
|
|
|
@classmethod
|
|
def is_process_running(self, processname):
|
|
if not processname:
|
|
return False
|
|
try:
|
|
utils.exec_command('/bin/pidof %s' % processname, stdout=False)
|
|
except:
|
|
return False
|
|
else:
|
|
return True
|