| 
									
										
										
										
											2020-09-18 11:00:27 +02:00
										 |  |  | #!rsc by RouterOS | 
					
						
							| 
									
										
										
										
											2018-07-05 15:29:26 +02:00
										 |  |  | # RouterOS script: ppp-on-up | 
					
						
							| 
									
										
										
										
											2021-01-01 21:33:52 +01:00
										 |  |  | # Copyright (c) 2013-2021 Christian Hesse <mail@eworm.de> | 
					
						
							| 
									
										
										
										
											2020-06-19 22:17:42 +02:00
										 |  |  | # https://git.eworm.de/cgit/routeros-scripts/about/COPYING.md | 
					
						
							| 
									
										
										
										
											2018-07-05 15:29:26 +02:00
										 |  |  | # | 
					
						
							|  |  |  | # run scripts on ppp up | 
					
						
							| 
									
										
										
										
											2020-03-27 21:49:36 +01:00
										 |  |  | # https://git.eworm.de/cgit/routeros-scripts/about/doc/ppp-on-up.md | 
					
						
							| 
									
										
										
										
											2018-07-05 15:29:26 +02:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2021-02-22 15:14:10 +01:00
										 |  |  | :local 0 "ppp-on-up"; | 
					
						
							| 
									
										
										
										
											2021-02-18 14:52:47 +01:00
										 |  |  | :global GlobalFunctionsReady; | 
					
						
							|  |  |  | :while ($GlobalFunctionsReady != true) do={ :delay 500ms; } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2021-02-22 15:14:10 +01:00
										 |  |  | :global LogPrintExit2; | 
					
						
							| 
									
										
										
										
											2020-02-24 20:07:21 +01:00
										 |  |  | 
 | 
					
						
							| 
									
										
											  
											
												global: variable names are CamelCase
            ___  _         ___     __
           / _ )(_)__ _   / _/__ _/ /_
          / _  / / _ `/  / _/ _ `/ __/
         /____/_/\_, /  /_/ \_,_/\__/
 _       __     /___/       _             __
| |     / /___ __________  (_)___  ____ _/ /
| | /| / / __ `/ ___/ __ \/ / __ \/ __ `/ /
| |/ |/ / /_/ / /  / / / / / / / / /_/ /_/
|__/|__/\__,_/_/  /_/ /_/_/_/ /_/\__, (_)
                                /____/
RouterOS has some odd behavior when it comes to variable names. Let's
have a look at the interfaces:
[admin@MikroTik] > / interface print where name=en1
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598
That looks ok. Now we use a script:
{ :local interface "en1";
  / interface print where name=$interface; }
And the result...
[admin@MikroTik] > { :local interface "en1";
{...   / interface print where name=$interface; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598
... still looks ok.
We make a little modification to the script:
{ :local name "en1";
  / interface print where name=$name; }
And the result:
[admin@MikroTik] > { :local name "en1";
{...   / interface print where name=$name; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598
 1   S en2                                 ether            1500  1598
 2   S en3                                 ether            1500  1598
 3   S en4                                 ether            1500  1598
 4   S en5                                 ether            1500  1598
 5  R  br-local                            bridge           1500  1598
Ups! The filter has no effect!
That happens whenever the variable name ($name) matches the property
name (name=).
And another modification:
{ :local type "en1";
  / interface print where name=$type; }
And the result:
[admin@MikroTik] > { :local type "en1";
{...   / interface print where name=$type; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
Ups! Nothing?
Even if the variable name ($type) matches whatever property name (type=)
things go wrong.
The answer from MikroTik support (in Ticket#2019010222000454):
> This is how scripting works in RouterOS and we will not fix it.
To get around this we use variable names in CamelCase. Let's hope
Mikrotik never ever introduces property names in CamelCase...
*fingers crossed*
											
										 
											2019-01-03 17:45:43 +01:00
										 |  |  | :local Interface $interface; | 
					
						
							| 
									
										
										
										
											2019-07-05 23:21:46 +02:00
										 |  |  | 
 | 
					
						
							|  |  |  | :if ([ :typeof $Interface ] = "nothing") do={ | 
					
						
							| 
									
										
										
										
											2021-02-22 15:14:10 +01:00
										 |  |  |   $LogPrintExit2 error $0 ("This script is supposed to run from ppp on-up script hook.") true; | 
					
						
							| 
									
										
										
										
											2019-07-05 23:21:46 +02:00
										 |  |  | } | 
					
						
							|  |  |  | 
 | 
					
						
							| 
									
										
										
										
											2019-01-04 13:02:34 +01:00
										 |  |  | :local IntName [ / interface get $Interface name ]; | 
					
						
							| 
									
										
										
										
											2021-06-23 10:59:04 +02:00
										 |  |  | $LogPrintExit2 info $0 ("PPP interface " . $IntName . " is up.") false; | 
					
						
							| 
									
										
										
										
											2018-07-05 15:29:26 +02:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2019-01-04 20:30:17 +01:00
										 |  |  | / ipv6 dhcp-client release [ find where interface=$IntName !disabled ]; | 
					
						
							| 
									
										
										
										
											2019-01-04 20:29:42 +01:00
										 |  |  | 
 | 
					
						
							| 
									
										
										
										
											2021-06-23 10:19:59 +02:00
										 |  |  | :foreach Script in=[ / system script find where source~("\n# provides: ppp-on-up\n") ] do={ | 
					
						
							|  |  |  |   :local ScriptName [ / system script get $Script name ]; | 
					
						
							| 
									
										
										
										
											2021-06-23 10:26:10 +02:00
										 |  |  |   :do { | 
					
						
							| 
									
										
										
										
											2021-06-23 10:59:04 +02:00
										 |  |  |     $LogPrintExit2 debug $0 ("Running script: " . $ScriptName) false; | 
					
						
							| 
									
										
										
										
											2021-06-23 10:26:10 +02:00
										 |  |  |     / system script run $Script; | 
					
						
							|  |  |  |   } on-error={ | 
					
						
							| 
									
										
										
										
											2021-06-23 10:59:04 +02:00
										 |  |  |     $LogPrintExit2 warning $0 ("Running script '" . $ScriptName . "' failed!") false; | 
					
						
							| 
									
										
										
										
											2021-06-23 10:26:10 +02:00
										 |  |  |   } | 
					
						
							| 
									
										
										
										
											2019-01-04 20:29:42 +01:00
										 |  |  | } |