1
0
mirror of https://github.com/eworm-de/routeros-scripts.git synced 2024-05-11 05:55:19 +00:00

collect-wireless-mac: lease without address should be impossible...

... we need the check for empty hostname, though.
This commit is contained in:
Christian Hesse
2019-11-25 16:43:19 +01:00
parent b70d4f7666
commit 15a6fb325e
3 changed files with 6 additions and 15 deletions

View File

@ -24,18 +24,15 @@ $ScriptLock "collect-wireless-mac.capsman";
:local Mac [ / caps-man registration-table get $RegTbl mac-address ]; :local Mac [ / caps-man registration-table get $RegTbl mac-address ];
:local AccessList ([ / caps-man access-list find where mac-address=$Mac ]->0); :local AccessList ([ / caps-man access-list find where mac-address=$Mac ]->0);
:if ([ :len $AccessList ] = 0) do={ :if ([ :len $AccessList ] = 0) do={
:local HostName "no dhcp lease";
:local Address "no dhcp lease"; :local Address "no dhcp lease";
:local HostName "no dhcp lease";
:local Lease [ / ip dhcp-server lease find where mac-address=$Mac ]; :local Lease [ / ip dhcp-server lease find where mac-address=$Mac ];
:if ([ :len $Lease ] > 0) do={ :if ([ :len $Lease ] > 0) do={
:set HostName [ / ip dhcp-server lease get $Lease host-name ];
:set Address [ / ip dhcp-server lease get $Lease address ]; :set Address [ / ip dhcp-server lease get $Lease address ];
:set HostName [ / ip dhcp-server lease get $Lease host-name ];
:if ([ :len $HostName ] = 0) do={ :if ([ :len $HostName ] = 0) do={
:set HostName "no hostname"; :set HostName "no hostname";
} }
:if ([ :len $Address ] = 0) do={
:set Address "no address";
}
} }
:local RegEntry [ / caps-man registration-table find where mac-address=$Mac ]; :local RegEntry [ / caps-man registration-table find where mac-address=$Mac ];
:local Interface [ / caps-man registration-table get $RegEntry interface ]; :local Interface [ / caps-man registration-table get $RegEntry interface ];

View File

@ -24,18 +24,15 @@ $ScriptLock "collect-wireless-mac.local";
:local Mac [ / interface wireless registration-table get $RegTbl mac-address ]; :local Mac [ / interface wireless registration-table get $RegTbl mac-address ];
:local AccessList ([ / interface wireless access-list find where mac-address=$Mac ]->0); :local AccessList ([ / interface wireless access-list find where mac-address=$Mac ]->0);
:if ([ :len $AccessList ] = 0) do={ :if ([ :len $AccessList ] = 0) do={
:local HostName "no dhcp lease";
:local Address "no dhcp lease"; :local Address "no dhcp lease";
:local HostName "no dhcp lease";
:local Lease [ / ip dhcp-server lease find where mac-address=$Mac ]; :local Lease [ / ip dhcp-server lease find where mac-address=$Mac ];
:if ([ :len $Lease ] > 0) do={ :if ([ :len $Lease ] > 0) do={
:set HostName [ / ip dhcp-server lease get $Lease host-name ];
:set Address [ / ip dhcp-server lease get $Lease address ]; :set Address [ / ip dhcp-server lease get $Lease address ];
:set HostName [ / ip dhcp-server lease get $Lease host-name ];
:if ([ :len $HostName ] = 0) do={ :if ([ :len $HostName ] = 0) do={
:set HostName "no hostname"; :set HostName "no hostname";
} }
:if ([ :len $Address ] = 0) do={
:set Address "no address";
}
} }
:local RegEntry [ / interface wireless registration-table find where mac-address=$Mac ]; :local RegEntry [ / interface wireless registration-table find where mac-address=$Mac ];
:local Interface [ / interface wireless registration-table get $RegEntry interface ]; :local Interface [ / interface wireless registration-table get $RegEntry interface ];

View File

@ -25,18 +25,15 @@ $ScriptLock "collect-wireless-mac%TEMPL%";
:local Mac [ / %PATH% registration-table get $RegTbl mac-address ]; :local Mac [ / %PATH% registration-table get $RegTbl mac-address ];
:local AccessList ([ / %PATH% access-list find where mac-address=$Mac ]->0); :local AccessList ([ / %PATH% access-list find where mac-address=$Mac ]->0);
:if ([ :len $AccessList ] = 0) do={ :if ([ :len $AccessList ] = 0) do={
:local HostName "no dhcp lease";
:local Address "no dhcp lease"; :local Address "no dhcp lease";
:local HostName "no dhcp lease";
:local Lease [ / ip dhcp-server lease find where mac-address=$Mac ]; :local Lease [ / ip dhcp-server lease find where mac-address=$Mac ];
:if ([ :len $Lease ] > 0) do={ :if ([ :len $Lease ] > 0) do={
:set HostName [ / ip dhcp-server lease get $Lease host-name ];
:set Address [ / ip dhcp-server lease get $Lease address ]; :set Address [ / ip dhcp-server lease get $Lease address ];
:set HostName [ / ip dhcp-server lease get $Lease host-name ];
:if ([ :len $HostName ] = 0) do={ :if ([ :len $HostName ] = 0) do={
:set HostName "no hostname"; :set HostName "no hostname";
} }
:if ([ :len $Address ] = 0) do={
:set Address "no address";
}
} }
:local RegEntry [ / %PATH% registration-table find where mac-address=$Mac ]; :local RegEntry [ / %PATH% registration-table find where mac-address=$Mac ];
:local Interface [ / %PATH% registration-table get $RegEntry interface ]; :local Interface [ / %PATH% registration-table get $RegEntry interface ];