mirror of
				https://github.com/eworm-de/routeros-scripts.git
				synced 2024-05-11 05:55:19 +00:00 
			
		
		
		
	___  _         ___     __
           / _ )(_)__ _   / _/__ _/ /_
          / _  / / _ `/  / _/ _ `/ __/
         /____/_/\_, /  /_/ \_,_/\__/
 _       __     /___/       _             __
| |     / /___ __________  (_)___  ____ _/ /
| | /| / / __ `/ ___/ __ \/ / __ \/ __ `/ /
| |/ |/ / /_/ / /  / / / / / / / / /_/ /_/
|__/|__/\__,_/_/  /_/ /_/_/_/ /_/\__, (_)
                                /____/
RouterOS has some odd behavior when it comes to variable names. Let's
have a look at the interfaces:
[admin@MikroTik] > / interface print where name=en1
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598
That looks ok. Now we use a script:
{ :local interface "en1";
  / interface print where name=$interface; }
And the result...
[admin@MikroTik] > { :local interface "en1";
{...   / interface print where name=$interface; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598
... still looks ok.
We make a little modification to the script:
{ :local name "en1";
  / interface print where name=$name; }
And the result:
[admin@MikroTik] > { :local name "en1";
{...   / interface print where name=$name; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598
 1   S en2                                 ether            1500  1598
 2   S en3                                 ether            1500  1598
 3   S en4                                 ether            1500  1598
 4   S en5                                 ether            1500  1598
 5  R  br-local                            bridge           1500  1598
Ups! The filter has no effect!
That happens whenever the variable name ($name) matches the property
name (name=).
And another modification:
{ :local type "en1";
  / interface print where name=$type; }
And the result:
[admin@MikroTik] > { :local type "en1";
{...   / interface print where name=$type; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
Ups! Nothing?
Even if the variable name ($type) matches whatever property name (type=)
things go wrong.
The answer from MikroTik support (in Ticket#2019010222000454):
> This is how scripting works in RouterOS and we will not fix it.
To get around this we use variable names in CamelCase. Let's hope
Mikrotik never ever introduces property names in CamelCase...
*fingers crossed*
		
	
		
			
				
	
	
		
			25 lines
		
	
	
		
			1.1 KiB
		
	
	
	
		
			Plaintext
		
	
	
	
	
	
			
		
		
	
	
			25 lines
		
	
	
		
			1.1 KiB
		
	
	
	
		
			Plaintext
		
	
	
	
	
	
#!rsc
 | 
						|
# RouterOS script: update-gre-address
 | 
						|
# Copyright (c) 2013-2019 Christian Hesse <mail@eworm.de>
 | 
						|
#
 | 
						|
# update gre interface remote address with dynamic address from
 | 
						|
# ipsec remote peer
 | 
						|
 | 
						|
/ interface gre set remote-address=0.0.0.0 disabled=yes [ find where !running !disabled ];
 | 
						|
 | 
						|
:foreach Peer in=[ / ip ipsec remote-peers find ] do={
 | 
						|
  :local Id [ / ip ipsec remote-peers get $Peer id ];
 | 
						|
  :local GreInt [ / interface gre find where comment=$Id ];
 | 
						|
  :if ([ :len $GreInt ] > 0) do={
 | 
						|
    :local GreName [ / interface gre get $GreInt name ];
 | 
						|
    :local AddrOld [ / interface gre get $GreInt remote-address ];
 | 
						|
    :local Disabled [ / interface gre get $GreInt disabled ];
 | 
						|
    :local AddrNew [ / ip ipsec remote-peers get $Peer dynamic-address ];
 | 
						|
    :if ($AddrNew != $AddrOld || $Disabled = true) do={
 | 
						|
      :log info ("Update remote address for interface " . $GreName . " to " . $AddrNew);
 | 
						|
      / interface gre set remote-address=0.0.0.0 disabled=yes [ find where remote-address=$AddrNew name!=$GreName ];
 | 
						|
      / interface gre set $GreInt remote-address=$AddrNew disabled=no;
 | 
						|
    }
 | 
						|
  }
 | 
						|
}
 |