mirror/gitea
1
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2024-05-11 05:55:29 +00:00
Code Issues Projects Releases Wiki Activity
Files
b56a9f6dedd7c689ff22c8fdd34c5761bbae3fe2
gitea/services
T
History
GiteabotGitHubNanguan Lin
 8b590de186 Fix migration panic due to an empty review comment diff (#28334) (#28362) 
Backport #28334 by @lng2020

Fix #28328 
```
func (p *PullRequestComment) GetDiffHunk() string {
	if p == nil || p.DiffHunk == nil {
		return ""
	}
	return *p.DiffHunk
}
```
This function in the package `go-github` may return an empty diff. When
it's empty, the following code will panic because it access `ss[1]`

https://github.com/go-gitea/gitea/blob/ec1feedbf582b05b6a5e8c59fb2457f25d053ba2/services/migrations/gitea_uploader.go#L861-L867

https://github.com/go-gitea/gitea/blob/ec1feedbf582b05b6a5e8c59fb2457f25d053ba2/modules/git/diff.go#L97-L101

Co-authored-by: Nanguan Lin <[email protected]>
2023-12-05 16:58:15 +08:00
..
actions
Always delete existing scheduled action tasks (#27662) (#27688)
2023-10-19 09:37:20 +02:00
agit
Move notification interface to services layer (#26915)
2023-09-05 18:37:47 +00:00
asymkey
Another round of db.DefaultContext refactor (#27103) (#27262)
2023-09-25 19:24:35 +02:00
attachment
move repository deletion to service layer (#26948)
2023-09-08 04:51:15 +00:00
auth
Unify two factor check (#27915) (#27929)
2023-11-06 18:07:22 +00:00
automerge
Improve queue and logger context (#24924)
2023-05-26 07:31:55 +00:00
context
Another round of db.DefaultContext refactor (#27103) (#27262)
2023-09-25 19:24:35 +02:00
convert
Fix package webhook (#27839) (#27855)
2023-10-31 11:26:28 +01:00
cron
Improve retrying index issues (#27554) (#27634)
2023-10-16 09:55:53 +08:00
externalaccount
More db.DefaultContext refactor (#27265) (#27347)
2023-09-29 13:35:01 +00:00
feed
More db.DefaultContext refactor (#27265) (#27347)
2023-09-29 13:35:01 +00:00
forms
Fix required error for token name (#28267) (#28284)
2023-11-29 23:00:32 +08:00
gitdiff
Fix successful return value for SyncAndGetUserSpecificDiff (#27152)
2023-09-20 22:28:17 +02:00
indexer
Fix missing issue search index update when changing status (#28325) (#28330)
2023-12-03 11:43:17 +00:00
issue
Avoid run change title process when the title is same (#27467) (#27558)
2023-10-10 09:01:46 +02:00
lfs
Bump github.com/golang-jwt/jwt to v5 (#25975)
2023-07-19 09:57:10 +00:00
mailer
Clean up template locale usage (#27856) (#27857)
2023-10-31 17:35:55 +01:00
markup
Move web/api context related testing function into a separate package (#26859)
2023-09-01 11:26:07 +00:00
migrations
Fix migration panic due to an empty review comment diff (#28334) (#28362)
2023-12-05 16:58:15 +08:00
mirror
More db.DefaultContext refactor (#27265) (#27347)
2023-09-29 13:35:01 +00:00
notify
Update status and code index after changing the default branch (#27018)
2023-09-13 04:43:31 +00:00
org
Delete repos of org when purge delete user (#27273) (#27728)
2023-11-01 10:03:12 +08:00
packages
Fix RPM/Debian signature key creation (#28352) (#28353)
2023-12-05 13:42:41 +08:00
pull
Fix poster is not loaded in get default merge message (#27657) (#27666)
2023-10-17 18:20:35 +02:00
release
Fix comment permissions (#28213) (#28216)
2023-11-25 23:43:23 +00:00
repository
Delete repos of org when purge delete user (#27273) (#27728)
2023-11-01 10:03:12 +08:00
secrets
Refactor secrets modification logic (#26873)
2023-09-05 15:21:02 +00:00
task
Fix incorrect ctx usage in defer function (#27740) (#27741)
2023-10-22 14:36:49 +00:00
uinotification
More db.DefaultContext refactor (#27265) (#27347)
2023-09-29 13:35:01 +00:00
user
Remove action runners on user deletion (#27902) (#27908)
2023-11-05 13:20:00 +00:00
webhook
Fix comment permissions (#28213) (#28216)
2023-11-25 23:43:23 +00:00
wiki
Fix incorrect test code for error handling (#27139)
2023-09-20 08:51:36 +08:00