From 00ee5053c7dc5a820cdd63c99301d283bce6ca58 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Runkel?= Date: Fri, 22 Mar 2019 17:30:49 +0100 Subject: [PATCH] Use specific Route53Provider Exception --- octodns/provider/route53.py | 9 +++++++-- tests/test_octodns_provider_route53.py | 4 ++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/octodns/provider/route53.py b/octodns/provider/route53.py index f971397..b645772 100644 --- a/octodns/provider/route53.py +++ b/octodns/provider/route53.py @@ -211,6 +211,10 @@ class _Route53GeoRecord(_Route53Record): self.values) +class Route53ProviderException(Exception): + pass + + class Route53Provider(BaseProvider): ''' AWS Route53 Provider @@ -557,8 +561,9 @@ class Route53Provider(BaseProvider): if (interval in [10, 30]): return interval else: - raise Exception('route53.healthcheck.request_interval ' - 'parameter must be either 10 or 30.') + raise Route53ProviderException( + 'route53.healthcheck.request_interval ' + 'parameter must be either 10 or 30.') def _health_check_equivilent(self, host, path, protocol, port, measure_latency, request_interval, diff --git a/tests/test_octodns_provider_route53.py b/tests/test_octodns_provider_route53.py index 50dbbee..a569f7c 100644 --- a/tests/test_octodns_provider_route53.py +++ b/tests/test_octodns_provider_route53.py @@ -12,7 +12,7 @@ from mock import patch from octodns.record import Create, Delete, Record, Update from octodns.provider.route53 import Route53Provider, _Route53GeoDefault, \ - _Route53GeoRecord, _Route53Record, _octal_replace + _Route53GeoRecord, _Route53Record, _octal_replace, Route53ProviderException from octodns.zone import Zone from helpers import GeoProvider @@ -944,7 +944,7 @@ class TestRoute53Provider(TestCase): } } }) - with self.assertRaises(Exception): + with self.assertRaises(Route53ProviderException): interval = provider._healthcheck_request_interval(record_invalid) def test_create_health_checks_provider_options(self):