From 53c2b8d19434b3049accbd7e3fdc08dddde49bec Mon Sep 17 00:00:00 2001
From: ItsAlex <me@itsalex.fr>
Date: Wed, 15 May 2019 12:30:11 +0200
Subject: [PATCH] fix: prevent digital ocean provider to crash if records type
 is not supported

---
 octodns/provider/digitalocean.py        |  4 ++++
 tests/fixtures/digitalocean-page-1.json | 11 +++++++++++
 2 files changed, 15 insertions(+)

diff --git a/octodns/provider/digitalocean.py b/octodns/provider/digitalocean.py
index 98a78ad..e192543 100644
--- a/octodns/provider/digitalocean.py
+++ b/octodns/provider/digitalocean.py
@@ -223,6 +223,10 @@ class DigitalOceanProvider(BaseProvider):
         values = defaultdict(lambda: defaultdict(list))
         for record in self.zone_records(zone):
             _type = record['type']
+            if _type not in self.SUPPORTS:
+                self.log.warning('populate: skipping unsupported %s record',
+                                 _type)
+                continue
             values[record['name']][record['type']].append(record)
 
         before = len(zone.records)
diff --git a/tests/fixtures/digitalocean-page-1.json b/tests/fixtures/digitalocean-page-1.json
index db231ba..c931411 100644
--- a/tests/fixtures/digitalocean-page-1.json
+++ b/tests/fixtures/digitalocean-page-1.json
@@ -1,5 +1,16 @@
 {
 	"domain_records": [{
+		"id": null,
+		"type": "SOA",
+		"name": "@",
+		"data": null,
+		"priority": null,
+		"port": null,
+		"ttl": null,
+		"weight": null,
+		"flags": null,
+		"tag": null
+	}, {
 		"id": 11189874,
 		"type": "NS",
 		"name": "@",