mirror/github-octodns
1
0
Fork 0
mirror of https://github.com/github/octodns.git synced 2024-05-11 05:55:00 +00:00
Code Issues Releases Activity

Consolidate Dyn monitor comparison logic

Browse Source
This commit is contained in:
Ross McFarland
2018-03-31 13:05:04 -07:00
parent 5372e86e1c
commit 084f1e7c57
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
octodns/provider/dyn.py
View File

@@ -142,6 +142,10 @@ class _CachingDynZone(DynZone):
self.flush_cache()
def _monitor_matches(monitor, host, path):
return monitor.host != host or monitor.path != path
class DynProvider(BaseProvider):
'''
Dynect Managed DNS provider
@@ -474,8 +478,8 @@ class DynProvider(BaseProvider):
continue
# Heh, when pulled from the API host & path live under options, but
# when you create with the constructor they're top-level :-(
if monitor.host != record.healthcheck_host or \
monitor.path != record.healthcheck_path:
if _monitor_matches(monitor, record.healthcheck_host,
record.healthcheck_path):
self.log.info('_extra_changes: health-check mis-match for %s',
label)
extra.append(Update(record, record))
@@ -592,8 +596,8 @@ class DynProvider(BaseProvider):
self.traffic_director_monitors[label] = \
self.traffic_director_monitors[fqdn]
del self.traffic_director_monitors[fqdn]
if monitor.host != record.healthcheck_host or \
monitor.path != record.healthcheck_path:
if _monitor_matches(monitor, record.healthcheck_host,
record.healthcheck_path):
self.log.info('_traffic_director_monitor: updating monitor '
'for %s', label)
monitor.update(record.healthcheck_host,