mirror/github-octodns
1
0
Fork 0
mirror of https://github.com/github/octodns.git synced 2024-05-11 05:55:00 +00:00
Code Issues Releases Activity

Rework supports_warn_or_except to msg and fallback

Browse Source
This commit is contained in:
Ross McFarland
2021-08-18 16:25:13 -07:00
parent 65f0bfc243
commit 08f9ec56a3
3 changed files with 20 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
octodns/provider/base.py
View File

@@ -52,10 +52,11 @@ class BaseProvider(BaseSource):
for record in desired.records:
if record._type == 'PTR' and len(record.values) > 1:
# replace with a single-value copy
self.supports_warn_or_except('does not support multi-value '
'PTR records; will use only {} '
'for {}'.format(record.value,
record.fqdn))
msg = 'multi-value PTR records not supported for {}' \
.format(record.fqdn)
fallback = 'falling back to single value, {}' \
.format(record.value)
self.supports_warn_or_except(msg, fallback)
record = record.copy()
record.values = [record.value]
@@ -78,10 +79,10 @@ class BaseProvider(BaseSource):
'''
return []
def supports_warn_or_except(self, msg):
def supports_warn_or_except(self, msg, fallback):
if self.strict_supports:
raise ProviderException('{}: {}'.format(self.id, msg))
self.log.warning(msg)
self.log.warning('{}; {}'.format(msg, fallback))
def plan(self, desired, processors=[]):
self.log.info('plan: desired=%s', desired.name)