mirror/github-octodns
1
0
Fork 0
mirror of https://github.com/github/octodns.git synced 2024-05-11 05:55:00 +00:00
Code Issues Releases Activity

Avoid double existing_records lookup

Browse Source
This commit is contained in:
Ross McFarland
2020-03-30 07:04:07 -07:00
committed by GitHub
parent f590f201ea
commit 1fb4f4facd
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
octodns/provider/cloudflare.py
View File

@@ -585,13 +585,12 @@ class CloudflareProvider(BaseProvider):
changed_records = {c.record for c in changes} changed_records = {c.record for c in changes}
for desired_record in desired.records: for desired_record in desired.records:
if desired_record not in existing_records: # Will be created existing_record = existing_records.get(desired_record, None)
if existing_record: # Will be created
continue continue
elif desired_record in changed_records: # Already being updated elif desired_record in changed_records: # Already being updated
continue continue
existing_record = existing_records[desired_record]
if (self._record_is_proxied(existing_record) != if (self._record_is_proxied(existing_record) !=
self._record_is_proxied(desired_record)): self._record_is_proxied(desired_record)):
extra_changes.append(Update(existing_record, desired_record)) extra_changes.append(Update(existing_record, desired_record))