From 25615b31966f94a6be9612a597422c806c79be98 Mon Sep 17 00:00:00 2001 From: Ross McFarland Date: Thu, 17 Nov 2022 07:23:07 -0800 Subject: [PATCH] Revert "Zone._remove_record shim removed in favor of long standing Zone.remove_record" This reverts commit 9f22173d307e2d25a8c648f812b7c92e84c2e972. --- CHANGELOG.md | 2 -- octodns/zone.py | 3 +++ tests/test_octodns_zone.py | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5282726..bced33e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,8 +6,6 @@ * Provider, Source, and Processor shims removed, they've been warnings for > 1yr. Everything should be using and referring to provider-specific modules now. - * Zone._remove_record shim removed in favor of long standing - Zone.remove_record #### Stuff diff --git a/octodns/zone.py b/octodns/zone.py index 40cd4a4..ff8252c 100644 --- a/octodns/zone.py +++ b/octodns/zone.py @@ -132,6 +132,9 @@ class Zone(object): self._records[record.name].discard(record) + # TODO: delete this + _remove_record = remove_record + def changes(self, desired, target): self.log.debug('changes: zone=%s, target=%s', self, target) diff --git a/tests/test_octodns_zone.py b/tests/test_octodns_zone.py index ab012fd..86fd689 100644 --- a/tests/test_octodns_zone.py +++ b/tests/test_octodns_zone.py @@ -125,7 +125,7 @@ class TestZone(TestCase): # add a record, delete a record -> [Delete, Create] c = ARecord(before, 'c', {'ttl': 42, 'value': '1.1.1.1'}) after.add_record(c) - after.remove_record(b) + after._remove_record(b) self.assertEqual(after.records, set([a, c])) changes = before.changes(after, target) self.assertEqual(2, len(changes))