From 29bc1f3af3cb68c0c8c851c8169f842e81a749a6 Mon Sep 17 00:00:00 2001 From: Sergei Shmanko Date: Thu, 22 Feb 2018 11:36:25 +0200 Subject: [PATCH] fix logging for update/delete_pcent_threshold --- octodns/provider/base.py | 3 ++- octodns/provider/plan.py | 12 ++++++------ 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/octodns/provider/base.py b/octodns/provider/base.py index 2d4680f..3f8a5b8 100644 --- a/octodns/provider/base.py +++ b/octodns/provider/base.py @@ -17,7 +17,8 @@ class BaseProvider(BaseSource): delete_pcent_threshold=Plan.MAX_SAFE_DELETE_PCENT): super(BaseProvider, self).__init__(id) self.log.debug('__init__: id=%s, apply_disabled=%s, ' - 'update_pcent_threshold=%d, delete_pcent_threshold=%d', + 'update_pcent_threshold=%.2f' + 'delete_pcent_threshold=%.2f', id, apply_disabled, update_pcent_threshold, diff --git a/octodns/provider/plan.py b/octodns/provider/plan.py index 3e86826..9613809 100644 --- a/octodns/provider/plan.py +++ b/octodns/provider/plan.py @@ -60,17 +60,17 @@ class Plan(object): delete_pcent = self.change_counts['Delete'] / existing_record_count if update_pcent > self.update_pcent_threshold: - raise UnsafePlan('Too many updates, {} is over {} percent' + raise UnsafePlan('Too many updates, {:.2f} is over {:.2f} %' '({}/{})'.format( - update_pcent, - self.MAX_SAFE_UPDATE_PCENT * 100, + update_pcent * 100, + self.update_pcent_threshold * 100, self.change_counts['Update'], existing_record_count)) if delete_pcent > self.delete_pcent_threshold: - raise UnsafePlan('Too many deletes, {} is over {} percent' + raise UnsafePlan('Too many deletes, {:.2f} is over {:.2f} %' '({}/{})'.format( - delete_pcent, - self.MAX_SAFE_DELETE_PCENT * 100, + delete_pcent * 100, + self.delete_pcent_threshold * 100, self.change_counts['Delete'], existing_record_count))