From 8095f4560a374724739422eb37fe52a70a806896 Mon Sep 17 00:00:00 2001 From: Peter Dave Hello Date: Mon, 21 Dec 2020 03:29:09 +0800 Subject: [PATCH 1/2] Replace legacy `...` w/ $(...) in .git_hooks_pre-commit --- .git_hooks_pre-commit | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.git_hooks_pre-commit b/.git_hooks_pre-commit index 6b3b02e..e73b892 100755 --- a/.git_hooks_pre-commit +++ b/.git_hooks_pre-commit @@ -2,9 +2,9 @@ set -e -HOOKS=`dirname $0` -GIT=`dirname $HOOKS` -ROOT=`dirname $GIT` +HOOKS=$(dirname $0) +GIT=$(dirname $HOOKS) +ROOT=$(dirname $GIT) . $ROOT/env/bin/activate $ROOT/script/lint From 0fad8fa0d976387878fcd2475be51309717ae0bc Mon Sep 17 00:00:00 2001 From: Peter Dave Hello Date: Mon, 21 Dec 2020 03:32:25 +0800 Subject: [PATCH 2/2] Quote variable to prevent globbing, word splitting in .git_hooks_pre-commit --- .git_hooks_pre-commit | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.git_hooks_pre-commit b/.git_hooks_pre-commit index e73b892..1fb621f 100755 --- a/.git_hooks_pre-commit +++ b/.git_hooks_pre-commit @@ -2,10 +2,10 @@ set -e -HOOKS=$(dirname $0) -GIT=$(dirname $HOOKS) -ROOT=$(dirname $GIT) +HOOKS=$(dirname "$0") +GIT=$(dirname "$HOOKS") +ROOT=$(dirname "$GIT") -. $ROOT/env/bin/activate -$ROOT/script/lint -$ROOT/script/coverage +. "$ROOT/env/bin/activate" +"$ROOT/script/lint" +"$ROOT/script/coverage"