mirror/github-octodns
1
0
Fork 0
mirror of https://github.com/github/octodns.git synced 2024-05-11 05:55:00 +00:00
Code Issues Releases Activity

SSHFP RFC4255 - validate algorithm & fingerprint_type

Browse Source 
- unrecognized wording for invalid values
This commit is contained in:
Ross McFarland
2017-06-23 13:35:04 -07:00
parent 3ce0d71e62
commit 4e3cc6b46a
2 changed files with 41 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
tests/test_octodns_record.py
View File

@@ -1011,7 +1011,7 @@ class TestRecordValidation(TestCase):
'ttl': 600,
'value': v
})
self.assertEquals(['invalid flags "X"'], ctx.exception.reasons)
self.assertEquals(['unrecognized flags "X"'], ctx.exception.reasons)
def test_NS(self):
# doesn't blow up
@@ -1104,6 +1104,20 @@ class TestRecordValidation(TestCase):
})
self.assertEquals(['invalid algorithm "nope"'], ctx.exception.reasons)
# unrecognized algorithm
with self.assertRaises(ValidationError) as ctx:
Record.new(self.zone, '', {
'type': 'SSHFP',
'ttl': 600,
'value': {
'algorithm': 42,
'fingerprint_type': 1,
'fingerprint': 'bf6b6825d2977c511a475bbefb88aad54a92ac73'
}
})
self.assertEquals(['unrecognized algorithm "42"'],
ctx.exception.reasons)
# missing fingerprint_type
with self.assertRaises(ValidationError) as ctx:
Record.new(self.zone, '', {
@@ -1130,6 +1144,20 @@ class TestRecordValidation(TestCase):
self.assertEquals(['invalid fingerprint_type "yeeah"'],
ctx.exception.reasons)
# unrecognized fingerprint_type
with self.assertRaises(ValidationError) as ctx:
Record.new(self.zone, '', {
'type': 'SSHFP',
'ttl': 600,
'value': {
'algorithm': 1,
'fingerprint_type': 42,
'fingerprint': 'bf6b6825d2977c511a475bbefb88aad54a92ac73'
}
})
self.assertEquals(['unrecognized fingerprint_type "42"'],
ctx.exception.reasons)
# missing fingerprint
with self.assertRaises(ValidationError) as ctx:
Record.new(self.zone, '', {