mirror/github-octodns
1
0
Fork 0
mirror of https://github.com/github/octodns.git synced 2024-05-11 05:55:00 +00:00
Code Issues Releases Activity

Keep minimum relevant code in try/except block

Browse Source
This commit is contained in:
Pavan Chandrashekar
2020-03-30 10:41:00 -07:00
parent 72eaf0d3af
commit 5bb2851002
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
octodns/provider/ns1.py
View File

@@ -1130,8 +1130,15 @@ class Ns1Provider(BaseProvider):
def _get_ns1_filters(self, ns1_zone_name): def _get_ns1_filters(self, ns1_zone_name):
ns1_filters = {} ns1_filters = {}
ns1_zone = {}
try: try:
ns1_zone = self._client.zones_retrieve(ns1_zone_name) ns1_zone = self._client.zones_retrieve(ns1_zone_name)
except ResourceException as e:
if e.message != self.ZONE_NOT_FOUND_MESSAGE:
raise
if 'records' in ns1_zone:
for ns1_record in ns1_zone['records']: for ns1_record in ns1_zone['records']:
if ns1_record.get('tier', 1) > 1: if ns1_record.get('tier', 1) > 1:
# Need to get the full record data for geo records # Need to get the full record data for geo records
@@ -1142,9 +1149,7 @@ class Ns1Provider(BaseProvider):
if 'filters' in full_rec: if 'filters' in full_rec:
filter_key = '{}.'.format(ns1_record['domain']) filter_key = '{}.'.format(ns1_record['domain'])
ns1_filters[filter_key] = full_rec['filters'] ns1_filters[filter_key] = full_rec['filters']
except ResourceException as e:
if e.message != self.ZONE_NOT_FOUND_MESSAGE:
raise
return ns1_filters return ns1_filters
def _disabled_flag_in_filters(self, filters, domain): def _disabled_flag_in_filters(self, filters, domain):