From 7f59c476e00837409f55b3242b8821c3e58facc1 Mon Sep 17 00:00:00 2001 From: Ross McFarland Date: Sun, 1 Aug 2021 12:17:29 -0700 Subject: [PATCH] NS1 _apply_Update needs to gc monitors w/existing --- octodns/provider/ns1.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/octodns/provider/ns1.py b/octodns/provider/ns1.py index 6d4f84d..c114199 100644 --- a/octodns/provider/ns1.py +++ b/octodns/provider/ns1.py @@ -1358,7 +1358,9 @@ class Ns1Provider(BaseProvider): params, active_monitor_ids = \ getattr(self, '_params_for_{}'.format(_type))(new) self._client.records_update(zone, domain, _type, **params) - self._monitors_gc(new, active_monitor_ids) + # If we're cleaning up we need to send in the old record since it'd + # have anything that needs cleaning up + self._monitors_gc(change.existing, active_monitor_ids) def _apply_Delete(self, ns1_zone, change): existing = change.existing