From 69cd30a1832c30a998528c4c6549f460ad1ee128 Mon Sep 17 00:00:00 2001
From: Ross McFarland <ross@github.com>
Date: Mon, 6 Jan 2020 09:18:10 -0800
Subject: [PATCH] Coverage for Ns1Provider _data_for_dynamic_A

---
 tests/test_octodns_provider_ns1.py | 136 ++++++++++++++++++++++++++++-
 1 file changed, 135 insertions(+), 1 deletion(-)

diff --git a/tests/test_octodns_provider_ns1.py b/tests/test_octodns_provider_ns1.py
index bc40f8a..a985c13 100644
--- a/tests/test_octodns_provider_ns1.py
+++ b/tests/test_octodns_provider_ns1.py
@@ -13,7 +13,7 @@ from six import text_type
 from unittest import TestCase
 
 from octodns.record import Delete, Record, Update
-from octodns.provider.ns1 import Ns1Client, Ns1Provider
+from octodns.provider.ns1 import Ns1Client, Ns1Exception, Ns1Provider
 from octodns.zone import Zone
 
 
@@ -957,6 +957,140 @@ class TestNs1ProviderDynamic(TestCase):
             call(self.record, '3.4.5.6', 'mid-3'),
         ])
 
+    def test_data_for_dynamic_A(self):
+        provider = Ns1Provider('test', 'api-key')
+
+        # Unexpected filters throws an error
+        ns1_record = {
+            'domain': 'unit.tests',
+            'filters': [],
+        }
+        with self.assertRaises(Ns1Exception) as ctx:
+            provider._data_for_dynamic_A('A', ns1_record)
+        self.assertEquals('Unrecognized advanced record',
+                          text_type(ctx.exception))
+
+        # empty record turns into empty data
+        ns1_record = {
+            'answers': [],
+            'domain': 'unit.tests',
+            'filters': Ns1Provider._DYNAMIC_FILTERS,
+            'regions': {},
+            'ttl': 42,
+        }
+        data = provider._data_for_dynamic_A('A', ns1_record)
+        self.assertEquals({
+            'dynamic': {
+                'pools': {},
+                'rules': [],
+            },
+            'ttl': 42,
+            'type': 'A',
+            'values': [],
+        }, data)
+
+        # Test out a small, but realistic setup that covers all the options
+        ns1_record = {
+            'answers': [{
+                'answer': ['3.4.5.6'],
+                'meta': {
+                    'priority': 1,
+                    'note': 'from:lhr',
+                },
+                'region': 'lhr',
+            }, {
+                'answer': ['2.3.4.5'],
+                'meta': {
+                    'priority': 2,
+                    'weight': 12,
+                    'note': 'from:iad',
+                },
+                'region': 'lhr',
+            }, {
+                'answer': ['1.2.3.4'],
+                'meta': {
+                    'priority': 3,
+                    'note': 'from:--default--',
+                },
+                'region': 'lhr',
+            }, {
+                'answer': ['2.3.4.5'],
+                'meta': {
+                    'priority': 1,
+                    'weight': 12,
+                    'note': 'from:iad',
+                },
+                'region': 'iad',
+            }, {
+                'answer': ['1.2.3.4'],
+                'meta': {
+                    'priority': 2,
+                    'note': 'from:--default--',
+                },
+                'region': 'iad',
+            }],
+            'domain': 'unit.tests',
+            'filters': Ns1Provider._DYNAMIC_FILTERS,
+            'regions': {
+                'lhr': {
+                    'meta': {
+                        'note': 'rule-order:1 fallback:iad',
+                        'country': ['CA'],
+                        'georegion': ['AFRICA'],
+                        'us_state': ['OR'],
+                    },
+                },
+                'iad': {
+                    'meta': {
+                        'note': 'rule-order:2',
+                    },
+                }
+            },
+            'tier': 3,
+            'ttl': 42,
+        }
+        data = provider._data_for_dynamic_A('A', ns1_record)
+        self.assertEquals({
+            'dynamic': {
+                'pools': {
+                    'iad': {
+                        'fallback': None,
+                        'values': [{
+                            'value': '2.3.4.5',
+                            'weight': 12,
+                        }],
+                    },
+                    'lhr': {
+                        'fallback': 'iad',
+                        'values': [{
+                            'weight': 1,
+                            'value': '3.4.5.6',
+                        }],
+                    },
+                },
+                'rules': [{
+                    '_order': '1',
+                    'geos': [
+                        'AF',
+                        'NA-CA',
+                        'NA-US-OR',
+                    ],
+                    'pool': 'lhr',
+                }, {
+                    '_order': '2',
+                    'pool': 'iad',
+                }],
+            },
+            'ttl': 42,
+            'type': 'A',
+            'values': ['1.2.3.4'],
+        }, data)
+
+        # Same answer if we go through _data_for_A which out sources the job to
+        # _data_for_dynamic_A
+        data2 = provider._data_for_A('A', ns1_record)
+        self.assertEquals(data, data2)
+
 
 class TestNs1Client(TestCase):