mirror/github-octodns
1
0
Fork 0
mirror of https://github.com/github/octodns.git synced 2024-05-11 05:55:00 +00:00
Code Issues Releases Activity

Merge pull request #827 from octodns/at-sign-name-validation

Browse Source 
Add a validation to catch name=@ and suggest name='' instead
This commit is contained in:
Ross McFarland
2022-01-01 13:58:35 -08:00
committed by GitHub
parent 9da19749e2 d280e0850c
commit 75a01b2481
2 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
octodns/record/__init__.py
View File

@@ -124,6 +124,8 @@ class Record(EqualityTupleMixin):
@classmethod @classmethod
def validate(cls, name, fqdn, data): def validate(cls, name, fqdn, data):
reasons = [] reasons = []
if name == '@':
reasons.append('invalid name "@", use "" instead')
n = len(fqdn) n = len(fqdn)
if n > 253: if n > 253:
reasons.append(f'invalid fqdn, "{fqdn}" is too long at {n} ' reasons.append(f'invalid fqdn, "{fqdn}" is too long at {n} '

11
tests/test_octodns_record.py
View File

@@ -1643,6 +1643,17 @@ class TestRecordValidation(TestCase):
zone = Zone('unit.tests.', []) zone = Zone('unit.tests.', [])
def test_base(self): def test_base(self):
# name = '@'
with self.assertRaises(ValidationError) as ctx:
name = '@'
Record.new(self.zone, name, {
'ttl': 300,
'type': 'A',
'value': '1.2.3.4',
})
reason = ctx.exception.reasons[0]
self.assertTrue(reason.startswith('invalid name "@", use "" instead'))
# fqdn length, DNS defins max as 253 # fqdn length, DNS defins max as 253
with self.assertRaises(ValidationError) as ctx: with self.assertRaises(ValidationError) as ctx:
# The . will put this over the edge # The . will put this over the edge