From 7cd98591f4e7cbf139ba6a35f5cb5d55fe6379d0 Mon Sep 17 00:00:00 2001 From: Viranch Mehta Date: Fri, 22 Oct 2021 13:13:05 -0700 Subject: [PATCH] Add warn for unparsable dynamic records --- octodns/provider/ns1.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/octodns/provider/ns1.py b/octodns/provider/ns1.py index ba68bfd..d259f93 100644 --- a/octodns/provider/ns1.py +++ b/octodns/provider/ns1.py @@ -780,11 +780,15 @@ class Ns1Provider(BaseProvider): if 'pool:' in first_answer_note: return self._data_for_dynamic(_type, record) # If not, it can't be parsed. Let it be an empty record - - try: - value = record['short_answers'][0] - except (IndexError, KeyError): + self.log.warn('Cannot parse %s dynamic record due to missing ' + 'pool name in first answer note, treating it as ' + 'an empty record', record['domain']) value = None + else: + try: + value = record['short_answers'][0] + except IndexError: + value = None return { 'ttl': record['ttl'],