mirror of
https://github.com/github/octodns.git
synced 2024-05-11 05:55:00 +00:00
Apply suggestions/corrections from a round of code review
This commit is contained in:
@@ -5,16 +5,13 @@
|
||||
* Foundational support for root NS record management.
|
||||
* YamlProvider has it enabled and in general everyone should add root NS
|
||||
records that match what is in their provider(s) as of this release if they
|
||||
an're already there.
|
||||
aren't already there.
|
||||
* Note that if you created you config files with `octodns-dump` the records
|
||||
are likely already there and match what was configured at the time of the
|
||||
dump.
|
||||
* Other providers will add root NS support over time once they have had the
|
||||
chance to investigate the functionality and implement management if
|
||||
possible with whatever accomidations are required.
|
||||
* Once you are using this release and an provider version that supports root
|
||||
NS management you will get errors if you do not have root NS records
|
||||
included by your source(s).
|
||||
* Watch your providers README.md and CHANGELOG.md for support and more
|
||||
information.
|
||||
|
||||
|
@@ -99,9 +99,9 @@ class Plan(object):
|
||||
|
||||
# If we have any changes of the root NS record for the zone it's a huge
|
||||
# deal and force should always be required for extra care
|
||||
if self.exists and [True for c in self.changes
|
||||
if self.exists and any(c for c in self.changes
|
||||
if c.record and c.record._type == 'NS' and
|
||||
c.record.name == '']:
|
||||
c.record.name == ''):
|
||||
raise RootNsChange()
|
||||
|
||||
def __repr__(self):
|
||||
|
Reference in New Issue
Block a user