mirror/github-octodns
1
0
Fork 0
mirror of https://github.com/github/octodns.git synced 2024-05-11 05:55:00 +00:00
Code Issues Releases Activity

Refactor shell script syntax and consistency

Browse Source 
- Add a missing space for styling
- Replace legacy "\`...\`" with `$(...)`
- Quote variable to prevent word splitting
- Use builtin `command -v` instead of non-standard `which`
- Add two missing `>&2` redirection for error/warning message
This commit is contained in:
Peter Dave Hello
2019-04-13 22:04:04 +08:00
parent a0bd756c09
commit a516f2ca7c
4 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
script/coverage
+3 -3
View File
@@ -26,11 +26,11 @@ export DYN_PASSWORD=
export DYN_USERNAME=
export GOOGLE_APPLICATION_CREDENTIALS=
coverage run --branch --source=octodns --omit=octodns/cmds/* `which nosetests` --with-xunit "$@"
coverage run --branch --source=octodns --omit=octodns/cmds/* "$(command -v nosetests)" --with-xunit "$@"
coverage html
coverage xml
coverage report
coverage report | grep ^TOTAL| grep -qv 100% && {
echo "Incomplete code coverage"
coverage report | grep ^TOTAL | grep -qv 100% && {
echo "Incomplete code coverage" >&2
exit 1
} || echo "Code coverage 100%"