mirror/github-octodns
1
0
Fork 0
mirror of https://github.com/github/octodns.git synced 2024-05-11 05:55:00 +00:00
Code Issues Releases Activity

Refactor GoogleCloudProvider

Browse Source 
* in _rrset_for_X functions, use values instead of data attribute.
* Small typo fixes and removals of redundant steps etc.
* Unset GOOGLE_APPLICATION_CREDENTIALS in coverage script.
This commit is contained in:
Petter Hassberg
2017-10-07 16:13:11 +02:00
parent 8230700ad1
commit aabab63003
3 changed files with 26 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/test_octodns_provider_googlecloud.py
View File

@@ -313,8 +313,11 @@ class TestGoogleCloudProvider(TestCase):
if not page_token:
return DummyIterator([
DummyGoogleCloudZone('example.com.'),
], page_token="MOCK_PAGE_TOKEN")
elif page_token == "MOCK_PAGE_TOKEN":
return DummyIterator([
DummyGoogleCloudZone('example2.com.'),
], page_token="DUMMY_PAGE_TOKEN")
], page_token="MOCK_PAGE_TOKEN2")
return DummyIterator([
google_cloud_zone
@@ -324,7 +327,12 @@ class TestGoogleCloudProvider(TestCase):
if not page_token:
return DummyIterator(
[DummyResourceRecordSet(*v) for v in
resource_record_sets[:5]], page_token="DUMMY_PAGE_TOKEN")
resource_record_sets[:3]], page_token="MOCK_PAGE_TOKEN")
elif page_token == "MOCK_PAGE_TOKEN":
return DummyIterator(
[DummyResourceRecordSet(*v) for v in
resource_record_sets[3:5]], page_token="MOCK_PAGE_TOKEN2")
return DummyIterator(
[DummyResourceRecordSet(*v) for v in resource_record_sets[5:]])