mirror/github-octodns
1
0
Fork 0
mirror of https://github.com/github/octodns.git synced 2024-05-11 05:55:00 +00:00
Code Issues Releases Activity

Merge branch 'master' into azuredns-dynamic

Browse Source
This commit is contained in:
Ross McFarland
2021-05-17 17:26:29 -07:00
committed by GitHub
parent cca288faa6 12cd49d0af
commit abef3202a0
2 changed files with 32 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
octodns/record/__init__.py
View File

@@ -583,6 +583,10 @@ class _DynamicMixin(object):
reasons.append('missing value in pool "{}" '
'value {}'.format(_id, value_num))
if len(values) == 1 and values[0].get('weight', 1) != 1:
reasons.append('pool "{}" has single value with '
'weight!=1'.format(_id))
fallback = pool.get('fallback', None)
if fallback is not None:
if fallback in pools:

29
tests/test_octodns_record.py
View File

@@ -3413,7 +3413,7 @@ class TestDynamicRecords(TestCase):
self.assertEquals(['pool "one" is missing values'],
ctx.exception.reasons)
# pool valu not a dict
# pool value not a dict
a_data = {
'dynamic': {
'pools': {
@@ -3597,6 +3597,33 @@ class TestDynamicRecords(TestCase):
self.assertEquals(['invalid weight "foo" in pool "three" value 2'],
ctx.exception.reasons)
# single value with weight!=1
a_data = {
'dynamic': {
'pools': {
'one': {
'values': [{
'weight': 12,
'value': '6.6.6.6',
}],
},
},
'rules': [{
'pool': 'one',
}],
},
'ttl': 60,
'type': 'A',
'values': [
'1.1.1.1',
'2.2.2.2',
],
}
with self.assertRaises(ValidationError) as ctx:
Record.new(self.zone, 'bad', a_data)
self.assertEquals(['pool "one" has single value with weight!=1'],
ctx.exception.reasons)
# invalid fallback
a_data = {
'dynamic': {