\n | Summary: ')
diff --git a/octodns/provider/powerdns.py b/octodns/provider/powerdns.py
index aafb64e..f6f218e 100644
--- a/octodns/provider/powerdns.py
+++ b/octodns/provider/powerdns.py
@@ -187,8 +187,10 @@ class PowerDnsBaseProvider(BaseProvider):
raise
before = len(zone.records)
+ exists = False
if resp:
+ exists = True
for rrset in resp.json()['rrsets']:
_type = rrset['type']
if _type == 'SOA':
@@ -199,8 +201,9 @@ class PowerDnsBaseProvider(BaseProvider):
source=self, lenient=lenient)
zone.add_record(record)
- self.log.info('populate: found %s records',
- len(zone.records) - before)
+ self.log.info('populate: found %s records, exists=%s',
+ len(zone.records) - before, exists)
+ return exists
def _records_for_multiple(self, record):
return [{'content': v, 'disabled': False}
diff --git a/octodns/provider/rackspace.py b/octodns/provider/rackspace.py
index e370315..35e27dc 100644
--- a/octodns/provider/rackspace.py
+++ b/octodns/provider/rackspace.py
@@ -200,7 +200,7 @@ class RackspaceProvider(BaseProvider):
raise Exception('Rackspace request unauthorized')
elif e.response.status_code == 404:
# Zone not found leaves the zone empty instead of failing.
- return
+ return False
raise
before = len(zone.records)
@@ -217,8 +217,9 @@ class RackspaceProvider(BaseProvider):
source=self)
zone.add_record(record)
- self.log.info('populate: found %s records',
+ self.log.info('populate: found %s records, exists=True',
len(zone.records) - before)
+ return True
def _group_records(self, all_records):
records = defaultdict(lambda: defaultdict(list))
diff --git a/octodns/provider/route53.py b/octodns/provider/route53.py
index cf9c3c4..3333f4e 100644
--- a/octodns/provider/route53.py
+++ b/octodns/provider/route53.py
@@ -451,9 +451,11 @@ class Route53Provider(BaseProvider):
target, lenient)
before = len(zone.records)
+ exists = False
zone_id = self._get_zone_id(zone.name)
if zone_id:
+ exists = True
records = defaultdict(lambda: defaultdict(list))
for rrset in self._load_records(zone_id):
record_name = zone.hostname_from_fqdn(rrset['Name'])
@@ -483,8 +485,9 @@ class Route53Provider(BaseProvider):
lenient=lenient)
zone.add_record(record)
- self.log.info('populate: found %s records',
- len(zone.records) - before)
+ self.log.info('populate: found %s records, exists=%s',
+ len(zone.records) - before, exists)
+ return exists
def _gen_mods(self, action, records):
'''
diff --git a/octodns/provider/yaml.py b/octodns/provider/yaml.py
index 752e793..0241d50 100644
--- a/octodns/provider/yaml.py
+++ b/octodns/provider/yaml.py
@@ -52,7 +52,7 @@ class YamlProvider(BaseProvider):
if target:
# When acting as a target we ignore any existing records so that we
# create a completely new copy
- return
+ return False
before = len(zone.records)
filename = join(self.directory, '{}yaml'.format(zone.name))
@@ -69,8 +69,9 @@ class YamlProvider(BaseProvider):
lenient=lenient)
zone.add_record(record)
- self.log.info('populate: found %s records',
+ self.log.info('populate: found %s records, exists=False',
len(zone.records) - before)
+ return False
def _apply(self, plan):
desired = plan.desired
diff --git a/octodns/source/base.py b/octodns/source/base.py
index 15455b8..ee33619 100644
--- a/octodns/source/base.py
+++ b/octodns/source/base.py
@@ -22,7 +22,7 @@ class BaseSource(object):
def populate(self, zone, target=False, lenient=False):
'''
- Loads all zones the provider knows about
+ Loads all records the provider knows about for the provided zone
When `target` is True the populate call is being made to load the
current state of the provider.
@@ -30,7 +30,10 @@ class BaseSource(object):
When `lenient` is True the populate call may skip record validation and
do a "best effort" load of data. That will allow through some common,
but not best practices stuff that we otherwise would reject. E.g. no
- trailing . or missing escapes for ;.
+ trailing . or mising escapes for ;.
+
+ When target is True (loading current state) this method should return
+ True if the zone exists or False if it does not.
'''
raise NotImplementedError('Abstract base class, populate method '
'missing')
diff --git a/tests/test_octodns_plan.py b/tests/test_octodns_plan.py
index ea35243..7d849be 100644
--- a/tests/test_octodns_plan.py
+++ b/tests/test_octodns_plan.py
@@ -16,15 +16,6 @@ from octodns.zone import Zone
from helpers import SimpleProvider
-class TestPlanLogger(TestCase):
-
- def test_invalid_level(self):
- with self.assertRaises(Exception) as ctx:
- PlanLogger('invalid', 'not-a-level')
- self.assertEquals('Unsupported level: not-a-level',
- ctx.exception.message)
-
-
simple = SimpleProvider()
zone = Zone('unit.tests.', [])
existing = Record.new(zone, 'a', {
@@ -48,15 +39,45 @@ create = Create(Record.new(zone, 'b', {
'type': 'CNAME',
'value': 'foo.unit.tests.'
}, simple))
+create2 = Create(Record.new(zone, 'c', {
+ 'ttl': 60,
+ 'type': 'CNAME',
+ 'value': 'foo.unit.tests.'
+}))
update = Update(existing, new)
delete = Delete(new)
-changes = [create, delete, update]
+changes = [create, create2, delete, update]
plans = [
- (simple, Plan(zone, zone, changes)),
- (simple, Plan(zone, zone, changes)),
+ (simple, Plan(zone, zone, changes, True)),
+ (simple, Plan(zone, zone, changes, False)),
]
+class TestPlanLogger(TestCase):
+
+ def test_invalid_level(self):
+ with self.assertRaises(Exception) as ctx:
+ PlanLogger('invalid', 'not-a-level')
+ self.assertEquals('Unsupported level: not-a-level',
+ ctx.exception.message)
+
+ def test_create(self):
+
+ class MockLogger(object):
+
+ def __init__(self):
+ self.out = StringIO()
+
+ def log(self, level, msg):
+ self.out.write(msg)
+
+ log = MockLogger()
+ PlanLogger('logger').run(log, plans)
+ out = log.out.getvalue()
+ self.assertTrue('Summary: Creates=2, Updates=1, '
+ 'Deletes=1, Existing Records=0' in out)
+
+
class TestPlanHtml(TestCase):
log = getLogger('TestPlanHtml')
@@ -69,7 +90,7 @@ class TestPlanHtml(TestCase):
out = StringIO()
PlanHtml('html').run(plans, fh=out)
out = out.getvalue()
- self.assertTrue(' | Summary: Creates=1, Updates=1, '
+ self.assertTrue(' | Summary: Creates=2, Updates=1, '
'Deletes=1, Existing Records=0 | ' in out)
diff --git a/tests/test_octodns_provider_azuredns.py b/tests/test_octodns_provider_azuredns.py
index 598fe48..9784945 100644
--- a/tests/test_octodns_provider_azuredns.py
+++ b/tests/test_octodns_provider_azuredns.py
@@ -302,7 +302,8 @@ class TestAzureDnsProvider(TestCase):
record_list = provider._dns_client.record_sets.list_by_dns_zone
record_list.return_value = rs
- provider.populate(zone)
+ exists = provider.populate(zone)
+ self.assertTrue(exists)
self.assertEquals(len(zone.records), 16)
@@ -338,8 +339,10 @@ class TestAzureDnsProvider(TestCase):
changes.append(Create(i))
deletes.append(Delete(i))
- self.assertEquals(13, provider.apply(Plan(None, zone, changes)))
- self.assertEquals(13, provider.apply(Plan(zone, zone, deletes)))
+ self.assertEquals(13, provider.apply(Plan(None, zone,
+ changes, True)))
+ self.assertEquals(13, provider.apply(Plan(zone, zone,
+ deletes, True)))
def test_create_zone(self):
provider = self._get_provider()
@@ -354,7 +357,8 @@ class TestAzureDnsProvider(TestCase):
_get = provider._dns_client.zones.get
_get.side_effect = CloudError(Mock(status=404), err_msg)
- self.assertEquals(13, provider.apply(Plan(None, desired, changes)))
+ self.assertEquals(13, provider.apply(Plan(None, desired, changes,
+ True)))
def test_check_zone_no_create(self):
provider = self._get_provider()
@@ -374,6 +378,7 @@ class TestAzureDnsProvider(TestCase):
_get = provider._dns_client.zones.get
_get.side_effect = CloudError(Mock(status=404), err_msg)
- provider.populate(Zone('unit3.test.', []))
+ exists = provider.populate(Zone('unit3.test.', []))
+ self.assertFalse(exists)
self.assertEquals(len(zone.records), 0)
diff --git a/tests/test_octodns_provider_base.py b/tests/test_octodns_provider_base.py
index 22544e1..64c0377 100644
--- a/tests/test_octodns_provider_base.py
+++ b/tests/test_octodns_provider_base.py
@@ -153,7 +153,7 @@ class TestBaseProvider(TestCase):
def test_safe_none(self):
# No changes is safe
- Plan(None, None, []).raise_if_unsafe()
+ Plan(None, None, [], True).raise_if_unsafe()
def test_safe_creates(self):
# Creates are safe when existing records is under MIN_EXISTING_RECORDS
@@ -164,7 +164,8 @@ class TestBaseProvider(TestCase):
'type': 'A',
'value': '1.2.3.4',
})
- Plan(zone, zone, [Create(record) for i in range(10)]).raise_if_unsafe()
+ Plan(zone, zone, [Create(record) for i in range(10)], True) \
+ .raise_if_unsafe()
def test_safe_min_existing_creates(self):
# Creates are safe when existing records is over MIN_EXISTING_RECORDS
@@ -183,7 +184,8 @@ class TestBaseProvider(TestCase):
'value': '2.3.4.5'
}))
- Plan(zone, zone, [Create(record) for i in range(10)]).raise_if_unsafe()
+ Plan(zone, zone, [Create(record) for i in range(10)], True) \
+ .raise_if_unsafe()
def test_safe_no_existing(self):
# existing records fewer than MIN_EXISTING_RECORDS is safe
@@ -195,7 +197,7 @@ class TestBaseProvider(TestCase):
})
updates = [Update(record, record), Update(record, record)]
- Plan(zone, zone, updates).raise_if_unsafe()
+ Plan(zone, zone, updates, True).raise_if_unsafe()
def test_safe_updates_min_existing(self):
# MAX_SAFE_UPDATE_PCENT+1 fails when more
@@ -219,7 +221,7 @@ class TestBaseProvider(TestCase):
Plan.MAX_SAFE_UPDATE_PCENT) + 1)]
with self.assertRaises(UnsafePlan) as ctx:
- Plan(zone, zone, changes).raise_if_unsafe()
+ Plan(zone, zone, changes, True).raise_if_unsafe()
self.assertTrue('Too many updates' in ctx.exception.message)
@@ -243,7 +245,7 @@ class TestBaseProvider(TestCase):
for i in range(int(Plan.MIN_EXISTING_RECORDS *
Plan.MAX_SAFE_UPDATE_PCENT))]
- Plan(zone, zone, changes).raise_if_unsafe()
+ Plan(zone, zone, changes, True).raise_if_unsafe()
def test_safe_deletes_min_existing(self):
# MAX_SAFE_DELETE_PCENT+1 fails when more
@@ -267,7 +269,7 @@ class TestBaseProvider(TestCase):
Plan.MAX_SAFE_DELETE_PCENT) + 1)]
with self.assertRaises(UnsafePlan) as ctx:
- Plan(zone, zone, changes).raise_if_unsafe()
+ Plan(zone, zone, changes, True).raise_if_unsafe()
self.assertTrue('Too many deletes' in ctx.exception.message)
@@ -291,7 +293,7 @@ class TestBaseProvider(TestCase):
for i in range(int(Plan.MIN_EXISTING_RECORDS *
Plan.MAX_SAFE_DELETE_PCENT))]
- Plan(zone, zone, changes).raise_if_unsafe()
+ Plan(zone, zone, changes, True).raise_if_unsafe()
def test_safe_updates_min_existing_override(self):
safe_pcent = .4
@@ -316,7 +318,7 @@ class TestBaseProvider(TestCase):
safe_pcent) + 1)]
with self.assertRaises(UnsafePlan) as ctx:
- Plan(zone, zone, changes,
+ Plan(zone, zone, changes, True,
update_pcent_threshold=safe_pcent).raise_if_unsafe()
self.assertTrue('Too many updates' in ctx.exception.message)
@@ -344,7 +346,7 @@ class TestBaseProvider(TestCase):
safe_pcent) + 1)]
with self.assertRaises(UnsafePlan) as ctx:
- Plan(zone, zone, changes,
+ Plan(zone, zone, changes, True,
delete_pcent_threshold=safe_pcent).raise_if_unsafe()
self.assertTrue('Too many deletes' in ctx.exception.message)
diff --git a/tests/test_octodns_provider_cloudflare.py b/tests/test_octodns_provider_cloudflare.py
index 36a6d35..7462b9f 100644
--- a/tests/test_octodns_provider_cloudflare.py
+++ b/tests/test_octodns_provider_cloudflare.py
@@ -166,6 +166,7 @@ class TestCloudflareProvider(TestCase):
plan = provider.plan(self.expected)
self.assertEquals(12, len(plan.changes))
self.assertEquals(12, provider.apply(plan))
+ self.assertFalse(plan.exists)
provider._request.assert_has_calls([
# created the domain
@@ -285,6 +286,7 @@ class TestCloudflareProvider(TestCase):
# only see the delete & ttl update, below min-ttl is filtered out
self.assertEquals(2, len(plan.changes))
self.assertEquals(2, provider.apply(plan))
+ self.assertTrue(plan.exists)
# recreate for update, and deletes for the 2 parts of the other
provider._request.assert_has_calls([
call('PUT', '/zones/ff12ab34cd5611334422ab3322997650/dns_records/'
@@ -366,7 +368,7 @@ class TestCloudflareProvider(TestCase):
'values': ['2.2.2.2', '3.3.3.3', '4.4.4.4'],
})
change = Update(existing, new)
- plan = Plan(zone, zone, [change])
+ plan = Plan(zone, zone, [change], True)
provider._apply(plan)
provider._request.assert_has_calls([
@@ -451,7 +453,7 @@ class TestCloudflareProvider(TestCase):
'value': 'ns2.foo.bar.',
})
change = Update(existing, new)
- plan = Plan(zone, zone, [change])
+ plan = Plan(zone, zone, [change], True)
provider._apply(plan)
provider._request.assert_has_calls([
diff --git a/tests/test_octodns_provider_digitalocean.py b/tests/test_octodns_provider_digitalocean.py
index 5fb47c5..ddc6bc2 100644
--- a/tests/test_octodns_provider_digitalocean.py
+++ b/tests/test_octodns_provider_digitalocean.py
@@ -165,6 +165,7 @@ class TestDigitalOceanProvider(TestCase):
n = len(self.expected.records) - 7
self.assertEquals(n, len(plan.changes))
self.assertEquals(n, provider.apply(plan))
+ self.assertFalse(plan.exists)
provider._client._request.assert_has_calls([
# created the domain
@@ -225,6 +226,7 @@ class TestDigitalOceanProvider(TestCase):
}))
plan = provider.plan(wanted)
+ self.assertTrue(plan.exists)
self.assertEquals(2, len(plan.changes))
self.assertEquals(2, provider.apply(plan))
# recreate for update, and delete for the 2 parts of the other
diff --git a/tests/test_octodns_provider_dnsimple.py b/tests/test_octodns_provider_dnsimple.py
index 60dacf1..896425e 100644
--- a/tests/test_octodns_provider_dnsimple.py
+++ b/tests/test_octodns_provider_dnsimple.py
@@ -133,6 +133,7 @@ class TestDnsimpleProvider(TestCase):
n = len(self.expected.records) - 3
self.assertEquals(n, len(plan.changes))
self.assertEquals(n, provider.apply(plan))
+ self.assertFalse(plan.exists)
provider._client._request.assert_has_calls([
# created the domain
@@ -186,6 +187,7 @@ class TestDnsimpleProvider(TestCase):
}))
plan = provider.plan(wanted)
+ self.assertTrue(plan.exists)
self.assertEquals(2, len(plan.changes))
self.assertEquals(2, provider.apply(plan))
# recreate for update, and deletes for the 2 parts of the other
diff --git a/tests/test_octodns_provider_dyn.py b/tests/test_octodns_provider_dyn.py
index d1be606..85de59c 100644
--- a/tests/test_octodns_provider_dyn.py
+++ b/tests/test_octodns_provider_dyn.py
@@ -430,6 +430,7 @@ class TestDynProvider(TestCase):
update_mock.assert_not_called()
provider.apply(plan)
update_mock.assert_called()
+ self.assertFalse(plan.exists)
add_mock.assert_called()
# Once for each dyn record (8 Records, 2 of which have dual values)
self.assertEquals(15, len(add_mock.call_args_list))
@@ -474,6 +475,7 @@ class TestDynProvider(TestCase):
plan = provider.plan(new)
provider.apply(plan)
update_mock.assert_called()
+ self.assertTrue(plan.exists)
# we expect 4 deletes, 2 from actual deletes and 2 from
# updates which delete and recreate
self.assertEquals(4, len(delete_mock.call_args_list))
@@ -913,7 +915,7 @@ class TestDynProviderGeo(TestCase):
Delete(geo),
Delete(regular),
]
- plan = Plan(None, desired, changes)
+ plan = Plan(None, desired, changes, True)
provider._apply(plan)
mock.assert_has_calls([
call('/Zone/unit.tests/', 'GET', {}),
diff --git a/tests/test_octodns_provider_googlecloud.py b/tests/test_octodns_provider_googlecloud.py
index 127cb53..82bc83f 100644
--- a/tests/test_octodns_provider_googlecloud.py
+++ b/tests/test_octodns_provider_googlecloud.py
@@ -263,7 +263,8 @@ class TestGoogleCloudProvider(TestCase):
provider.apply(Plan(
existing=[update_existing_r, delete_r],
desired=desired,
- changes=changes
+ changes=changes,
+ exists=True
))
calls_mock = gcloud_zone_mock.changes.return_value
@@ -295,7 +296,8 @@ class TestGoogleCloudProvider(TestCase):
provider.apply(Plan(
existing=[update_existing_r, delete_r],
desired=desired,
- changes=changes
+ changes=changes,
+ exists=True
))
unsupported_change = Mock()
@@ -357,7 +359,8 @@ class TestGoogleCloudProvider(TestCase):
"unit.tests.")
test_zone = Zone('unit.tests.', [])
- provider.populate(test_zone)
+ exists = provider.populate(test_zone)
+ self.assertTrue(exists)
# test_zone gets fed the same records as zone does, except it's in
# the format returned by google API, so after populate they should look
@@ -365,7 +368,8 @@ class TestGoogleCloudProvider(TestCase):
self.assertEqual(test_zone.records, zone.records)
test_zone2 = Zone('nonexistent.zone.', [])
- provider.populate(test_zone2, False, False)
+ exists = provider.populate(test_zone2, False, False)
+ self.assertFalse(exists)
self.assertEqual(len(test_zone2.records), 0,
msg="Zone should not get records from wrong domain")
diff --git a/tests/test_octodns_provider_ns1.py b/tests/test_octodns_provider_ns1.py
index 0e3a286..fa6cf2d 100644
--- a/tests/test_octodns_provider_ns1.py
+++ b/tests/test_octodns_provider_ns1.py
@@ -196,9 +196,10 @@ class TestNs1Provider(TestCase):
load_mock.side_effect = \
ResourceException('server error: zone not found')
zone = Zone('unit.tests.', [])
- provider.populate(zone)
+ exists = provider.populate(zone)
self.assertEquals(set(), zone.records)
self.assertEquals(('unit.tests',), load_mock.call_args[0])
+ self.assertFalse(exists)
# Existing zone w/o records
load_mock.reset_mock()
@@ -269,6 +270,7 @@ class TestNs1Provider(TestCase):
# everything except the root NS
expected_n = len(self.expected) - 1
self.assertEquals(expected_n, len(plan.changes))
+ self.assertTrue(plan.exists)
# Fails, general error
load_mock.reset_mock()
diff --git a/tests/test_octodns_provider_ovh.py b/tests/test_octodns_provider_ovh.py
index 3e7affe..5a62094 100644
--- a/tests/test_octodns_provider_ovh.py
+++ b/tests/test_octodns_provider_ovh.py
@@ -8,7 +8,7 @@ from __future__ import absolute_import, division, print_function, \
from unittest import TestCase
from mock import patch, call
-from ovh import APIError
+from ovh import APIError, ResourceNotFoundError, InvalidCredential
from octodns.provider.ovh import OvhProvider
from octodns.record import Record
@@ -307,18 +307,30 @@ class TestOvhProvider(TestCase):
with patch.object(provider._client, 'get') as get_mock:
zone = Zone('unit.tests.', [])
- get_mock.side_effect = APIError('boom')
+ get_mock.side_effect = ResourceNotFoundError('boom')
with self.assertRaises(APIError) as ctx:
provider.populate(zone)
self.assertEquals(get_mock.side_effect, ctx.exception)
- with patch.object(provider._client, 'get') as get_mock:
+ get_mock.side_effect = InvalidCredential('boom')
+ with self.assertRaises(APIError) as ctx:
+ provider.populate(zone)
+ self.assertEquals(get_mock.side_effect, ctx.exception)
+
+ zone = Zone('unit.tests.', [])
+ get_mock.side_effect = ResourceNotFoundError('This service does '
+ 'not exist')
+ exists = provider.populate(zone)
+ self.assertEquals(set(), zone.records)
+ self.assertFalse(exists)
+
zone = Zone('unit.tests.', [])
get_returns = [[record['id'] for record in self.api_record]]
get_returns += self.api_record
get_mock.side_effect = get_returns
- provider.populate(zone)
+ exists = provider.populate(zone)
self.assertEquals(self.expected, zone.records)
+ self.assertTrue(exists)
@patch('ovh.Client')
def test_is_valid_dkim(self, client_mock):
diff --git a/tests/test_octodns_provider_powerdns.py b/tests/test_octodns_provider_powerdns.py
index 5d89c3e..2722991 100644
--- a/tests/test_octodns_provider_powerdns.py
+++ b/tests/test_octodns_provider_powerdns.py
@@ -106,6 +106,7 @@ class TestPowerDnsProvider(TestCase):
plan = provider.plan(expected)
self.assertEquals(expected_n, len(plan.changes))
self.assertEquals(expected_n, provider.apply(plan))
+ self.assertTrue(plan.exists)
# Non-existent zone -> creates for every record in expected
# OMG this is fucking ugly, probably better to ditch requests_mocks and
@@ -124,6 +125,7 @@ class TestPowerDnsProvider(TestCase):
plan = provider.plan(expected)
self.assertEquals(expected_n, len(plan.changes))
self.assertEquals(expected_n, provider.apply(plan))
+ self.assertFalse(plan.exists)
with requests_mock() as mock:
# get 422's, unknown zone
diff --git a/tests/test_octodns_provider_rackspace.py b/tests/test_octodns_provider_rackspace.py
index 274d63e..c467dec 100644
--- a/tests/test_octodns_provider_rackspace.py
+++ b/tests/test_octodns_provider_rackspace.py
@@ -73,9 +73,10 @@ class TestRackspaceProvider(TestCase):
json={'error': "Could not find domain 'unit.tests.'"})
zone = Zone('unit.tests.', [])
- self.provider.populate(zone)
+ exists = self.provider.populate(zone)
self.assertEquals(set(), zone.records)
self.assertTrue(mock.called_once)
+ self.assertFalse(exists)
def test_multipage_populate(self):
with requests_mock() as mock:
@@ -109,6 +110,7 @@ class TestRackspaceProvider(TestCase):
plan = self.provider.plan(expected)
self.assertTrue(mock.called)
+ self.assertTrue(plan.exists)
# OctoDNS does not propagate top-level NS records.
self.assertEquals(1, len(plan.changes))
diff --git a/tests/test_octodns_provider_route53.py b/tests/test_octodns_provider_route53.py
index c2afcd2..3839a16 100644
--- a/tests/test_octodns_provider_route53.py
+++ b/tests/test_octodns_provider_route53.py
@@ -361,6 +361,7 @@ class TestRoute53Provider(TestCase):
plan = provider.plan(self.expected)
self.assertEquals(9, len(plan.changes))
+ self.assertTrue(plan.exists)
for change in plan.changes:
self.assertIsInstance(change, Create)
stubber.assert_no_pending_responses()
@@ -593,6 +594,7 @@ class TestRoute53Provider(TestCase):
plan = provider.plan(self.expected)
self.assertEquals(9, len(plan.changes))
+ self.assertFalse(plan.exists)
for change in plan.changes:
self.assertIsInstance(change, Create)
stubber.assert_no_pending_responses()