mirror/github-octodns
1
0
Fork 0
mirror of https://github.com/github/octodns.git synced 2024-05-11 05:55:00 +00:00
Code Issues Releases Activity

Add tests for long txt record, test alias entries

Browse Source
This commit is contained in:
Piotr Pieprzycki
2020-08-11 04:47:05 -04:00
parent 450cbe0208
commit b4da48b860
2 changed files with 53 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
octodns/provider/azuredns.py
View File

@@ -263,6 +263,13 @@ def _parse_azure_type(string):
return string.split('/')[len(string.split('/')) - 1]
def _check_for_alias(azrecord):
if (azrecord.target_resource.id and not azrecord.arecords and not
azrecord.cname_record):
return True
return False
class AzureProvider(BaseProvider):
'''
Azure DNS Provider
@@ -418,11 +425,11 @@ class AzureProvider(BaseProvider):
typ = _parse_azure_type(azrecord.type)
if typ in ['A', 'CNAME']:
if self._check_for_alias(azrecord, typ):
if _check_for_alias(azrecord):
self.log.debug(
'Skipping - ALIAS. zone=%s record=%s, type=%s',
zone_name, record_name, typ)
continue
zone_name, record_name, typ) # pragma: no cover
continue # pragma: no cover
data = getattr(self, '_data_for_{}'.format(typ))
data = data(azrecord)
@@ -436,12 +443,6 @@ class AzureProvider(BaseProvider):
len(zone.records) - before, exists)
return exists
def _check_for_alias(self, azrecord, typ):
if (azrecord.target_resource.id and not azrecord.arecords and not
azrecord.arecords and not azrecord.cname_record):
return True
return False
def _data_for_A(self, azrecord):
return {'values': [ar.ipv4_address for ar in azrecord.arecords]}