From 0d2953fd06866d17cd5c112c55a498047917d766 Mon Sep 17 00:00:00 2001 From: Ross McFarland Date: Thu, 5 Oct 2023 11:05:52 -0700 Subject: [PATCH 1/9] CI pulls python versions from org secret --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index e96a793..5991f0c 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -8,7 +8,7 @@ jobs: fail-fast: false matrix: # Tested versions based on dates in https://devguide.python.org/versions/#versions - python-version: ['3.8', '3.9', '3.10', '3.11'] + python-version: [${{fromJson(secrets.PYTHON_VERSIONS_ACTIVE)}}] steps: - uses: actions/checkout@v2 - name: Setup python From 752e9742454c96ed89758906f13e3d2d705c4003 Mon Sep 17 00:00:00 2001 From: Ross McFarland Date: Thu, 5 Oct 2023 11:07:52 -0700 Subject: [PATCH 2/9] maybe no bracket --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 5991f0c..d3d4c38 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -8,7 +8,7 @@ jobs: fail-fast: false matrix: # Tested versions based on dates in https://devguide.python.org/versions/#versions - python-version: [${{fromJson(secrets.PYTHON_VERSIONS_ACTIVE)}}] + python-version: ${{fromJson(secrets.PYTHON_VERSIONS_ACTIVE)}} steps: - uses: actions/checkout@v2 - name: Setup python From 7a238898098544a75b982da9af310fb7687c87e4 Mon Sep 17 00:00:00 2001 From: Ross McFarland Date: Thu, 5 Oct 2023 13:14:44 -0700 Subject: [PATCH 3/9] try an env var instead --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index d3d4c38..7882eef 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -8,7 +8,7 @@ jobs: fail-fast: false matrix: # Tested versions based on dates in https://devguide.python.org/versions/#versions - python-version: ${{fromJson(secrets.PYTHON_VERSIONS_ACTIVE)}} + python-version: ${{fromJson(env.PYTHON_VERSIONS_ACTIVE)}} steps: - uses: actions/checkout@v2 - name: Setup python From 90764b12a25714589a2efd9720698e8d25e02bb8 Mon Sep 17 00:00:00 2001 From: Ross McFarland Date: Thu, 5 Oct 2023 13:27:29 -0700 Subject: [PATCH 4/9] is it vars --- .github/workflows/main.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 7882eef..81fffc8 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -7,8 +7,7 @@ jobs: strategy: fail-fast: false matrix: - # Tested versions based on dates in https://devguide.python.org/versions/#versions - python-version: ${{fromJson(env.PYTHON_VERSIONS_ACTIVE)}} + python-version: ${{fromJson(vars.PYTHON_VERSIONS_ACTIVE)}} steps: - uses: actions/checkout@v2 - name: Setup python From 4ace61de54f26108bb8bc15e8855d2b51e47589e Mon Sep 17 00:00:00 2001 From: Ross McFarland Date: Thu, 5 Oct 2023 13:29:12 -0700 Subject: [PATCH 5/9] Restore/update comment about active versions --- .github/workflows/main.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 81fffc8..8363b87 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -7,6 +7,8 @@ jobs: strategy: fail-fast: false matrix: + # Defined in an org level variable, based on dates in + # https://devguide.python.org/versions/#versions python-version: ${{fromJson(vars.PYTHON_VERSIONS_ACTIVE)}} steps: - uses: actions/checkout@v2 From 9f61445a0634e4addeb4e6072b7a7af6c9d0f3fb Mon Sep 17 00:00:00 2001 From: Ross McFarland Date: Thu, 5 Oct 2023 13:35:37 -0700 Subject: [PATCH 6/9] Drive modules ci job python version off of var too --- .github/workflows/modules.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/modules.yml b/.github/workflows/modules.yml index e084a7b..2b6dac5 100644 --- a/.github/workflows/modules.yml +++ b/.github/workflows/modules.yml @@ -46,11 +46,7 @@ jobs: - name: Setup python uses: actions/setup-python@v1 with: - # This should generally be the latest stable release of python, but - # dyn and ovh don't currently support changes made in 3.10 so we'll - # leave it 3.9 for now. Once 3.11 lands though we'll bump to it and - # if they haven't updated they'll be removed from the matrix - python-version: '3.9' + python-version: ${{ vars.PYTHON_VERSION_CURRENT }} architecture: x64 - name: Test Module run: | From cf258cc5a7d1bd20208102b72cdd91eac6fd3d14 Mon Sep 17 00:00:00 2001 From: Ross McFarland Date: Thu, 5 Oct 2023 13:52:21 -0700 Subject: [PATCH 7/9] bump checkout and python action versions --- .github/workflows/main.yml | 4 ++-- .github/workflows/modules.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 8363b87..a3b4e3c 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -11,9 +11,9 @@ jobs: # https://devguide.python.org/versions/#versions python-version: ${{fromJson(vars.PYTHON_VERSIONS_ACTIVE)}} steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Setup python - uses: actions/setup-python@v2 + uses: actions/setup-python@v4 with: python-version: ${{ matrix.python-version }} architecture: x64 diff --git a/.github/workflows/modules.yml b/.github/workflows/modules.yml index 2b6dac5..940abc1 100644 --- a/.github/workflows/modules.yml +++ b/.github/workflows/modules.yml @@ -42,9 +42,9 @@ jobs: # some point in the future and either re-enable or delete it. #- sukiyaki/octodns-netbox steps: - - uses: actions/checkout@master + - uses: actions/checkout@v4 - name: Setup python - uses: actions/setup-python@v1 + uses: actions/setup-python@v4 with: python-version: ${{ vars.PYTHON_VERSION_CURRENT }} architecture: x64 From 1c72e75d93b798f4d05dfa1d1c63eca277de3901 Mon Sep 17 00:00:00 2001 From: Ross McFarland Date: Thu, 5 Oct 2023 14:18:42 -0700 Subject: [PATCH 8/9] setup-py python version from var as well --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index a3b4e3c..f00534c 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -42,7 +42,7 @@ jobs: - name: Setup python uses: actions/setup-python@v2 with: - python-version: '3.11' + python-version: ${{ vars.PYTHON_VERSION_CURRENT }} architecture: x64 - name: CI setup.py run: | From f0c29082790aa02af393dc4efc390f20d4ae2a61 Mon Sep 17 00:00:00 2001 From: Ross McFarland Date: Thu, 5 Oct 2023 14:29:48 -0700 Subject: [PATCH 9/9] bump stale to v8 too --- .github/workflows/stale.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml index 0bea4de..d595205 100644 --- a/.github/workflows/stale.yml +++ b/.github/workflows/stale.yml @@ -6,7 +6,7 @@ jobs: stale: runs-on: ubuntu-latest steps: - - uses: actions/stale@v4 + - uses: actions/stale@v8 with: stale-issue-message: 'This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.' days-before-stale: 90