From ce5ecc52e3edc282427ba4e6655c826be5e0886f Mon Sep 17 00:00:00 2001 From: Steve Coursen Date: Tue, 14 Nov 2017 13:14:03 -0500 Subject: [PATCH] fix broken test by updating the actual format of the answers --- octodns/provider/ns1.py | 2 +- tests/test_octodns_provider_ns1.py | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/octodns/provider/ns1.py b/octodns/provider/ns1.py index 1397c49..008c665 100644 --- a/octodns/provider/ns1.py +++ b/octodns/provider/ns1.py @@ -165,7 +165,7 @@ class Ns1Provider(BaseProvider): def _params_for_A(self, record): params = {'answers': record.values, 'ttl': record.ttl} - if record.geo: + if hasattr(record, 'geo'): # purposefully set non-geo answers to have an empty meta, # so that we know we did this on purpose if/when troubleshooting params['answers'] = [{"answer": x, "meta": {}} diff --git a/tests/test_octodns_provider_ns1.py b/tests/test_octodns_provider_ns1.py index d4f4080..4436304 100644 --- a/tests/test_octodns_provider_ns1.py +++ b/tests/test_octodns_provider_ns1.py @@ -30,11 +30,13 @@ class TestNs1Provider(TestCase): 'ttl': 32, 'type': 'A', 'value': '1.2.3.4', + 'meta': {}, })) expected.add(Record.new(zone, 'foo', { 'ttl': 33, 'type': 'A', 'values': ['1.2.3.4', '1.2.3.5'], + 'meta': {}, })) expected.add(Record.new(zone, 'cname', { 'ttl': 34, @@ -289,7 +291,7 @@ class TestNs1Provider(TestCase): call('delete-me', u'A'), ]) mock_record.assert_has_calls([ - call.update(answers=[u'1.2.3.4'], ttl=32), + call.update(answers=[{'answer': u'1.2.3.4', 'meta': {}}], ttl=32), call.delete() ])