mirror/github-octodns
1
0
Fork 0
mirror of https://github.com/github/octodns.git synced 2024-05-11 05:55:00 +00:00
Code Issues Releases Activity

Existing and desired to _extra_changes, desired used by Route53 to get configed

Browse Source 
Fixes an issue where we'd be looking for custom healthcheck config on the
existing record object (from the provider) which would never have a custom
setup. Instead looking at desired lets us find what's actually configured to be
the case
This commit is contained in:
Ross McFarland
2017-06-20 11:44:13 -07:00
parent 0c1a8fe964
commit d0b8b25cdd
5 changed files with 33 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
octodns/provider/base.py
View File

@@ -92,7 +92,7 @@ class BaseProvider(BaseSource):
'''
return True
def _extra_changes(self, existing, changes):
def _extra_changes(self, existing, desired, changes):
'''
An opportunity for providers to add extra changes to the plan that are
necessary to update ancilary record data or configure the zone. E.g.
@@ -117,7 +117,7 @@ class BaseProvider(BaseSource):
self.log.info('plan: filtered out %s changes', before - after)
# allow the provider to add extra changes it needs
extra = self._extra_changes(existing, changes)
extra = self._extra_changes(existing, desired, changes)
if extra:
self.log.info('plan: extra changes\n %s', '\n '
.join([str(c) for c in extra]))