mirror/github-octodns
1
0
Fork 0
mirror of https://github.com/github/octodns.git synced 2024-05-11 05:55:00 +00:00
Code Issues Releases Activity

Apply suggestions from code review

Browse Source 
Conform to octodns style string concatenation

Co-Authored-By: Ross McFarland <ross@github.com>
This commit is contained in:
Pavan Chandrashekar
2020-03-25 15:20:51 -07:00
committed by GitHub
parent a7f01d4c76
commit f42300b983
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
octodns/provider/ns1.py
View File

@@ -1138,7 +1138,7 @@ class Ns1Provider(BaseProvider):
ns1_record['domain'], ns1_record['domain'],
ns1_record['type']) ns1_record['type'])
if 'filters' in full_rec: if 'filters' in full_rec:
filter_key = ns1_record['domain'] + '.' filter_key = '{}.'format(ns1_record['domain'])
ns1_filters[filter_key] = full_rec['filters'] ns1_filters[filter_key] = full_rec['filters']
return ns1_filters return ns1_filters
@@ -1165,7 +1165,7 @@ class Ns1Provider(BaseProvider):
# Check if filters for existing domains need an update # Check if filters for existing domains need an update
# Needs an explicit check since there might be no change in the # Needs an explicit check since there might be no change in the
# config at all. Filters however might still need an update # config at all. Filters however might still need an update
domain = '.'.join([record.name, record.zone.name]) domain = '{}.{}'format(record.name, record.zone.name)
if domain in ns1_filters: if domain in ns1_filters:
domain_filters = ns1_filters[domain] domain_filters = ns1_filters[domain]
if not self._disabled_flag_in_filters(domain_filters, domain): if not self._disabled_flag_in_filters(domain_filters, domain):