From 2e17176442e8d6384b85db2553a2944a0fe1263a Mon Sep 17 00:00:00 2001 From: Steve Coursen Date: Tue, 13 Feb 2018 09:14:05 -0500 Subject: [PATCH 1/2] Move if branch around to avoid creating unnecessary filter chains --- octodns/provider/ns1.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/octodns/provider/ns1.py b/octodns/provider/ns1.py index 5ea68b6..36ea742 100644 --- a/octodns/provider/ns1.py +++ b/octodns/provider/ns1.py @@ -233,11 +233,11 @@ class Ns1Provider(BaseProvider): }, ) params['filters'] = [] - if len(params['answers']) > 1: - params['filters'].append( - {"filter": "shuffle", "config": {}} - ) if has_country: + if len(params['answers']) > 1: + params['filters'].append( + {"filter": "shuffle", "config": {}} + ) params['filters'].append( {"filter": "geotarget_country", "config": {}} ) From eb97b43d2876c33b82fcf0c4765c33a5738403ea Mon Sep 17 00:00:00 2001 From: Steve Coursen Date: Thu, 15 Feb 2018 10:49:43 -0500 Subject: [PATCH 2/2] length of answers check is unnecessary --- octodns/provider/ns1.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/octodns/provider/ns1.py b/octodns/provider/ns1.py index 36ea742..80797d8 100644 --- a/octodns/provider/ns1.py +++ b/octodns/provider/ns1.py @@ -234,10 +234,9 @@ class Ns1Provider(BaseProvider): ) params['filters'] = [] if has_country: - if len(params['answers']) > 1: - params['filters'].append( - {"filter": "shuffle", "config": {}} - ) + params['filters'].append( + {"filter": "shuffle", "config": {}} + ) params['filters'].append( {"filter": "geotarget_country", "config": {}} )