mirror of
https://github.com/github/octodns.git
synced 2024-05-11 05:55:00 +00:00
4761da9c33
- This reworks the CallerReference structure for Route53 health checks in a non-backwards compatible way. This means records will create new healthchecks for themselves which should be fine. - Since we're pre 1.0, support has NOT been added to cleanup the old healthchecks. That could be done reasonably easy, BUT we'd have to keep that around forever. The hope is that the new ref format/usage will prevent this problem going forward since enough info exists in the ref to identify things fully. :fingers_crossed: - healthcheck GC is much cleaner and more robust thanks to ^ - overall the healthcheck management code is a bit easier to follow and more robust now.
1269 lines
44 KiB
Python
1269 lines
44 KiB
Python
#
|
|
#
|
|
#
|
|
|
|
from __future__ import absolute_import, division, print_function, \
|
|
unicode_literals
|
|
|
|
from botocore.exceptions import ClientError
|
|
from botocore.stub import ANY, Stubber
|
|
from unittest import TestCase
|
|
from mock import patch
|
|
|
|
from octodns.record import Create, Delete, Record, Update
|
|
from octodns.provider.route53 import _Route53Record, Route53Provider, \
|
|
_octal_replace
|
|
from octodns.zone import Zone
|
|
|
|
from helpers import GeoProvider
|
|
|
|
|
|
class TestOctalReplace(TestCase):
|
|
|
|
def test_basic(self):
|
|
for expected, s in (
|
|
('', ''),
|
|
('abc', 'abc'),
|
|
('123', '123'),
|
|
('abc123', 'abc123'),
|
|
('*', '\\052'),
|
|
('abc*', 'abc\\052'),
|
|
('*abc', '\\052abc'),
|
|
('123*', '123\\052'),
|
|
('*123', '\\052123'),
|
|
('**', '\\052\\052'),
|
|
):
|
|
self.assertEquals(expected, _octal_replace(s))
|
|
|
|
|
|
class TestRoute53Provider(TestCase):
|
|
expected = Zone('unit.tests.', [])
|
|
for name, data in (
|
|
('simple',
|
|
{'ttl': 60, 'type': 'A', 'values': ['1.2.3.4', '2.2.3.4']}),
|
|
('',
|
|
{'ttl': 61, 'type': 'A', 'values': ['2.2.3.4', '3.2.3.4'],
|
|
'geo': {
|
|
'AF': ['4.2.3.4'],
|
|
'NA-US': ['5.2.3.4', '6.2.3.4'],
|
|
'NA-US-CA': ['7.2.3.4']}}),
|
|
('cname', {'ttl': 62, 'type': 'CNAME', 'value': 'unit.tests.'}),
|
|
('txt', {'ttl': 63, 'type': 'TXT', 'values': ['Hello World!',
|
|
'Goodbye World?']}),
|
|
('', {'ttl': 64, 'type': 'MX',
|
|
'values': [{
|
|
'priority': 10,
|
|
'value': 'smtp-1.unit.tests.',
|
|
}, {
|
|
'priority': 20,
|
|
'value': 'smtp-2.unit.tests.',
|
|
}]}),
|
|
('naptr', {'ttl': 65, 'type': 'NAPTR',
|
|
'value': {
|
|
'order': 10,
|
|
'preference': 20,
|
|
'flags': 'U',
|
|
'service': 'SIP+D2U',
|
|
'regexp': '!^.*$!sip:info@bar.example.com!',
|
|
'replacement': '.',
|
|
}}),
|
|
('_srv._tcp', {'ttl': 66, 'type': 'SRV', 'value': {
|
|
'priority': 10,
|
|
'weight': 20,
|
|
'port': 30,
|
|
'target': 'cname.unit.tests.'
|
|
}}),
|
|
('',
|
|
{'ttl': 67, 'type': 'NS', 'values': ['8.2.3.4.', '9.2.3.4.']}),
|
|
('sub',
|
|
{'ttl': 68, 'type': 'NS', 'values': ['5.2.3.4.', '6.2.3.4.']}),
|
|
):
|
|
record = Record.new(expected, name, data)
|
|
expected.add_record(record)
|
|
|
|
caller_ref = '{}:A::1324'.format(Route53Provider.HEALTH_CHECK_VERSION)
|
|
health_checks = [{
|
|
'Id': '42',
|
|
'CallerReference': caller_ref,
|
|
'HealthCheckConfig': {
|
|
'Type': 'HTTPS',
|
|
'FullyQualifiedDomainName': 'unit.tests',
|
|
'IPAddress': '4.2.3.4',
|
|
'ResourcePath': '/_dns',
|
|
},
|
|
'HealthCheckVersion': 2,
|
|
}, {
|
|
'Id': 'ignored-also',
|
|
'CallerReference': 'something-else',
|
|
'HealthCheckConfig': {
|
|
'Type': 'HTTPS',
|
|
'FullyQualifiedDomainName': 'unit.tests',
|
|
'IPAddress': '5.2.3.4',
|
|
'ResourcePath': '/_dns',
|
|
},
|
|
'HealthCheckVersion': 42,
|
|
}, {
|
|
'Id': '43',
|
|
'CallerReference': caller_ref,
|
|
'HealthCheckConfig': {
|
|
'Type': 'HTTPS',
|
|
'FullyQualifiedDomainName': 'unit.tests',
|
|
'IPAddress': '5.2.3.4',
|
|
'ResourcePath': '/_dns',
|
|
},
|
|
'HealthCheckVersion': 2,
|
|
}, {
|
|
'Id': '44',
|
|
'CallerReference': caller_ref,
|
|
'HealthCheckConfig': {
|
|
'Type': 'HTTPS',
|
|
'FullyQualifiedDomainName': 'unit.tests',
|
|
'IPAddress': '7.2.3.4',
|
|
'ResourcePath': '/_dns',
|
|
},
|
|
'HealthCheckVersion': 2,
|
|
}, {
|
|
'Id': '45',
|
|
# won't match anything based on type
|
|
'CallerReference': caller_ref.replace(':A:', ':AAAA:'),
|
|
'HealthCheckConfig': {
|
|
'Type': 'HTTPS',
|
|
'FullyQualifiedDomainName': 'unit.tests',
|
|
'IPAddress': '7.2.3.4',
|
|
'ResourcePath': '/_dns',
|
|
},
|
|
'HealthCheckVersion': 2,
|
|
}]
|
|
|
|
def _get_stubbed_provider(self):
|
|
provider = Route53Provider('test', 'abc', '123')
|
|
|
|
# Use the stubber
|
|
stubber = Stubber(provider._conn)
|
|
stubber.activate()
|
|
|
|
return (provider, stubber)
|
|
|
|
def test_populate(self):
|
|
provider, stubber = self._get_stubbed_provider()
|
|
|
|
got = Zone('unit.tests.', [])
|
|
with self.assertRaises(ClientError):
|
|
stubber.add_client_error('list_hosted_zones')
|
|
provider.populate(got)
|
|
|
|
with self.assertRaises(ClientError):
|
|
list_hosted_zones_resp = {
|
|
'HostedZones': [{
|
|
'Name': 'unit.tests.',
|
|
'Id': 'z42',
|
|
'CallerReference': 'abc',
|
|
}],
|
|
'Marker': 'm',
|
|
'IsTruncated': False,
|
|
'MaxItems': '100',
|
|
}
|
|
stubber.add_response('list_hosted_zones', list_hosted_zones_resp,
|
|
{})
|
|
stubber.add_client_error('list_resource_record_sets',
|
|
expected_params={'HostedZoneId': u'z42'})
|
|
provider.populate(got)
|
|
stubber.assert_no_pending_responses()
|
|
|
|
# list_hosted_zones has been cached from now on so we don't have to
|
|
# worry about stubbing it
|
|
|
|
list_resource_record_sets_resp_p1 = {
|
|
'ResourceRecordSets': [{
|
|
'Name': 'simple.unit.tests.',
|
|
'Type': 'A',
|
|
'ResourceRecords': [{
|
|
'Value': '1.2.3.4',
|
|
}, {
|
|
'Value': '2.2.3.4',
|
|
}],
|
|
'TTL': 60,
|
|
}, {
|
|
'Name': 'unit.tests.',
|
|
'Type': 'A',
|
|
'GeoLocation': {
|
|
'CountryCode': '*',
|
|
},
|
|
'ResourceRecords': [{
|
|
'Value': '2.2.3.4',
|
|
}, {
|
|
'Value': '3.2.3.4',
|
|
}],
|
|
'TTL': 61,
|
|
}, {
|
|
'Name': 'unit.tests.',
|
|
'Type': 'A',
|
|
'GeoLocation': {
|
|
'ContinentCode': 'AF',
|
|
},
|
|
'ResourceRecords': [{
|
|
'Value': '4.2.3.4',
|
|
}],
|
|
'TTL': 61,
|
|
}, {
|
|
'Name': 'unit.tests.',
|
|
'Type': 'A',
|
|
'GeoLocation': {
|
|
'CountryCode': 'US',
|
|
},
|
|
'ResourceRecords': [{
|
|
'Value': '5.2.3.4',
|
|
}, {
|
|
'Value': '6.2.3.4',
|
|
}],
|
|
'TTL': 61,
|
|
}, {
|
|
'Name': 'unit.tests.',
|
|
'Type': 'A',
|
|
'GeoLocation': {
|
|
'CountryCode': 'US',
|
|
'SubdivisionCode': 'CA',
|
|
},
|
|
'ResourceRecords': [{
|
|
'Value': '7.2.3.4',
|
|
}],
|
|
'TTL': 61,
|
|
}],
|
|
'IsTruncated': True,
|
|
'NextRecordName': 'next_name',
|
|
'NextRecordType': 'next_type',
|
|
'MaxItems': '100',
|
|
}
|
|
stubber.add_response('list_resource_record_sets',
|
|
list_resource_record_sets_resp_p1,
|
|
{'HostedZoneId': 'z42'})
|
|
|
|
list_resource_record_sets_resp_p2 = {
|
|
'ResourceRecordSets': [{
|
|
'Name': 'cname.unit.tests.',
|
|
'Type': 'CNAME',
|
|
'ResourceRecords': [{
|
|
'Value': 'unit.tests.',
|
|
}],
|
|
'TTL': 62,
|
|
}, {
|
|
'Name': 'txt.unit.tests.',
|
|
'Type': 'TXT',
|
|
'ResourceRecords': [{
|
|
'Value': '"Hello World!"',
|
|
}, {
|
|
'Value': '"Goodbye World?"',
|
|
}],
|
|
'TTL': 63,
|
|
}, {
|
|
'Name': 'unit.tests.',
|
|
'Type': 'MX',
|
|
'ResourceRecords': [{
|
|
'Value': '10 smtp-1.unit.tests.',
|
|
}, {
|
|
'Value': '20 smtp-2.unit.tests.',
|
|
}],
|
|
'TTL': 64,
|
|
}, {
|
|
'Name': 'naptr.unit.tests.',
|
|
'Type': 'NAPTR',
|
|
'ResourceRecords': [{
|
|
'Value': '10 20 "U" "SIP+D2U" '
|
|
'"!^.*$!sip:info@bar.example.com!" .',
|
|
}],
|
|
'TTL': 65,
|
|
}, {
|
|
'Name': '_srv._tcp.unit.tests.',
|
|
'Type': 'SRV',
|
|
'ResourceRecords': [{
|
|
'Value': '10 20 30 cname.unit.tests.',
|
|
}],
|
|
'TTL': 66,
|
|
}, {
|
|
'Name': 'unit.tests.',
|
|
'Type': 'NS',
|
|
'ResourceRecords': [{
|
|
'Value': 'ns1.unit.tests.',
|
|
}],
|
|
'TTL': 67,
|
|
}, {
|
|
'Name': 'sub.unit.tests.',
|
|
'Type': 'NS',
|
|
'GeoLocation': {
|
|
'ContinentCode': 'AF',
|
|
},
|
|
'ResourceRecords': [{
|
|
'Value': '5.2.3.4.',
|
|
}, {
|
|
'Value': '6.2.3.4.',
|
|
}],
|
|
'TTL': 68,
|
|
}, {
|
|
'Name': 'soa.unit.tests.',
|
|
'Type': 'SOA',
|
|
'ResourceRecords': [{
|
|
'Value': 'ns1.unit.tests.',
|
|
}],
|
|
'TTL': 69,
|
|
}],
|
|
'IsTruncated': False,
|
|
'MaxItems': '100',
|
|
}
|
|
stubber.add_response('list_resource_record_sets',
|
|
list_resource_record_sets_resp_p2,
|
|
{'HostedZoneId': 'z42',
|
|
'StartRecordName': 'next_name',
|
|
'StartRecordType': 'next_type'})
|
|
|
|
# Load everything
|
|
provider.populate(got)
|
|
# Make sure we got what we expected
|
|
changes = self.expected.changes(got, GeoProvider())
|
|
self.assertEquals(0, len(changes))
|
|
stubber.assert_no_pending_responses()
|
|
|
|
# Populate a zone that doesn't exist
|
|
noexist = Zone('does.not.exist.', [])
|
|
provider.populate(noexist)
|
|
self.assertEquals(set(), noexist.records)
|
|
|
|
def test_sync(self):
|
|
provider, stubber = self._get_stubbed_provider()
|
|
|
|
list_hosted_zones_resp = {
|
|
'HostedZones': [{
|
|
'Name': 'unit.tests.',
|
|
'Id': 'z42',
|
|
'CallerReference': 'abc',
|
|
}],
|
|
'Marker': 'm',
|
|
'IsTruncated': False,
|
|
'MaxItems': '100',
|
|
}
|
|
stubber.add_response('list_hosted_zones', list_hosted_zones_resp,
|
|
{})
|
|
list_resource_record_sets_resp = {
|
|
'ResourceRecordSets': [],
|
|
'IsTruncated': False,
|
|
'MaxItems': '100',
|
|
}
|
|
stubber.add_response('list_resource_record_sets',
|
|
list_resource_record_sets_resp,
|
|
{'HostedZoneId': 'z42'})
|
|
|
|
plan = provider.plan(self.expected)
|
|
self.assertEquals(8, len(plan.changes))
|
|
for change in plan.changes:
|
|
self.assertIsInstance(change, Create)
|
|
stubber.assert_no_pending_responses()
|
|
|
|
stubber.add_response('list_health_checks',
|
|
{
|
|
'HealthChecks': self.health_checks,
|
|
'IsTruncated': False,
|
|
'MaxItems': '100',
|
|
'Marker': '',
|
|
})
|
|
stubber.add_response('change_resource_record_sets',
|
|
{'ChangeInfo': {
|
|
'Id': 'id',
|
|
'Status': 'PENDING',
|
|
'SubmittedAt': '2017-01-29T01:02:03Z',
|
|
}}, {'HostedZoneId': 'z42', 'ChangeBatch': ANY})
|
|
|
|
self.assertEquals(8, provider.apply(plan))
|
|
stubber.assert_no_pending_responses()
|
|
|
|
# Delete by monkey patching in a populate that includes an extra record
|
|
def add_extra_populate(existing, target):
|
|
for record in self.expected.records:
|
|
existing.records.add(record)
|
|
record = Record.new(existing, 'extra',
|
|
{'ttl': 99, 'type': 'A',
|
|
'values': ['9.9.9.9']})
|
|
existing.records.add(record)
|
|
|
|
provider.populate = add_extra_populate
|
|
change_resource_record_sets_params = {
|
|
'ChangeBatch': {
|
|
'Changes': [{
|
|
'Action': 'DELETE', 'ResourceRecordSet': {
|
|
'Name': 'extra.unit.tests.',
|
|
'ResourceRecords': [{'Value': u'9.9.9.9'}],
|
|
'TTL': 99,
|
|
'Type': 'A'
|
|
}}],
|
|
u'Comment': ANY
|
|
},
|
|
'HostedZoneId': u'z42'
|
|
}
|
|
stubber.add_response('change_resource_record_sets',
|
|
{'ChangeInfo': {
|
|
'Id': 'id',
|
|
'Status': 'PENDING',
|
|
'SubmittedAt': '2017-01-29T01:02:03Z',
|
|
}}, change_resource_record_sets_params)
|
|
plan = provider.plan(self.expected)
|
|
self.assertEquals(1, len(plan.changes))
|
|
self.assertIsInstance(plan.changes[0], Delete)
|
|
self.assertEquals(1, provider.apply(plan))
|
|
stubber.assert_no_pending_responses()
|
|
|
|
# Update by monkey patching in a populate that modifies the A record
|
|
# with geos
|
|
def mod_geo_populate(existing, target):
|
|
for record in self.expected.records:
|
|
if record._type != 'A' or not record.geo:
|
|
existing.records.add(record)
|
|
record = Record.new(existing, '', {
|
|
'ttl': 61,
|
|
'type': 'A',
|
|
'values': ['8.2.3.4', '3.2.3.4'],
|
|
'geo': {
|
|
'AF': ['4.2.3.4'],
|
|
'NA-US': ['5.2.3.4', '6.2.3.4'],
|
|
'NA-US-KY': ['7.2.3.4']
|
|
}
|
|
})
|
|
existing.records.add(record)
|
|
|
|
provider.populate = mod_geo_populate
|
|
change_resource_record_sets_params = {
|
|
'ChangeBatch': {
|
|
'Changes': [{
|
|
'Action': 'DELETE',
|
|
'ResourceRecordSet': {
|
|
'GeoLocation': {'CountryCode': 'US',
|
|
'SubdivisionCode': 'KY'},
|
|
'HealthCheckId': u'44',
|
|
'Name': 'unit.tests.',
|
|
'ResourceRecords': [{'Value': '7.2.3.4'}],
|
|
'SetIdentifier': 'NA-US-KY',
|
|
'TTL': 61,
|
|
'Type': 'A'
|
|
}
|
|
}, {
|
|
'Action': 'CREATE',
|
|
'ResourceRecordSet': {
|
|
'GeoLocation': {'CountryCode': 'US',
|
|
'SubdivisionCode': 'CA'},
|
|
'HealthCheckId': u'44',
|
|
'Name': 'unit.tests.',
|
|
'ResourceRecords': [{'Value': '7.2.3.4'}],
|
|
'SetIdentifier': 'NA-US-CA',
|
|
'TTL': 61,
|
|
'Type': 'A'
|
|
}
|
|
}, {
|
|
'Action': 'UPSERT',
|
|
'ResourceRecordSet': {
|
|
'GeoLocation': {'ContinentCode': 'AF'},
|
|
'Name': 'unit.tests.',
|
|
'HealthCheckId': u'42',
|
|
'ResourceRecords': [{'Value': '4.2.3.4'}],
|
|
'SetIdentifier': 'AF',
|
|
'TTL': 61,
|
|
'Type': 'A'
|
|
}
|
|
}, {
|
|
'Action': 'UPSERT',
|
|
'ResourceRecordSet': {
|
|
'GeoLocation': {'CountryCode': '*'},
|
|
'Name': 'unit.tests.',
|
|
'ResourceRecords': [{'Value': '2.2.3.4'},
|
|
{'Value': '3.2.3.4'}],
|
|
'SetIdentifier': 'default',
|
|
'TTL': 61,
|
|
'Type': 'A'
|
|
}
|
|
}, {
|
|
'Action': 'UPSERT',
|
|
'ResourceRecordSet': {
|
|
'GeoLocation': {'CountryCode': 'US'},
|
|
'HealthCheckId': u'43',
|
|
'Name': 'unit.tests.',
|
|
'ResourceRecords': [{'Value': '5.2.3.4'},
|
|
{'Value': '6.2.3.4'}],
|
|
'SetIdentifier': 'NA-US',
|
|
'TTL': 61,
|
|
'Type': 'A'
|
|
}
|
|
}],
|
|
'Comment': ANY
|
|
},
|
|
'HostedZoneId': 'z42'
|
|
}
|
|
stubber.add_response('change_resource_record_sets',
|
|
{'ChangeInfo': {
|
|
'Id': 'id',
|
|
'Status': 'PENDING',
|
|
'SubmittedAt': '2017-01-29T01:02:03Z',
|
|
}}, change_resource_record_sets_params)
|
|
plan = provider.plan(self.expected)
|
|
self.assertEquals(1, len(plan.changes))
|
|
self.assertIsInstance(plan.changes[0], Update)
|
|
self.assertEquals(1, provider.apply(plan))
|
|
stubber.assert_no_pending_responses()
|
|
|
|
# Update converting to non-geo by monkey patching in a populate that
|
|
# modifies the A record with geos
|
|
def mod_add_geo_populate(existing, target):
|
|
for record in self.expected.records:
|
|
if record._type != 'A' or record.geo:
|
|
existing.records.add(record)
|
|
record = Record.new(existing, 'simple', {
|
|
'ttl': 61,
|
|
'type': 'A',
|
|
'values': ['1.2.3.4', '2.2.3.4'],
|
|
'geo': {
|
|
'OC': ['3.2.3.4', '4.2.3.4'],
|
|
}
|
|
})
|
|
existing.records.add(record)
|
|
|
|
provider.populate = mod_add_geo_populate
|
|
change_resource_record_sets_params = {
|
|
'ChangeBatch': {
|
|
'Changes': [{
|
|
'Action': 'DELETE',
|
|
'ResourceRecordSet': {
|
|
'GeoLocation': {'ContinentCode': 'OC'},
|
|
'Name': 'simple.unit.tests.',
|
|
'ResourceRecords': [{'Value': '3.2.3.4'},
|
|
{'Value': '4.2.3.4'}],
|
|
'SetIdentifier': 'OC',
|
|
'TTL': 61,
|
|
'Type': 'A'}
|
|
}, {
|
|
'Action': 'DELETE',
|
|
'ResourceRecordSet': {
|
|
'GeoLocation': {'CountryCode': '*'},
|
|
'Name': 'simple.unit.tests.',
|
|
'ResourceRecords': [{'Value': '1.2.3.4'},
|
|
{'Value': '2.2.3.4'}],
|
|
'SetIdentifier': 'default',
|
|
'TTL': 61,
|
|
'Type': 'A'}
|
|
}, {
|
|
'Action': 'CREATE',
|
|
'ResourceRecordSet': {
|
|
'Name': 'simple.unit.tests.',
|
|
'ResourceRecords': [{'Value': '1.2.3.4'},
|
|
{'Value': '2.2.3.4'}],
|
|
'TTL': 60,
|
|
'Type': 'A'}
|
|
}],
|
|
'Comment': ANY
|
|
},
|
|
'HostedZoneId': 'z42'
|
|
}
|
|
stubber.add_response('change_resource_record_sets',
|
|
{'ChangeInfo': {
|
|
'Id': 'id',
|
|
'Status': 'PENDING',
|
|
'SubmittedAt': '2017-01-29T01:02:03Z',
|
|
}}, change_resource_record_sets_params)
|
|
plan = provider.plan(self.expected)
|
|
self.assertEquals(1, len(plan.changes))
|
|
self.assertIsInstance(plan.changes[0], Update)
|
|
self.assertEquals(1, provider.apply(plan))
|
|
stubber.assert_no_pending_responses()
|
|
|
|
def test_sync_create(self):
|
|
provider, stubber = self._get_stubbed_provider()
|
|
|
|
got = Zone('unit.tests.', [])
|
|
|
|
list_hosted_zones_resp = {
|
|
'HostedZones': [],
|
|
'Marker': 'm',
|
|
'IsTruncated': False,
|
|
'MaxItems': '100',
|
|
}
|
|
stubber.add_response('list_hosted_zones', list_hosted_zones_resp,
|
|
{})
|
|
|
|
plan = provider.plan(self.expected)
|
|
self.assertEquals(8, len(plan.changes))
|
|
for change in plan.changes:
|
|
self.assertIsInstance(change, Create)
|
|
stubber.assert_no_pending_responses()
|
|
|
|
create_hosted_zone_resp = {
|
|
'HostedZone': {
|
|
'Name': 'unit.tests.',
|
|
'Id': 'z42',
|
|
'CallerReference': 'abc',
|
|
},
|
|
'ChangeInfo': {
|
|
'Id': 'a12',
|
|
'Status': 'PENDING',
|
|
'SubmittedAt': '2017-01-29T01:02:03Z',
|
|
'Comment': 'hrm',
|
|
},
|
|
'DelegationSet': {
|
|
'Id': 'b23',
|
|
'CallerReference': 'blip',
|
|
'NameServers': [
|
|
'n12.unit.tests.',
|
|
],
|
|
},
|
|
'Location': 'us-east-1',
|
|
}
|
|
stubber.add_response('create_hosted_zone',
|
|
create_hosted_zone_resp, {
|
|
'Name': got.name,
|
|
'CallerReference': ANY,
|
|
})
|
|
|
|
stubber.add_response('list_health_checks',
|
|
{
|
|
'HealthChecks': self.health_checks,
|
|
'IsTruncated': False,
|
|
'MaxItems': '100',
|
|
'Marker': '',
|
|
})
|
|
|
|
stubber.add_response('change_resource_record_sets',
|
|
{'ChangeInfo': {
|
|
'Id': 'id',
|
|
'Status': 'PENDING',
|
|
'SubmittedAt': '2017-01-29T01:02:03Z',
|
|
}}, {'HostedZoneId': 'z42', 'ChangeBatch': ANY})
|
|
|
|
self.assertEquals(8, provider.apply(plan))
|
|
stubber.assert_no_pending_responses()
|
|
|
|
def test_health_checks_pagination(self):
|
|
provider, stubber = self._get_stubbed_provider()
|
|
|
|
health_checks_p1 = [{
|
|
'Id': '42',
|
|
'CallerReference': self.caller_ref,
|
|
'HealthCheckConfig': {
|
|
'Type': 'HTTPS',
|
|
'FullyQualifiedDomainName': 'unit.tests',
|
|
'IPAddress': '4.2.3.4',
|
|
'ResourcePath': '/_dns',
|
|
},
|
|
'HealthCheckVersion': 2,
|
|
}, {
|
|
'Id': '43',
|
|
'CallerReference': 'abc123',
|
|
'HealthCheckConfig': {
|
|
'Type': 'HTTPS',
|
|
'FullyQualifiedDomainName': 'unit.tests',
|
|
'IPAddress': '9.2.3.4',
|
|
'ResourcePath': '/_dns',
|
|
},
|
|
'HealthCheckVersion': 2,
|
|
}]
|
|
stubber.add_response('list_health_checks',
|
|
{
|
|
'HealthChecks': health_checks_p1,
|
|
'IsTruncated': True,
|
|
'MaxItems': '2',
|
|
'Marker': '',
|
|
'NextMarker': 'moar',
|
|
})
|
|
|
|
health_checks_p2 = [{
|
|
'Id': '44',
|
|
'CallerReference': self.caller_ref,
|
|
'HealthCheckConfig': {
|
|
'Type': 'HTTPS',
|
|
'FullyQualifiedDomainName': 'unit.tests',
|
|
'IPAddress': '8.2.3.4',
|
|
'ResourcePath': '/_dns',
|
|
},
|
|
'HealthCheckVersion': 2,
|
|
}]
|
|
stubber.add_response('list_health_checks',
|
|
{
|
|
'HealthChecks': health_checks_p2,
|
|
'IsTruncated': False,
|
|
'MaxItems': '2',
|
|
'Marker': 'moar',
|
|
}, {'Marker': 'moar'})
|
|
|
|
health_checks = provider.health_checks
|
|
self.assertEquals({
|
|
'42': health_checks_p1[0],
|
|
'44': health_checks_p2[0],
|
|
}, health_checks)
|
|
stubber.assert_no_pending_responses()
|
|
|
|
# get without create
|
|
record = Record.new(self.expected, '', {
|
|
'ttl': 61,
|
|
'type': 'A',
|
|
'values': ['2.2.3.4', '3.2.3.4'],
|
|
'geo': {
|
|
'AF': ['4.2.3.4'],
|
|
}
|
|
})
|
|
id = provider._get_health_check_id(record, 'AF', record.geo['AF'],
|
|
True)
|
|
self.assertEquals('42', id)
|
|
|
|
def test_health_check_create(self):
|
|
provider, stubber = self._get_stubbed_provider()
|
|
|
|
# No match based on type
|
|
caller_ref = \
|
|
'{}:AAAA:foo1234'.format(Route53Provider.HEALTH_CHECK_VERSION)
|
|
health_checks = [{
|
|
'Id': '42',
|
|
# No match based on version
|
|
'CallerReference': '9999:A:foo1234',
|
|
'HealthCheckConfig': {
|
|
'Type': 'HTTPS',
|
|
'FullyQualifiedDomainName': 'unit.tests',
|
|
'IPAddress': '4.2.3.4',
|
|
'ResourcePath': '/_dns',
|
|
},
|
|
'HealthCheckVersion': 2,
|
|
}, {
|
|
'Id': '43',
|
|
'CallerReference': caller_ref,
|
|
'HealthCheckConfig': {
|
|
'Type': 'HTTPS',
|
|
'FullyQualifiedDomainName': 'unit.tests',
|
|
'IPAddress': '4.2.3.4',
|
|
'ResourcePath': '/_dns',
|
|
},
|
|
'HealthCheckVersion': 2,
|
|
}]
|
|
stubber.add_response('list_health_checks', {
|
|
'HealthChecks': health_checks,
|
|
'IsTruncated': False,
|
|
'MaxItems': '100',
|
|
'Marker': '',
|
|
})
|
|
|
|
health_check_config = {
|
|
'EnableSNI': True,
|
|
'FailureThreshold': 6,
|
|
'FullyQualifiedDomainName': 'unit.tests',
|
|
'IPAddress': '4.2.3.4',
|
|
'ResourcePath': '/_dns',
|
|
'MeasureLatency': True,
|
|
'Port': 443,
|
|
'RequestInterval': 10,
|
|
'ResourcePath': '/_dns',
|
|
'Type': 'HTTPS'
|
|
}
|
|
stubber.add_response('create_health_check', {
|
|
'HealthCheck': {
|
|
'Id': '42',
|
|
'CallerReference': self.caller_ref,
|
|
'HealthCheckConfig': health_check_config,
|
|
'HealthCheckVersion': 1,
|
|
},
|
|
'Location': 'http://url',
|
|
}, {
|
|
'CallerReference': ANY,
|
|
'HealthCheckConfig': health_check_config,
|
|
})
|
|
|
|
record = Record.new(self.expected, '', {
|
|
'ttl': 61,
|
|
'type': 'A',
|
|
'values': ['2.2.3.4', '3.2.3.4'],
|
|
'geo': {
|
|
'AF': ['4.2.3.4'],
|
|
}
|
|
})
|
|
|
|
# if not allowed to create returns none
|
|
id = provider._get_health_check_id(record, 'AF', record.geo['AF'],
|
|
False)
|
|
self.assertFalse(id)
|
|
|
|
# when allowed to create we do
|
|
id = provider._get_health_check_id(record, 'AF', record.geo['AF'],
|
|
True)
|
|
self.assertEquals('42', id)
|
|
stubber.assert_no_pending_responses()
|
|
|
|
def test_health_check_gc(self):
|
|
provider, stubber = self._get_stubbed_provider()
|
|
|
|
stubber.add_response('list_health_checks', {
|
|
'HealthChecks': self.health_checks,
|
|
'IsTruncated': False,
|
|
'MaxItems': '100',
|
|
'Marker': '',
|
|
})
|
|
|
|
record = Record.new(self.expected, '', {
|
|
'ttl': 61,
|
|
'type': 'A',
|
|
'values': ['2.2.3.4', '3.2.3.4'],
|
|
'geo': {
|
|
'AF': ['4.2.3.4'],
|
|
'NA-US': ['5.2.3.4', '6.2.3.4'],
|
|
# removed one geo
|
|
}
|
|
})
|
|
|
|
class DummyRecord(object):
|
|
|
|
def __init__(self, health_check_id):
|
|
self.health_check_id = health_check_id
|
|
|
|
# gc no longer in_use records (directly)
|
|
stubber.add_response('delete_health_check', {}, {
|
|
'HealthCheckId': '44',
|
|
})
|
|
provider._gc_health_checks(record, [
|
|
DummyRecord('42'),
|
|
DummyRecord('43'),
|
|
])
|
|
stubber.assert_no_pending_responses()
|
|
|
|
# gc through _mod_Create
|
|
stubber.add_response('delete_health_check', {}, {
|
|
'HealthCheckId': '44',
|
|
})
|
|
change = Create(record)
|
|
provider._mod_Create(change)
|
|
stubber.assert_no_pending_responses()
|
|
|
|
# gc through _mod_Update
|
|
stubber.add_response('delete_health_check', {}, {
|
|
'HealthCheckId': '44',
|
|
})
|
|
# first record is ignored for our purposes, we have to pass something
|
|
change = Update(record, record)
|
|
provider._mod_Create(change)
|
|
stubber.assert_no_pending_responses()
|
|
|
|
# gc through _mod_Delete, expect 3 to go away, can't check order
|
|
# b/c it's not deterministic
|
|
stubber.add_response('delete_health_check', {}, {
|
|
'HealthCheckId': ANY,
|
|
})
|
|
stubber.add_response('delete_health_check', {}, {
|
|
'HealthCheckId': ANY,
|
|
})
|
|
stubber.add_response('delete_health_check', {}, {
|
|
'HealthCheckId': ANY,
|
|
})
|
|
change = Delete(record)
|
|
provider._mod_Delete(change)
|
|
stubber.assert_no_pending_responses()
|
|
|
|
# gc only AAAA, leave the A's alone
|
|
stubber.add_response('delete_health_check', {}, {
|
|
'HealthCheckId': '45',
|
|
})
|
|
record = Record.new(self.expected, '', {
|
|
'ttl': 61,
|
|
'type': 'AAAA',
|
|
'value': '2001:0db8:3c4d:0015:0000:0000:1a2f:1a4b'
|
|
})
|
|
provider._gc_health_checks(record, [])
|
|
stubber.assert_no_pending_responses()
|
|
|
|
def test_no_extra_changes(self):
|
|
provider, stubber = self._get_stubbed_provider()
|
|
|
|
list_hosted_zones_resp = {
|
|
'HostedZones': [{
|
|
'Name': 'unit.tests.',
|
|
'Id': 'z42',
|
|
'CallerReference': 'abc',
|
|
}],
|
|
'Marker': 'm',
|
|
'IsTruncated': False,
|
|
'MaxItems': '100',
|
|
}
|
|
stubber.add_response('list_hosted_zones', list_hosted_zones_resp, {})
|
|
|
|
# empty is empty
|
|
existing = Zone('unit.tests.', [])
|
|
extra = provider._extra_changes(existing, [])
|
|
self.assertEquals([], extra)
|
|
stubber.assert_no_pending_responses()
|
|
|
|
# single record w/o geo is empty
|
|
existing = Zone('unit.tests.', [])
|
|
record = Record.new(existing, 'a', {
|
|
'ttl': 30,
|
|
'type': 'A',
|
|
'value': '1.2.3.4',
|
|
})
|
|
existing.add_record(record)
|
|
extra = provider._extra_changes(existing, [])
|
|
self.assertEquals([], extra)
|
|
stubber.assert_no_pending_responses()
|
|
|
|
# short-circuit for unknown zone
|
|
other = Zone('other.tests.', [])
|
|
extra = provider._extra_changes(other, [])
|
|
self.assertEquals([], extra)
|
|
stubber.assert_no_pending_responses()
|
|
|
|
def test_extra_change_no_health_check(self):
|
|
provider, stubber = self._get_stubbed_provider()
|
|
|
|
list_hosted_zones_resp = {
|
|
'HostedZones': [{
|
|
'Name': 'unit.tests.',
|
|
'Id': 'z42',
|
|
'CallerReference': 'abc',
|
|
}],
|
|
'Marker': 'm',
|
|
'IsTruncated': False,
|
|
'MaxItems': '100',
|
|
}
|
|
stubber.add_response('list_hosted_zones', list_hosted_zones_resp, {})
|
|
|
|
# record with geo and no health check returns change
|
|
existing = Zone('unit.tests.', [])
|
|
record = Record.new(existing, 'a', {
|
|
'ttl': 30,
|
|
'type': 'A',
|
|
'value': '1.2.3.4',
|
|
'geo': {
|
|
'NA': ['2.2.3.4'],
|
|
}
|
|
})
|
|
existing.add_record(record)
|
|
list_resource_record_sets_resp = {
|
|
'ResourceRecordSets': [{
|
|
'Name': 'a.unit.tests.',
|
|
'Type': 'A',
|
|
'GeoLocation': {
|
|
'ContinentCode': 'NA',
|
|
},
|
|
'ResourceRecords': [{
|
|
'Value': '2.2.3.4',
|
|
}],
|
|
'TTL': 61,
|
|
}],
|
|
'IsTruncated': False,
|
|
'MaxItems': '100',
|
|
}
|
|
stubber.add_response('list_resource_record_sets',
|
|
list_resource_record_sets_resp,
|
|
{'HostedZoneId': 'z42'})
|
|
extra = provider._extra_changes(existing, [])
|
|
self.assertEquals(1, len(extra))
|
|
stubber.assert_no_pending_responses()
|
|
|
|
def test_extra_change_has_wrong_health_check(self):
|
|
provider, stubber = self._get_stubbed_provider()
|
|
|
|
list_hosted_zones_resp = {
|
|
'HostedZones': [{
|
|
'Name': 'unit.tests.',
|
|
'Id': 'z42',
|
|
'CallerReference': 'abc',
|
|
}],
|
|
'Marker': 'm',
|
|
'IsTruncated': False,
|
|
'MaxItems': '100',
|
|
}
|
|
stubber.add_response('list_hosted_zones', list_hosted_zones_resp, {})
|
|
|
|
# record with geo and no health check returns change
|
|
existing = Zone('unit.tests.', [])
|
|
record = Record.new(existing, 'a', {
|
|
'ttl': 30,
|
|
'type': 'A',
|
|
'value': '1.2.3.4',
|
|
'geo': {
|
|
'NA': ['2.2.3.4'],
|
|
}
|
|
})
|
|
existing.add_record(record)
|
|
list_resource_record_sets_resp = {
|
|
'ResourceRecordSets': [{
|
|
'Name': 'a.unit.tests.',
|
|
'Type': 'A',
|
|
'GeoLocation': {
|
|
'ContinentCode': 'NA',
|
|
},
|
|
'ResourceRecords': [{
|
|
'Value': '2.2.3.4',
|
|
}],
|
|
'TTL': 61,
|
|
'HealthCheckId': '42',
|
|
}],
|
|
'IsTruncated': False,
|
|
'MaxItems': '100',
|
|
}
|
|
stubber.add_response('list_resource_record_sets',
|
|
list_resource_record_sets_resp,
|
|
{'HostedZoneId': 'z42'})
|
|
stubber.add_response('list_health_checks', {
|
|
'HealthChecks': [{
|
|
'Id': '42',
|
|
'CallerReference': 'foo',
|
|
'HealthCheckConfig': {
|
|
'Type': 'HTTPS',
|
|
'FullyQualifiedDomainName': 'unit.tests',
|
|
'IPAddress': '2.2.3.4',
|
|
'ResourcePath': '/_dns',
|
|
},
|
|
'HealthCheckVersion': 2,
|
|
}],
|
|
'IsTruncated': False,
|
|
'MaxItems': '100',
|
|
'Marker': '',
|
|
})
|
|
extra = provider._extra_changes(existing, [])
|
|
self.assertEquals(1, len(extra))
|
|
stubber.assert_no_pending_responses()
|
|
|
|
for change in (Create(record), Update(record, record), Delete(record)):
|
|
extra = provider._extra_changes(existing, [change])
|
|
self.assertEquals(0, len(extra))
|
|
stubber.assert_no_pending_responses()
|
|
|
|
def test_extra_change_has_health_check(self):
|
|
provider, stubber = self._get_stubbed_provider()
|
|
|
|
list_hosted_zones_resp = {
|
|
'HostedZones': [{
|
|
'Name': 'unit.tests.',
|
|
'Id': 'z42',
|
|
'CallerReference': 'abc',
|
|
}],
|
|
'Marker': 'm',
|
|
'IsTruncated': False,
|
|
'MaxItems': '100',
|
|
}
|
|
stubber.add_response('list_hosted_zones', list_hosted_zones_resp, {})
|
|
|
|
# record with geo and no health check returns change
|
|
existing = Zone('unit.tests.', [])
|
|
record = Record.new(existing, 'a', {
|
|
'ttl': 30,
|
|
'type': 'A',
|
|
'value': '1.2.3.4',
|
|
'geo': {
|
|
'NA': ['2.2.3.4'],
|
|
}
|
|
})
|
|
existing.add_record(record)
|
|
list_resource_record_sets_resp = {
|
|
'ResourceRecordSets': [{
|
|
# other name
|
|
'Name': 'unit.tests.',
|
|
'Type': 'A',
|
|
'GeoLocation': {
|
|
'CountryCode': '*',
|
|
},
|
|
'ResourceRecords': [{
|
|
'Value': '1.2.3.4',
|
|
}],
|
|
'TTL': 61,
|
|
}, {
|
|
# matching name, other type
|
|
'Name': 'a.unit.tests.',
|
|
'Type': 'AAAA',
|
|
'ResourceRecords': [{
|
|
'Value': '2001:0db8:3c4d:0015:0000:0000:1a2f:1a4b'
|
|
}],
|
|
'TTL': 61,
|
|
}, {
|
|
# default geo
|
|
'Name': 'a.unit.tests.',
|
|
'Type': 'A',
|
|
'GeoLocation': {
|
|
'CountryCode': '*',
|
|
},
|
|
'ResourceRecords': [{
|
|
'Value': '1.2.3.4',
|
|
}],
|
|
'TTL': 61,
|
|
}, {
|
|
# match w/correct geo
|
|
'Name': 'a.unit.tests.',
|
|
'Type': 'A',
|
|
'GeoLocation': {
|
|
'ContinentCode': 'NA',
|
|
},
|
|
'ResourceRecords': [{
|
|
'Value': '2.2.3.4',
|
|
}],
|
|
'TTL': 61,
|
|
'HealthCheckId': '42',
|
|
}],
|
|
'IsTruncated': False,
|
|
'MaxItems': '100',
|
|
}
|
|
stubber.add_response('list_resource_record_sets',
|
|
list_resource_record_sets_resp,
|
|
{'HostedZoneId': 'z42'})
|
|
stubber.add_response('list_health_checks', {
|
|
'HealthChecks': [{
|
|
'Id': '42',
|
|
'CallerReference': self.caller_ref,
|
|
'HealthCheckConfig': {
|
|
'Type': 'HTTPS',
|
|
'FullyQualifiedDomainName': 'a.unit.tests',
|
|
'IPAddress': '2.2.3.4',
|
|
'ResourcePath': '/_dns',
|
|
},
|
|
'HealthCheckVersion': 2,
|
|
}],
|
|
'IsTruncated': False,
|
|
'MaxItems': '100',
|
|
'Marker': '',
|
|
})
|
|
extra = provider._extra_changes(existing, [])
|
|
self.assertEquals(0, len(extra))
|
|
stubber.assert_no_pending_responses()
|
|
|
|
# change b/c of healthcheck path
|
|
record._octodns['healthcheck'] = {
|
|
'path': '/_ready'
|
|
}
|
|
extra = provider._extra_changes(existing, [])
|
|
self.assertEquals(1, len(extra))
|
|
stubber.assert_no_pending_responses()
|
|
|
|
# change b/c of healthcheck host
|
|
record._octodns['healthcheck'] = {
|
|
'host': 'foo.bar.io'
|
|
}
|
|
extra = provider._extra_changes(existing, [])
|
|
self.assertEquals(1, len(extra))
|
|
stubber.assert_no_pending_responses()
|
|
|
|
def test_route_53_record(self):
|
|
# Just make sure it doesn't blow up
|
|
_Route53Record('foo.unit.tests.', 'A', 30).__repr__()
|
|
|
|
def _get_test_plan(self, max_changes):
|
|
|
|
provider = Route53Provider('test', 'abc', '123', max_changes)
|
|
|
|
# Use the stubber
|
|
stubber = Stubber(provider._conn)
|
|
stubber.activate()
|
|
|
|
got = Zone('unit.tests.', [])
|
|
|
|
list_hosted_zones_resp = {
|
|
'HostedZones': [],
|
|
'Marker': 'm',
|
|
'IsTruncated': False,
|
|
'MaxItems': '100',
|
|
}
|
|
stubber.add_response('list_hosted_zones', list_hosted_zones_resp,
|
|
{})
|
|
|
|
create_hosted_zone_resp = {
|
|
'HostedZone': {
|
|
'Name': 'unit.tests.',
|
|
'Id': 'z42',
|
|
'CallerReference': 'abc',
|
|
},
|
|
'ChangeInfo': {
|
|
'Id': 'a12',
|
|
'Status': 'PENDING',
|
|
'SubmittedAt': '2017-01-29T01:02:03Z',
|
|
'Comment': 'hrm',
|
|
},
|
|
'DelegationSet': {
|
|
'Id': 'b23',
|
|
'CallerReference': 'blip',
|
|
'NameServers': [
|
|
'n12.unit.tests.',
|
|
],
|
|
},
|
|
'Location': 'us-east-1',
|
|
}
|
|
stubber.add_response('create_hosted_zone',
|
|
create_hosted_zone_resp, {
|
|
'Name': got.name,
|
|
'CallerReference': ANY,
|
|
})
|
|
|
|
stubber.add_response('list_health_checks',
|
|
{
|
|
'HealthChecks': self.health_checks,
|
|
'IsTruncated': False,
|
|
'MaxItems': '100',
|
|
'Marker': '',
|
|
})
|
|
|
|
stubber.add_response('change_resource_record_sets',
|
|
{'ChangeInfo': {
|
|
'Id': 'id',
|
|
'Status': 'PENDING',
|
|
'SubmittedAt': '2017-01-29T01:02:03Z',
|
|
}}, {'HostedZoneId': 'z42', 'ChangeBatch': ANY})
|
|
|
|
plan = provider.plan(self.expected)
|
|
|
|
return provider, plan
|
|
|
|
# _get_test_plan() returns a plan with 11 modifications, 17 RRs
|
|
|
|
@patch('octodns.provider.route53.Route53Provider._really_apply')
|
|
def test_apply_1(self, really_apply_mock):
|
|
|
|
# 17 RRs with max of 18 should only get applied in one call
|
|
provider, plan = self._get_test_plan(18)
|
|
provider.apply(plan)
|
|
really_apply_mock.assert_called_once()
|
|
|
|
@patch('octodns.provider.route53.Route53Provider._really_apply')
|
|
def test_apply_2(self, really_apply_mock):
|
|
|
|
# 17 RRs with max of 17 should only get applied in two calls
|
|
provider, plan = self._get_test_plan(17)
|
|
provider.apply(plan)
|
|
self.assertEquals(2, really_apply_mock.call_count)
|
|
|
|
@patch('octodns.provider.route53.Route53Provider._really_apply')
|
|
def test_apply_3(self, really_apply_mock):
|
|
|
|
# with a max of seven modifications, four calls
|
|
provider, plan = self._get_test_plan(7)
|
|
provider.apply(plan)
|
|
self.assertEquals(4, really_apply_mock.call_count)
|
|
|
|
@patch('octodns.provider.route53.Route53Provider._really_apply')
|
|
def test_apply_4(self, really_apply_mock):
|
|
|
|
# with a max of 11 modifications, two calls
|
|
provider, plan = self._get_test_plan(11)
|
|
provider.apply(plan)
|
|
self.assertEquals(2, really_apply_mock.call_count)
|
|
|
|
@patch('octodns.provider.route53.Route53Provider._really_apply')
|
|
def test_apply_bad(self, really_apply_mock):
|
|
|
|
# with a max of 1 modifications, fail
|
|
provider, plan = self._get_test_plan(1)
|
|
with self.assertRaises(Exception) as ctx:
|
|
provider.apply(plan)
|
|
self.assertTrue('modifications' in ctx.exception.message)
|
|
|
|
def test_semicolon_fixup(self):
|
|
provider = Route53Provider('test', 'abc', '123')
|
|
|
|
self.assertEquals({
|
|
'type': 'TXT',
|
|
'ttl': 30,
|
|
'values': [
|
|
'abcd\\; ef\\;g',
|
|
'hij\\; klm\\;n',
|
|
],
|
|
}, provider._data_for_quoted({
|
|
'ResourceRecords': [{
|
|
'Value': '"abcd; ef;g"',
|
|
}, {
|
|
'Value': '"hij\\; klm\\;n"',
|
|
}],
|
|
'TTL': 30,
|
|
'Type': 'TXT',
|
|
}))
|