mirror of
https://gitlab.labs.nic.cz/labs/bird.git
synced 2024-05-11 16:54:54 +00:00
Terminology cleanup: The import_control hook is now called preexport.
Once upon a time, far far away, there were the old Bird developers discussing what direction of route flow shall be called import and export. They decided to say "import to protocol" and "export to table" when speaking about a protocol. When speaking about a table, they spoke about "importing to table" and "exporting to protocol". The latter terminology was adopted in configuration, then also the bird CLI in commitea2ae6dd0
started to use it (in year 2009). Now it's 2018 and the terminology is the latter. Import is from protocol to table, export is from table to protocol. Anyway, there was still an import_control hook which executed right before route export. One thing is funny. There are two commits in April 1999 with just two minutes between them. The older announces the final settlement on config terminology, the newer uses the other definition. Let's see their commit messages as the git-log tool shows them (the newer first): commit9e0e485e50
Author: Martin Mares <mj@ucw.cz> Date: Mon Apr 5 20:17:59 1999 +0000 Added some new protocol hooks (look at the comments for better explanation): make_tmp_attrs Convert inline attributes to ea_list store_tmp_attrs Convert ea_list to inline attributes import_control Pre-import decisions commit5056c559c4
Author: Martin Mares <mj@ucw.cz> Date: Mon Apr 5 20:15:31 1999 +0000 Changed syntax of attaching filters to protocols to hopefully the final version: EXPORT <filter-spec> for outbound routes (i.e., those announced by BIRD to the rest of the world). IMPORT <filter-spec> for inbound routes (i.e., those imported by BIRD from the rest of the world). where <filter-spec> is one of: ALL pass all routes NONE drop all routes FILTER <name> use named filter FILTER { <filter> } use explicitly defined filter For all protocols, the default is IMPORT ALL, EXPORT NONE. This includes the kernel protocol, so that you need to add EXPORT ALL to get the previous configuration of kernel syncer (as usually, see doc/bird.conf.example for a bird.conf example :)). Let's say RIP to this almost 19-years-old inconsistency. For now, if you import a route, it is always from protocol to table. If you export a route, it is always from table to protocol. And they lived happily ever after.
This commit is contained in:
@@ -258,16 +258,16 @@ void store_tmp_attrs(rte *e, ea_list *attrs)
|
||||
{ DUMMY; }
|
||||
|
||||
/**
|
||||
* import_control - pre-filtering decisions on route import
|
||||
* @p: protocol instance the route is going to be imported to
|
||||
* preexport - pre-filtering decisions before route export
|
||||
* @p: protocol instance the route is going to be exported to
|
||||
* @e: the route in question
|
||||
* @attrs: extended attributes of the route
|
||||
* @pool: linear pool for allocation of all temporary data
|
||||
*
|
||||
* The import_control() hook is called as the first step of a exporting
|
||||
* The preexport() hook is called as the first step of a exporting
|
||||
* a route from a routing table to the protocol instance. It can modify
|
||||
* route attributes and force acceptance or rejection of the route regardless
|
||||
* of user-specified filters. See rte_announce() for a complete description
|
||||
* route attributes and force acceptance or rejection of the route before
|
||||
* the user-specified filters are run. See rte_announce() for a complete description
|
||||
* of the route distribution process.
|
||||
*
|
||||
* The standard use of this hook is to reject routes having originated
|
||||
@@ -276,7 +276,7 @@ void store_tmp_attrs(rte *e, ea_list *attrs)
|
||||
* Result: 1 if the route has to be accepted, -1 if rejected and 0 if it
|
||||
* should be passed to the filters.
|
||||
*/
|
||||
int import_control(struct proto *p, rte **e, ea_list **attrs, struct linpool *pool)
|
||||
int preexport(struct proto *p, rte **e, ea_list **attrs, struct linpool *pool)
|
||||
{ DUMMY; }
|
||||
|
||||
/**
|
||||
|
Reference in New Issue
Block a user