mirror/labs-bird
1
0
Fork 0
mirror of https://gitlab.labs.nic.cz/labs/bird.git synced 2024-05-11 16:54:54 +00:00
Code Releases Activity

Enforcing certain data structure explicit paddings.

Browse Source 
Implicit paddings have undefined values in C. We want the eattr blocks
to be comparable by memcmp and eattrs settable directly by structrure
literals. This check ensures that all paddings in eattr and bval are
explicit and therefore zeroed in all literals.
This commit is contained in:
Maria Matejka
2022-04-14 16:51:18 +02:00
parent c1194ab7ed
commit 1d309c4ce6
9 changed files with 139 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/type.h
View File

@@ -13,9 +13,15 @@
#include "lib/attrs.h"
union bval {
#define BVAL_ITEMS \
u32 data; /* Integer type inherited from eattrs */ \
u32 i; /* Integer type inherited from filters */ \
#define BVAL_ITEMS \
struct { \
u32 data; /* Integer type inherited from eattrs */ \
PADDING(data, 0, 4); /* Must be padded on 64-bits */ \
}; \
struct { \
u32 i; /* Integer type inherited from filters */ \
PADDING(i, 0, 4); /* Must be padded on 64-bits */ \
}; \
const struct adata *ptr; /* Generic attribute data inherited from eattrs */ \
const struct adata *ad; /* Generic attribute data inherited from filters */ \