diff --git a/snmp/osupdate b/snmp/osupdate index 1f4f948..11a6d9a 100755 --- a/snmp/osupdate +++ b/snmp/osupdate @@ -34,7 +34,8 @@ CMD_APK=' version' ################################################################ if command -v zypper &>/dev/null ; then # OpenSUSE - UPDATES=$($BIN_ZYPPER "$CMD_ZYPPER" | $BIN_WC $CMD_WC) + # shellcheck disable=SC2086 + UPDATES=$($BIN_ZYPPER $CMD_ZYPPER | $BIN_WC $CMD_WC) if [ "$UPDATES" -ge 2 ]; then echo $(($UPDATES-2)); else @@ -42,7 +43,8 @@ if command -v zypper &>/dev/null ; then fi elif command -v dnf &>/dev/null ; then # Fedora - UPDATES=$($BIN_DNF "$CMD_DNF" | $BIN_WC $CMD_WC) + # shellcheck disable=SC2086 + UPDATES=$($BIN_DNF $CMD_DNF | $BIN_WC $CMD_WC) if [ "$UPDATES" -ge 1 ]; then echo $(($UPDATES-1)); else @@ -58,7 +60,8 @@ elif command -v pacman &>/dev/null ; then fi elif command -v yum &>/dev/null ; then # CentOS / Redhat - UPDATES=$($BIN_YUM "$CMD_YUM" | $BIN_WC $CMD_WC) + # shellcheck disable=SC2086 + UPDATES=$($BIN_YUM $CMD_YUM | $BIN_WC $CMD_WC) if [ "$UPDATES" -ge 1 ]; then echo $(($UPDATES-1)); else @@ -66,7 +69,8 @@ elif command -v yum &>/dev/null ; then fi elif command -v apt-get &>/dev/null ; then # Debian / Devuan / Ubuntu - UPDATES=$($BIN_APT "$CMD_APT" | $BIN_GREP $CMD_GREP 'Inst') + # shellcheck disable=SC2086 + UPDATES=$($BIN_APT $CMD_APT | $BIN_GREP $CMD_GREP 'Inst') if [ "$UPDATES" -ge 1 ]; then echo "$UPDATES"; else @@ -74,7 +78,8 @@ elif command -v apt-get &>/dev/null ; then fi elif command -v pkg &>/dev/null ; then # FreeBSD - UPDATES=$($BIN_PKG "$CMD_PKG" | $BIN_WC $CMD_WC) + # shellcheck disable=SC2086 + UPDATES=$($BIN_PKG $CMD_PKG | $BIN_WC $CMD_WC) if [ "$UPDATES" -ge 1 ]; then echo "$UPDATES"; else @@ -82,7 +87,8 @@ elif command -v pkg &>/dev/null ; then fi elif command -v apk &>/dev/null ; then # Alpine - UPDATES=$($BIN_APK "$CMD_APK" | $BIN_WC $CMD_WC) + # shellcheck disable=SC2086 + UPDATES=$($BIN_APK $CMD_APK | $BIN_WC $CMD_WC) if [ "$UPDATES" -ge 2 ]; then echo $(($UPDATES-1)); else diff --git a/snmp/phpfpmsp b/snmp/phpfpmsp index 6fbf22c..481dc5d 100644 --- a/snmp/phpfpmsp +++ b/snmp/phpfpmsp @@ -42,7 +42,7 @@ # the URL to fetch, change as needed url="http://localhost/status?full" -opts="" +opts="-Ss" # netdata # real-time performance and health monitoring, done right! @@ -77,8 +77,8 @@ phpfpm_slow_requests=0 # local opts="${1}" url="${2}" - - phpfpm_response=("$(curl -Ss "${opts}" "${url}")") + # shellcheck disable=SC2207 + phpfpm_response=($(curl "${opts}" "${url}")) [ $? -ne 0 ] || [ "${#phpfpm_response[@]}" -eq 0 ] && exit 1 if [[ "${phpfpm_response[0]}" != "pool:" \