mirror/librenms-librenms-agent
1
0
Fork 0
mirror of https://github.com/librenms/librenms-agent.git synced 2024-05-09 09:54:52 +00:00
Code Releases Activity

update the guessing to only use smartctl --scan-open and generate with more complex options

Browse Source
This commit is contained in:
Zane C. Bowers-Hadley
2019-03-19 00:40:06 -05:00
parent cb04f8c0ac
commit bdfd0ceea9
1 changed files with 65 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

110
snmp/smart
View File

@ -73,10 +73,9 @@ my $useSN=1;
$Getopt::Std::STANDARD_HELP_VERSION = 1; $Getopt::Std::STANDARD_HELP_VERSION = 1;
sub main::VERSION_MESSAGE { sub main::VERSION_MESSAGE {
print "SMART SNMP extend 0.0.0\n"; print "SMART SNMP extend 0.1.0\n";
}; };
sub main::HELP_MESSAGE { sub main::HELP_MESSAGE {
print "\n". print "\n".
"-u Update '".$cache."'\n". "-u Update '".$cache."'\n".
@ -108,74 +107,69 @@ if ( defined( $opts{g} ) ){
$cache='cache='.$cache."\n"; $cache='cache='.$cache."\n";
} }
my %found_disks; # used for checking if a disk has been found more than once
my %found_disks_names;
#check for drives named /dev/sd* my @argumentsA;
my @matches=glob('/dev/sd*');
@matches=grep(!/[0-9]/, @matches);
my $matches_int=0;
while ( defined( $matches[$matches_int] ) ){
my $device=$matches[$matches_int];
system( $smartctl.' -A '.$device.' > /dev/null' );
if ( $? == 0 ){
$device =~ s/\/dev\///;
$found_disks{$device}=1;
}
$matches_int++;
}
#check for drives named /dev/ada*
@matches=glob('/dev/ada*');
@matches=grep(!/[ps]/, @matches);
$matches_int=0;
while ( defined( $matches[$matches_int] ) ){
my $device=$matches[$matches_int];
system( $smartctl.' -A '.$device.' > /dev/null' );
if ( $? == 0 ){
$device =~ s/\/dev\///;
$found_disks{$device}=1;
}
$matches_int++;
}
#check for drives named /dev/da*
@matches=glob('/dev/da*');
@matches=grep(!/[ps]/, @matches);
$matches_int=0;
while ( defined( $matches[$matches_int] ) ){
my $device=$matches[$matches_int];
system( $smartctl.' -A '.$device.' > /dev/null' );
if ( $? == 0 ){
$device =~ s/\/dev\///;
$found_disks{$device}=1;
}
$matches_int++;
}
#have smartctl scan and see if it finds anythings not get found #have smartctl scan and see if it finds anythings not get found
my $scan_output=`$smartctl --scan-open`; my $scan_output=`$smartctl --scan-open`;
my @scan_outputA=split(/\n/, $scan_output); my @scan_outputA=split(/\n/, $scan_output);
# remove non-SMART devices sometimes returned
@scan_outputA=grep(!/ses[0-9]/, @scan_outputA); # not a disk, but may or may not have SMART attributes @scan_outputA=grep(!/ses[0-9]/, @scan_outputA); # not a disk, but may or may not have SMART attributes
@scan_outputA=grep(!/pass[0-9]/, @scan_outputA); # very likely a duplicate and a disk under another name @scan_outputA=grep(!/pass[0-9]/, @scan_outputA); # very likely a duplicate and a disk under another name
$matches_int=0; @scan_outputA=grep(!/cd[0-9]/, @scan_outputA); # CD drive
while ( defined( $scan_outputA[$matches_int] ) ){ if ( $^O eq 'freebsd' ){
my $device=$scan_outputA[$matches_int]; @scan_outputA=grep(!/sa[0-9]/, @scan_outputA); # tape drive
$device =~ s/ .*//; @scan_outputA=grep(!/ctl[0-9]/, @scan_outputA); # CAM target layer
system( $smartctl.' -A '.$device.' > /dev/null' ); }elsif( $^O eq 'linux' ){
if ( $? == 0 ){ @scan_outputA=grep(!/st[0-9]/, @scan_outputA); # SCSI tape drive
$device =~ s/\/dev\///; @scan_outputA=grep(!/ht[0-9]/, @scan_outputA); # ATA tape drive
$found_disks{$device}=1; }
# make the first pass, figuring out what all we have and trimming comments
foreach my $arguments ( @scan_outputA ){
my $name = $arguments;
$arguments =~ s/ \#.*//; # trim the comment out of the argument
$name =~ s/ .*//;
$name =~ s/\/dev\///;
if (defined( $found_disks_names{$name} )){
$found_disks_names{$name}++;
}else{
$found_disks_names{$name}=0;
}
push( @argumentsA, $arguments );
}
# second pass, putting the lines together
my %current_disk;
my $drive_lines='';
foreach my $arguments ( @argumentsA ){
my $name = $arguments;
$name =~ s/ .*//;
$name =~ s/\/dev\///;
if ( $found_disks_names{$name} == 0 ){
# If no other devices, just name it after the base device.
$drive_lines=$drive_lines.$name." ".$arguments."\n";
}else{
# if more than one, start at zero and increment, apennding comma number to the base device name
if (defined( $current_disk{$name} )){
$current_disk{$name}++;
}else{
$current_disk{$name}=0;
}
$drive_lines=$drive_lines.$name.",".$current_disk{$name}." ".$arguments."\n";
} }
$matches_int++;
} }
print "useSN=0\n".'smartctl='.$smartctl."\n". print "useSN=0\n".'smartctl='.$smartctl."\n".
$cache. $cache.
join( "\n", keys(%found_disks) )."\n"; $drive_lines;
exit 0; exit 0;
} }