Remove legacy code and fix missing device graphs (#11950)

* removing $graphs global

* remove unused things

* fix some additional graphs

* Fix graphs persisting too soon

* correct name for poller module performance graph

* only one type of graph is used here

includes/definitions/benuos.yaml

@@ -12,8 +12,3 @@ over:
     - { graph: device_bits, text: 'Device Traffic' }
     - { graph: device_processor, text: 'Processor Usage' }
     - { graph: device_mempool, text: 'Memory Usage' }
-poller_modules:
-    mib: true
-register_mibs:
-    bTWagNumGrePmip6Tunnels: BENU-TWAG-STATS-MIB
-    bWagNumCurrentL2tpv3TunnelsIPv4: BENU-WAG-STATS-MIB

includes/definitions/coriant.yaml

@@ -37,5 +37,3 @@ discovery:
     -
         sysObjectID:
             - .1.3.6.1.4.1.42229.6.22
-register_mibs:
-    mefServiceEvcCfgTable: MEF-UNI-EVC-MIB

includes/definitions/ios.yaml

@@ -48,5 +48,3 @@ discovery_modules:
     cisco-pw: true
     vrf: true
     cisco-vrf-lite: true
-register_mibs:
-    ciscoAAASessionMIB: CISCO-AAA-SESSION-MIB

includes/definitions/iosxe.yaml

@@ -34,8 +34,6 @@ discovery_modules:
     vrf: true
     cisco-vrf-lite: true
     cisco-qfp: true
-register_mibs:
-    ciscoAAASessionMIB: CISCO-AAA-SESSION-MIB
 discovery:
     -
         sysDescr:

includes/definitions/iosxr.yaml

@@ -32,8 +32,6 @@ discovery_modules:
     cisco-pw: true
     vrf: true
     cisco-vrf-lite: true
-register_mibs:
-    ciscoAAASessionMIB: CISCO-AAA-SESSION-MIB
 discovery:
     -
         sysDescr:

includes/definitions/lenovoemc.yaml

@@ -9,11 +9,6 @@ over:
     - { graph: device_bits, text: 'Device Traffic' }
     - { graph: device_processor, text: 'CPU Usage' }
     - { graph: device_mempool, text: 'Memory Usage' }
-register_mibs:
-    fanValue: IOMEGANAS-MIB
-    tempValue: IOMEGANAS-MIB
-    raidStatus: IOMEGANAS-MIB
-    diskStatus: IOMEGANAS-MIB
 discovery:
     -
         sysDescr:

includes/definitions/pktj.yaml

@@ -8,15 +8,6 @@ over:
     - { graph: device_processor, text: 'Processor Usage' }
     - { graph: device_mempool, text: 'Memory Usage' }
 processor_stacked: true
-register_mibs:
-    rxCounter: GANDI-MIB
-    txCounter: GANDI-MIB
-    dropCounter: GANDI-MIB
-    acldropCounter: GANDI-MIB
-    ratedropCounter: GANDI-MIB
-    KNIrxCounter: GANDI-MIB
-    KNItxCounter: GANDI-MIB
-    KNIdropCounter: GANDI-MIB
 discovery:
     -
         sysDescr_regex: '/^Linux/'

includes/definitions/routeros.yaml

@@ -10,8 +10,6 @@ over:
     - { graph: device_bits, text: 'Device Traffic' }
     - { graph: device_processor, text: 'CPU Usage' }
     - { graph: device_mempool, text: 'Memory Usage' }
-register_mibs:
-    ciscoAAASessionMIB: CISCO-AAA-SESSION-MIB
 discovery:
     -
         sysObjectID:

includes/definitions/ruckuswireless.yaml

@@ -8,11 +8,6 @@ over:
     - { graph: device_bits, text: Traffic }
     - { graph: device_wireless_ap-count, text: 'Number of APs' }
     - { graph: device_wireless_clients, text: 'Number of Clients' }
-register_mibs:
-    ruckusZDSystemStats: RUCKUS-ZD-SYSTEM-MIB
-    ruckusZDWLANTable: RUCKUS-ZD-WLAN-MIB
-    ruckusZDWLANAPTable: RUCKUS-ZD-WLAN-MIB
-    ruckusZDWLANAPRadioStatsTable: RUCKUS-ZD-WLAN-MIB
 discovery:
     -
         sysObjectID: .1.3.6.1.4.1.25053.3.1.5

includes/definitions/serveriron.yaml

@@ -12,11 +12,3 @@ discovery:
     -
         sysDescr:
             - ServerIron
-register_mibs:
-    snL4slbTotalConnections: FOUNDRY-SN-SW-L4-SWITCH-GROUP-MIB
-    snL4slbLimitExceeds: FOUNDRY-SN-SW-L4-SWITCH-GROUP-MIB
-    snL4slbForwardTraffic: FOUNDRY-SN-SW-L4-SWITCH-GROUP-MIB
-    snL4slbReverseTraffic: FOUNDRY-SN-SW-L4-SWITCH-GROUP-MIB
-    snL4slbFinished: FOUNDRY-SN-SW-L4-SWITCH-GROUP-MIB
-    snL4FreeSessionCount: FOUNDRY-SN-SW-L4-SWITCH-GROUP-MIB
-    snL4unsuccessfulConn: FOUNDRY-SN-SW-L4-SWITCH-GROUP-MIB