mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

SnmpQuery default improvements (#16204)

Browse Source 
Always ignore underscores. Vendors constantly break this rule and it doesn't seem to have any side effects to enable -Pu.
translate respect hideMib() option
This commit is contained in:
Tony Murray
2024-07-15 08:52:37 -05:00
committed by GitHub
parent a87ed6dcc5
commit 04101c2c6f
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
LibreNMS/Data/Source/NetSnmpQuery.php
View File

@@ -80,7 +80,7 @@ class NetSnmpQuery implements SnmpQueryInterface
*/
private array $mibDirs = [];
private string $context = '';
private array|string $options = [self::DEFAULT_FLAGS];
private array|string $options = [self::DEFAULT_FLAGS, '-Pu'];
private Device $device;
private bool $abort = false;
private bool $cache = false;
@@ -312,7 +312,9 @@ class NetSnmpQuery implements SnmpQueryInterface
// user did not specify numeric, output full text
if (! in_array('-On', $this->options)) {
$this->options[] = '-OS';
if (! in_array('-Os', $this->options)) {
$this->options[] = '-OS'; // show full oid, unless hideMib is set
}
} elseif (Oid::isNumeric($oid)) {
return Str::start($oid, '.'); // numeric to numeric optimization
}